qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	Gautam Dawar <gdawar@xilinx.com>,
	Liuxiangdong <liuxiangdong5@huawei.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Parav Pandit <parav@mellanox.com>, Eric Blake <eblake@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	Eli Cohen <eli@mellanox.com>, Cindy Lu <lulu@redhat.com>,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Harpreet Singh Anand <hanand@xilinx.com>
Subject: [PATCH v5 19/20] vdpa: Add device migration blocker
Date: Tue, 19 Jul 2022 11:56:28 +0200	[thread overview]
Message-ID: <20220719095629.3031338-20-eperezma@redhat.com> (raw)
In-Reply-To: <20220719095629.3031338-1-eperezma@redhat.com>

Since the vhost-vdpa device is exposing _F_LOG, adding a migration blocker if
it uses CVQ.

However, qemu is able to migrate simple devices with no CVQ as long as
they use SVQ. To allow it, add a placeholder error to vhost_vdpa, and
only add to vhost_dev when used. vhost_dev machinery place the migration
blocker if needed.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 include/hw/virtio/vhost-vdpa.h |  1 +
 hw/virtio/vhost-vdpa.c         | 15 +++++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index 1111d85643..d10a89303e 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -35,6 +35,7 @@ typedef struct vhost_vdpa {
     bool shadow_vqs_enabled;
     /* IOVA mapping used by the Shadow Virtqueue */
     VhostIOVATree *iova_tree;
+    Error *migration_blocker;
     GPtrArray *shadow_vqs;
     const VhostShadowVirtqueueOps *shadow_vq_ops;
     void *shadow_vq_ops_opaque;
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index beaaa7049a..291cd19054 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -20,6 +20,7 @@
 #include "hw/virtio/vhost-shadow-virtqueue.h"
 #include "hw/virtio/vhost-vdpa.h"
 #include "exec/address-spaces.h"
+#include "migration/blocker.h"
 #include "qemu/cutils.h"
 #include "qemu/main-loop.h"
 #include "cpu.h"
@@ -1022,6 +1023,13 @@ static bool vhost_vdpa_svqs_start(struct vhost_dev *dev)
         return true;
     }
 
+    if (v->migration_blocker) {
+        int r = migrate_add_blocker(v->migration_blocker, &err);
+        if (unlikely(r < 0)) {
+            return false;
+        }
+    }
+
     for (i = 0; i < v->shadow_vqs->len; ++i) {
         VirtQueue *vq = virtio_get_queue(dev->vdev, dev->vq_index + i);
         VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, i);
@@ -1064,6 +1072,10 @@ err:
         vhost_svq_stop(svq);
     }
 
+    if (v->migration_blocker) {
+        migrate_del_blocker(v->migration_blocker);
+    }
+
     return false;
 }
 
@@ -1083,6 +1095,9 @@ static bool vhost_vdpa_svqs_stop(struct vhost_dev *dev)
         }
     }
 
+    if (v->migration_blocker) {
+        migrate_del_blocker(v->migration_blocker);
+    }
     return true;
 }
 
-- 
2.31.1



  parent reply	other threads:[~2022-07-19 10:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  9:56 [PATCH v5 00/20] vdpa net devices Rx filter change notification with Shadow VQ Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 01/20] vhost: move descriptor translation to vhost_svq_vring_write_descs Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 02/20] virtio-net: Expose MAC_TABLE_ENTRIES Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 03/20] virtio-net: Expose ctrl virtqueue logic Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 04/20] vdpa: Avoid compiler to squash reads to used idx Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 05/20] vhost: Reorder vhost_svq_kick Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 06/20] vhost: Move vhost_svq_kick call to vhost_svq_add Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 07/20] vhost: Check for queue full at vhost_svq_add Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 08/20] vhost: Decouple vhost_svq_add from VirtQueueElement Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 09/20] vhost: Add SVQDescState Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 10/20] vhost: Track number of descs in SVQDescState Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 11/20] vhost: add vhost_svq_push_elem Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 12/20] vhost: Expose vhost_svq_add Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 13/20] vhost: add vhost_svq_poll Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 14/20] vhost: Add svq avail_handler callback Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 15/20] vdpa: Export vhost_vdpa_dma_map and unmap calls Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 16/20] vdpa: manual forward CVQ buffers Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 17/20] vdpa: Buffer CVQ support on shadow virtqueue Eugenio Pérez
2022-07-19  9:56 ` [PATCH v5 18/20] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs Eugenio Pérez
2022-07-19  9:56 ` Eugenio Pérez [this message]
2022-07-19  9:56 ` [PATCH v5 20/20] vdpa: Add x-svq to NetdevVhostVDPAOptions Eugenio Pérez
2022-07-19 10:04 ` [PATCH v5 00/20] vdpa net devices Rx filter change notification with Shadow VQ Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220719095629.3031338-20-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eli@mellanox.com \
    --cc=gdawar@xilinx.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=liuxiangdong5@huawei.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@mellanox.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).