From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 2/4] semihosting: Don't copy buffer after console_write()
Date: Tue, 19 Jul 2022 13:11:08 +0100 [thread overview]
Message-ID: <20220719121110.225657-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20220719121110.225657-1-peter.maydell@linaro.org>
The console_write() semihosting function outputs guest data from a
buffer; it doesn't update that buffer. It therefore doesn't need to
pass a length value to unlock_user(), but can pass 0, meaning "do not
copy any data back to the guest memory".
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
semihosting/syscalls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/semihosting/syscalls.c b/semihosting/syscalls.c
index 4847f66c023..508a0ad88c6 100644
--- a/semihosting/syscalls.c
+++ b/semihosting/syscalls.c
@@ -627,7 +627,7 @@ static void console_write(CPUState *cs, gdb_syscall_complete_cb complete,
}
ret = qemu_semihosting_console_write(ptr, len);
complete(cs, ret ? ret : -1, ret ? 0 : EIO);
- unlock_user(ptr, buf, ret);
+ unlock_user(ptr, buf, 0);
}
static void console_fstat(CPUState *cs, gdb_syscall_complete_cb complete,
--
2.25.1
next prev parent reply other threads:[~2022-07-19 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 12:11 [PATCH 0/4] semihosting: fix various coverity issues Peter Maydell
2022-07-19 12:11 ` [PATCH 1/4] semihosting: Don't return negative values on qemu_semihosting_console_write() failure Peter Maydell
2022-07-24 16:28 ` Richard Henderson
2022-07-19 12:11 ` Peter Maydell [this message]
2022-07-24 16:30 ` [PATCH 2/4] semihosting: Don't copy buffer after console_write() Richard Henderson
2022-07-19 12:11 ` [PATCH 3/4] semihosting: Check for errors on SET_ARG() Peter Maydell
2022-07-24 16:35 ` Richard Henderson
2022-07-19 12:11 ` [PATCH 4/4] semihosting: Fix handling of buffer in TARGET_SYS_TMPNAM Peter Maydell
2022-07-24 21:55 ` Richard Henderson
2022-07-25 12:28 ` [PATCH 0/4] semihosting: fix various coverity issues Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719121110.225657-3-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).