From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-arm@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 0/3] target: RFC: display deprecation flag for '-cpu help'
Date: Fri, 22 Jul 2022 13:02:21 +0100 [thread overview]
Message-ID: <20220722120224.2311982-1-berrange@redhat.com> (raw)
When querying '-cpu help' there is no presentation of fact that a
CPU may be deprecated. The user just has to try it and see if they
get a depecation message at runtime. The QMP command for querying
CPUs report a deprecation bool flagreason.
The Icelake-Client CPU (removed in 6df39f5e583ca0f67bd934d1327f9ead2e3bd49c)
handled this by modifying the '.notes' section to add the word
'deprecated':
{
.version = 2,
.note = "no TSX, deprecated",
.alias = "Icelake-Client-noTSX",
.props = (PropValue[]) {
{ "hle", "off" },
{ "rtm", "off" },
{ /* end of list */ }
},
},
This relies on the person deprecating the CPU to remember to do this,
and is redundant when this info is already expressed in the
'.deprecation_note' field.
This short series suggests just modifying the '-cpu help'
formatter so that it displays '(deprecated)' next to any
CPUs
eg
$ qemu-system-x86_64 -cpu help:
Available CPUs:
x86 486 (alias configured by machine type) (deprecated)
This series touched x86_64, s390x, and aarch64 because that's all I
personally needed from a downstream POV, but any & all of the targets
would benefit from this. They have each implemented the '-cpu help'
logic independantly though, and unifying that code is not entirely
straightforward.
Changed in v2:
- Just include "deprecated" as a flag, not full description
which made the output too verbose and long lines.
Daniel P. Berrangé (3):
target/i386: display deprecation status in '-cpu help'
target/s390x: display deprecation status in '-cpu help'
target/arm: display deprecation status in '-cpu help'
target/arm/helper.c | 7 ++++++-
target/i386/cpu.c | 5 +++++
target/s390x/cpu_models.c | 23 ++++++++++++++++++-----
3 files changed, 29 insertions(+), 6 deletions(-)
--
2.36.1
next reply other threads:[~2022-07-22 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 12:02 Daniel P. Berrangé [this message]
2022-07-22 12:02 ` [PATCH v2 1/3] target/i386: display deprecation status in '-cpu help' Daniel P. Berrangé
2022-07-22 15:36 ` Cornelia Huck
2022-07-22 12:02 ` [PATCH v2 2/3] target/s390x: " Daniel P. Berrangé
2022-07-22 15:38 ` Cornelia Huck
2022-07-22 12:02 ` [PATCH v2 3/3] target/arm: " Daniel P. Berrangé
2022-07-22 15:40 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722120224.2311982-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).