From: Eric Blake <eblake@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 1/2] qapi: Add exit-failure PanicAction
Date: Mon, 25 Jul 2022 12:52:41 -0500 [thread overview]
Message-ID: <20220725175241.76jri4o3hlbh5icd@redhat.com> (raw)
In-Reply-To: <20220722233614.7254-2-iii@linux.ibm.com>
On Sat, Jul 23, 2022 at 01:36:13AM +0200, Ilya Leoshkevich wrote:
> Currently QEMU exits with code 0 on both panic an shutdown. For tests
> it is useful to return 1 on panic, so that it counts as a test
> failure.
>
> Introduce a new exit-failure PanicAction that makes main() return
> EXIT_FAILURE. Tests can use -action panic=exit-failure option to
> activate this behavior.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> +++ b/qapi/run-state.json
> @@ -364,10 +364,12 @@
> #
> # @shutdown: Shutdown the VM and exit, according to the shutdown action
> #
> +# @exit-failure: Shutdown the VM and exit with nonzero status
Missing a '(since 7.1)' tag. Otherwise a nice addition.
> +#
> # Since: 6.0
> ##
> { 'enum': 'PanicAction',
> - 'data': [ 'pause', 'shutdown', 'none' ] }
> + 'data': [ 'pause', 'shutdown', 'exit-failure', 'none' ] }
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-07-25 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 23:36 [PATCH v2 0/2] accel/tcg: Test unaligned stores to s390x low-address-protected lowcore Ilya Leoshkevich
2022-07-22 23:36 ` [PATCH v2 1/2] qapi: Add exit-failure PanicAction Ilya Leoshkevich
2022-07-24 22:27 ` Richard Henderson
2022-07-25 7:34 ` David Hildenbrand
2022-07-25 17:52 ` Eric Blake [this message]
2022-07-22 23:36 ` [PATCH v2 2/2] tests/tcg/s390x: Test unaligned accesses to lowcore Ilya Leoshkevich
2022-07-24 22:39 ` Richard Henderson
2022-07-25 12:41 ` [PATCH v2 0/2] accel/tcg: Test unaligned stores to s390x low-address-protected lowcore Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725175241.76jri4o3hlbh5icd@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).