qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org, richard.henderson@linaro.org
Cc: qemu-devel@nongnu.org, "Bin Meng" <bin.meng@windriver.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PULL 05/13] .gitlab-ci.d/windows.yml: Enable native Windows symlink
Date: Fri, 29 Jul 2022 10:19:35 +0100	[thread overview]
Message-ID: <20220729091943.2152410-6-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220729091943.2152410-1-alex.bennee@linaro.org>

From: Bin Meng <bin.meng@windriver.com>

The following error message was seen during the configure:

  "ln: failed to create symbolic link
  'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

By default the MSYS environment variable is not defined, so the runtime
behavior of winsymlinks is: if <target> does not exist, 'ln -s' fails.
At the configure phase, the qemu-system-x86_64.exe has not been built
so creation of the symbolic link fails hence the error message.

Set winsymlinks to 'native' whose behavior is most similar to the
behavior of 'ln -s' on *nix, that is:

  a) if native symlinks are enabled, and whether <target> exists
     or not, creates <destination> as a native Windows symlink;
  b) else if native symlinks are not enabled, and whether <target>
     exists or not, 'ln -s' creates as a Windows shortcut file.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725123000.807608-1-bmeng.cn@gmail.com>
Message-Id: <20220725140520.515340-6-alex.bennee@linaro.org>

diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
index 1b2ede49e1..0b9572a8a3 100644
--- a/.gitlab-ci.d/windows.yml
+++ b/.gitlab-ci.d/windows.yml
@@ -57,6 +57,7 @@ msys2-64bit:
       mingw-w64-x86_64-zstd "
   - $env:CHERE_INVOKING = 'yes'  # Preserve the current working directory
   - $env:MSYSTEM = 'MINGW64'     # Start a 64 bit Mingw environment
+  - $env:MSYS = 'winsymlinks:native' # Enable native Windows symlink
   - .\msys64\usr\bin\bash -lc './configure --target-list=x86_64-softmmu
       --enable-capstone --without-default-devices'
   - .\msys64\usr\bin\bash -lc "sed -i '/^ROMS=/d' build/config-host.mak"
@@ -89,6 +90,7 @@ msys2-32bit:
       mingw-w64-i686-usbredir "
   - $env:CHERE_INVOKING = 'yes'  # Preserve the current working directory
   - $env:MSYSTEM = 'MINGW32'     # Start a 32-bit MinG environment
+  - $env:MSYS = 'winsymlinks:native' # Enable native Windows symlink
   - mkdir output
   - cd output
   - ..\msys64\usr\bin\bash -lc "../configure --target-list=ppc64-softmmu"
-- 
2.30.2



  parent reply	other threads:[~2022-07-29  9:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  9:19 [PULL 00/13] testing, semihosting and doc fixes Alex Bennée
2022-07-29  9:19 ` [PULL 01/13] tests: refresh to latest libvirt-ci module Alex Bennée
2022-07-29  9:19 ` [PULL 02/13] gitlab: show testlog.txt contents when cirrus/custom-runner jobs fail Alex Bennée
2022-07-29  9:19 ` [PULL 03/13] gitlab: drop 'containers-layer2' stage Alex Bennée
2022-07-29  9:19 ` [PULL 04/13] .cirrus.yml: Change winsymlinks to 'native' Alex Bennée
2022-07-29  9:19 ` Alex Bennée [this message]
2022-07-29  9:19 ` [PULL 06/13] semihosting: Don't return negative values on qemu_semihosting_console_write() failure Alex Bennée
2022-07-29  9:19 ` [PULL 07/13] semihosting: Don't copy buffer after console_write() Alex Bennée
2022-07-29  9:19 ` [PULL 08/13] semihosting: Check for errors on SET_ARG() Alex Bennée
2022-07-29  9:19 ` [PULL 09/13] semihosting: Fix handling of buffer in TARGET_SYS_TMPNAM Alex Bennée
2022-07-29  9:19 ` [PULL 10/13] qapi: Add exit-failure PanicAction Alex Bennée
2022-07-29  9:19 ` [PULL 11/13] tests/tcg/s390x: Test unaligned accesses to lowcore Alex Bennée
2022-07-29  9:19 ` [PULL 12/13] docs/devel: fix description of OBJECT_DECLARE_SIMPLE_TYPE Alex Bennée
2022-07-29  9:19 ` [PULL 13/13] qemu-options: bring the kernel and image options together Alex Bennée
2022-07-29 15:36 ` [PULL 00/13] testing, semihosting and doc fixes Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220729091943.2152410-6-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bin.meng@windriver.com \
    --cc=bleal@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).