From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B710C19F28 for ; Wed, 3 Aug 2022 17:38:07 +0000 (UTC) Received: from localhost ([::1]:60690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJIJq-00058i-C3 for qemu-devel@archiver.kernel.org; Wed, 03 Aug 2022 13:38:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJII8-0001tX-R8 for qemu-devel@nongnu.org; Wed, 03 Aug 2022 13:36:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:26439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJII4-0000Fd-4q for qemu-devel@nongnu.org; Wed, 03 Aug 2022 13:36:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659548175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bq04tONNl/ykWgpL1Uyrw51luSKdbIbA68o5zFH45Gg=; b=SQTJ/8qVYxH2wFQvmRtnAjWtMS4WIsKXbTYvEIjaMCS6774i/phS2aUQAWaJE/1gQizHrj WJGhc/9HSRjKHJgXyvs+FsqiXKpoxhgcScyTdHYhZC1P90p1w88DiuZ49zKk+Cku5QSDvl Lag/5vu9WB/CYbKFwTusy9CaVpBXPrw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-511-TW_oDHkTP4KittC_JcuiIg-1; Wed, 03 Aug 2022 13:36:11 -0400 X-MC-Unique: TW_oDHkTP4KittC_JcuiIg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D25C811766; Wed, 3 Aug 2022 17:36:11 +0000 (UTC) Received: from localhost (unknown [10.39.193.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66D08403164; Wed, 3 Aug 2022 17:36:10 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Fam Zheng , Amit Shah , Laurent Vivier , Hanna Reitz , "Michael S . Tsirkin" , Stefan Hajnoczi , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Jason Wang , Paolo Bonzini , David Hildenbrand , Cornelia Huck Subject: [PATCH v2 1/2] virtio: document vdc->get_features() callback Date: Wed, 3 Aug 2022 13:36:05 -0400 Message-Id: <20220803173606.965926-2-stefanha@redhat.com> In-Reply-To: <20220803173606.965926-1-stefanha@redhat.com> References: <20220803173606.965926-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Suggested-by: Cornelia Huck Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index db1c0ddf6b..8d27fe1824 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -120,9 +120,29 @@ struct VirtioDeviceClass { /* This is what a VirtioDevice must implement */ DeviceRealize realize; DeviceUnrealize unrealize; + + /** + * get_features: + * @vdev: the VirtIODevice + * @requested_features: existing device feature bits from + * vdev->host_features + * @errp: pointer to error object + * + * Get the device feature bits. + * + * The ->get_features() function typically sets always-on device feature + * bits as well as conditional feature bits that require some logic to + * compute. + * + * Device feature bits can also be set in vdev->host_features before this + * function is called using DEFINE_PROP_BIT64() qdev properties. + * + * Returns: the final device feature bits to store in vdev->host_features. + */ uint64_t (*get_features)(VirtIODevice *vdev, uint64_t requested_features, Error **errp); + uint64_t (*bad_features)(VirtIODevice *vdev); void (*set_features)(VirtIODevice *vdev, uint64_t val); int (*validate_features)(VirtIODevice *vdev); -- 2.37.1