From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cindy Lu <lulu@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Parav Pandit <parav@mellanox.com>, Eric Blake <eblake@redhat.com>,
Gautam Dawar <gdawar@xilinx.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Liuxiangdong <liuxiangdong5@huawei.com>,
Eli Cohen <eli@mellanox.com>, Cornelia Huck <cohuck@redhat.com>,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH v7 12/12] vdpa: Delete CVQ migration blocker
Date: Thu, 4 Aug 2022 20:28:52 +0200 [thread overview]
Message-ID: <20220804182852.703398-13-eperezma@redhat.com> (raw)
In-Reply-To: <20220804182852.703398-1-eperezma@redhat.com>
We can restore the device state in the destination via CVQ now. Remove
the migration blocker.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
include/hw/virtio/vhost-vdpa.h | 1 -
hw/virtio/vhost-vdpa.c | 14 --------------
net/vhost-vdpa.c | 2 --
3 files changed, 17 deletions(-)
diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index d10a89303e..1111d85643 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -35,7 +35,6 @@ typedef struct vhost_vdpa {
bool shadow_vqs_enabled;
/* IOVA mapping used by the Shadow Virtqueue */
VhostIOVATree *iova_tree;
- Error *migration_blocker;
GPtrArray *shadow_vqs;
const VhostShadowVirtqueueOps *shadow_vq_ops;
void *shadow_vq_ops_opaque;
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 7e28d2f674..4b0cfc0f56 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1033,13 +1033,6 @@ static bool vhost_vdpa_svqs_start(struct vhost_dev *dev)
return true;
}
- if (v->migration_blocker) {
- int r = migrate_add_blocker(v->migration_blocker, &err);
- if (unlikely(r < 0)) {
- return false;
- }
- }
-
for (i = 0; i < v->shadow_vqs->len; ++i) {
VirtQueue *vq = virtio_get_queue(dev->vdev, dev->vq_index + i);
VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, i);
@@ -1082,10 +1075,6 @@ err:
vhost_svq_stop(svq);
}
- if (v->migration_blocker) {
- migrate_del_blocker(v->migration_blocker);
- }
-
return false;
}
@@ -1105,9 +1094,6 @@ static bool vhost_vdpa_svqs_stop(struct vhost_dev *dev)
}
}
- if (v->migration_blocker) {
- migrate_del_blocker(v->migration_blocker);
- }
return true;
}
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 4f1524c2e9..7c0d600aea 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -558,8 +558,6 @@ static NetClientState *net_vhost_vdpa_init(NetClientState *peer,
s->vhost_vdpa.shadow_vq_ops = &vhost_vdpa_net_svq_ops;
s->vhost_vdpa.shadow_vq_ops_opaque = s;
- error_setg(&s->vhost_vdpa.migration_blocker,
- "Migration disabled: vhost-vdpa uses CVQ.");
}
ret = vhost_vdpa_add(nc, (void *)&s->vhost_vdpa, queue_pair_index, nvqs);
if (ret) {
--
2.31.1
next prev parent reply other threads:[~2022-08-04 18:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:28 [PATCH v7 00/12] NIC vhost-vdpa state restore via Shadow CVQ Eugenio Pérez
2022-08-04 18:28 ` [PATCH v7 01/12] vhost: stop transfer elem ownership in vhost_handle_guest_kick Eugenio Pérez
2022-08-05 3:48 ` Jason Wang
2022-08-04 18:28 ` [PATCH v7 02/12] vhost: use SVQ element ndescs instead of opaque data for desc validation Eugenio Pérez
2022-08-05 3:48 ` Jason Wang
2022-08-04 18:28 ` [PATCH v7 03/12] vhost: Delete useless read memory barrier Eugenio Pérez
2022-08-05 3:48 ` Jason Wang
2022-08-04 18:28 ` [PATCH v7 04/12] vhost: Do not depend on !NULL VirtQueueElement on vhost_svq_flush Eugenio Pérez
2022-08-05 3:50 ` Jason Wang
2022-08-04 18:28 ` [PATCH v7 05/12] vhost_net: Add NetClientInfo prepare callback Eugenio Pérez
2022-08-09 6:53 ` Jason Wang
2022-08-09 7:34 ` Eugenio Perez Martin
2022-08-04 18:28 ` [PATCH v7 06/12] vhost_net: Add NetClientInfo stop callback Eugenio Pérez
2022-08-04 18:28 ` [PATCH v7 07/12] vdpa: add net_vhost_vdpa_cvq_info NetClientInfo Eugenio Pérez
2022-08-04 18:28 ` [PATCH v7 08/12] vdpa: Move command buffers map to start of net device Eugenio Pérez
2022-08-09 7:03 ` Jason Wang
2022-08-09 7:33 ` Eugenio Perez Martin
2022-08-09 7:48 ` Jason Wang
2022-08-09 8:03 ` Eugenio Perez Martin
2022-08-09 8:13 ` Jason Wang
2022-08-04 18:28 ` [PATCH v7 09/12] vdpa: Extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail Eugenio Pérez
2022-08-09 7:11 ` Jason Wang
2022-08-04 18:28 ` [PATCH v7 10/12] vhost_net: add NetClientState->load() callback Eugenio Pérez
2022-08-04 18:28 ` [PATCH v7 11/12] vdpa: Add virtio-net mac address via CVQ at start Eugenio Pérez
2022-08-09 7:16 ` Jason Wang
2022-08-09 7:35 ` Eugenio Perez Martin
2022-08-09 7:49 ` Jason Wang
2022-08-04 18:28 ` Eugenio Pérez [this message]
2022-08-09 7:17 ` [PATCH v7 12/12] vdpa: Delete CVQ migration blocker Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804182852.703398-13-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=eli@mellanox.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).