qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH 6/9] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD
Date: Mon,  8 Aug 2022 14:07:31 +0200	[thread overview]
Message-ID: <20220808120734.1168314-7-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20220808120734.1168314-1-alexander.ivanov@virtuozzo.com>

Replace the way that we use mutex in parallels_co_check() for more clean code.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 block/parallels.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index b0982d60d0..3cb5452613 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -577,28 +577,25 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
     BDRVParallelsState *s = bs->opaque;
     int ret;
 
-    qemu_co_mutex_lock(&s->lock);
+    WITH_QEMU_LOCK_GUARD(&s->lock);
 
     parallels_check_unclean(bs, res, fix);
 
     ret = parallels_check_outside_image(bs, res, fix);
     if (ret < 0) {
-        goto out;
+        return ret;
     }
 
     ret = parallels_check_leak(bs, res, fix);
     if (ret < 0) {
-        goto out;
+        return ret;
     }
 
     parallels_check_fragmentation(bs, res, fix);
 
     parallels_collect_statistics(bs, res, fix);
 
-    ret = 0;
-out:
-    qemu_co_mutex_unlock(&s->lock);
-    return ret;
+    return 0;
 }
 
 
-- 
2.34.1



  parent reply	other threads:[~2022-08-08 12:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 12:07 [PATCH 0/9] parallels: Refactor the code of images checks and fix a bug Alexander Ivanov
2022-08-08 12:07 ` [PATCH 1/9] parallels: Move check of unclean image to a separate function Alexander Ivanov
2022-08-08 12:32   ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 2/9] parallels: Move check of cluster outside " Alexander Ivanov
2022-08-08 12:19   ` Denis V. Lunev
2022-08-08 12:31     ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 3/9] parallels: Move check of leaks " Alexander Ivanov
2022-08-08 12:07 ` [PATCH 4/9] parallels: Move check of fragmentation " Alexander Ivanov
2022-08-08 12:07 ` [PATCH 5/9] parallels: Move statistic collection " Alexander Ivanov
2022-08-08 12:18   ` Denis V. Lunev
2022-08-08 12:07 ` Alexander Ivanov [this message]
2022-08-08 12:07 ` [PATCH 7/9] parallels: Out of image offset in BAT leads to image inflation Alexander Ivanov
2022-08-08 12:43   ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 8/9] parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT flushing Alexander Ivanov
2022-08-08 12:24   ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 9/9] parallels: Merge parallels_check_fragmentation to parallels_collect_statistics Alexander Ivanov
2022-08-08 12:26   ` Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808120734.1168314-7-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).