From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH 8/9] parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT flushing
Date: Mon, 8 Aug 2022 14:07:33 +0200 [thread overview]
Message-ID: <20220808120734.1168314-9-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20220808120734.1168314-1-alexander.ivanov@virtuozzo.com>
It's too costly to write all the BAT to the disk. Let the flush function
write only dirty blocks.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 72cf7499c1..38b1482e81 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -469,7 +469,7 @@ static int parallels_check_outside_image(BlockDriverState *bs,
}
if (flush_bat) {
- ret = bdrv_co_pwrite_sync(bs->file, 0, s->header_size, s->header, 0);
+ ret = bdrv_co_flush(bs);
if (ret < 0) {
res->check_errors++;
return ret;
--
2.34.1
next prev parent reply other threads:[~2022-08-08 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 12:07 [PATCH 0/9] parallels: Refactor the code of images checks and fix a bug Alexander Ivanov
2022-08-08 12:07 ` [PATCH 1/9] parallels: Move check of unclean image to a separate function Alexander Ivanov
2022-08-08 12:32 ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 2/9] parallels: Move check of cluster outside " Alexander Ivanov
2022-08-08 12:19 ` Denis V. Lunev
2022-08-08 12:31 ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 3/9] parallels: Move check of leaks " Alexander Ivanov
2022-08-08 12:07 ` [PATCH 4/9] parallels: Move check of fragmentation " Alexander Ivanov
2022-08-08 12:07 ` [PATCH 5/9] parallels: Move statistic collection " Alexander Ivanov
2022-08-08 12:18 ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 6/9] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD Alexander Ivanov
2022-08-08 12:07 ` [PATCH 7/9] parallels: Out of image offset in BAT leads to image inflation Alexander Ivanov
2022-08-08 12:43 ` Denis V. Lunev
2022-08-08 12:07 ` Alexander Ivanov [this message]
2022-08-08 12:24 ` [PATCH 8/9] parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT flushing Denis V. Lunev
2022-08-08 12:07 ` [PATCH 9/9] parallels: Merge parallels_check_fragmentation to parallels_collect_statistics Alexander Ivanov
2022-08-08 12:26 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808120734.1168314-9-alexander.ivanov@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).