Re: [PATCH v2 3/3] util/mmap-alloc: Remove qemu_mempath_getpagesize()

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Wed, 10 Aug 2022 14:57:20 +0200
Thomas Huth <thuth@redhat.com> wrote:

> The last user of this function has just been removed, so we can
> drop this function now, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  include/qemu/mmap-alloc.h |  2 --
>  util/mmap-alloc.c         | 31 -------------------------------
>  2 files changed, 33 deletions(-)
> 
> diff --git a/include/qemu/mmap-alloc.h b/include/qemu/mmap-alloc.h
> index 5076695cc8..2825e231a7 100644
> --- a/include/qemu/mmap-alloc.h
> +++ b/include/qemu/mmap-alloc.h
> @@ -4,8 +4,6 @@
>  
>  size_t qemu_fd_getpagesize(int fd);
>  
> -size_t qemu_mempath_getpagesize(const char *mem_path);
> -
>  /**
>   * qemu_ram_mmap: mmap anonymous memory, the specified file or device.
>   *
> diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c
> index 5b90cb68ea..5ed7d29183 100644
> --- a/util/mmap-alloc.c
> +++ b/util/mmap-alloc.c
> @@ -53,37 +53,6 @@ size_t qemu_fd_getpagesize(int fd)
>      return qemu_real_host_page_size();
>  }
>  
> -size_t qemu_mempath_getpagesize(const char *mem_path)
> -{
> -#ifdef CONFIG_LINUX
> -    struct statfs fs;
> -    int ret;
> -
> -    if (mem_path) {
> -        do {
> -            ret = statfs(mem_path, &fs);
> -        } while (ret != 0 && errno == EINTR);
> -
> -        if (ret != 0) {
> -            fprintf(stderr, "Couldn't statfs() memory path: %s\n",
> -                    strerror(errno));
> -            exit(1);
> -        }
> -
> -        if (fs.f_type == HUGETLBFS_MAGIC) {
> -            /* It's hugepage, return the huge page size */
> -            return fs.f_bsize;
> -        }
> -    }
> -#ifdef __sparc__
> -    /* SPARC Linux needs greater alignment than the pagesize */
> -    return QEMU_VMALLOC_ALIGN;
> -#endif
> -#endif
> -
> -    return qemu_real_host_page_size();
> -}
> -
>  #define OVERCOMMIT_MEMORY_PATH "/proc/sys/vm/overcommit_memory"
>  static bool map_noreserve_effective(int fd, uint32_t qemu_map_flags)
>  {