From: Conor Dooley <mail@conchuod.ie>
To: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>
Cc: Rob Herring <robh@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
Jessica Clarke <jrtc27@jrtc27.com>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
linux-riscv@lists.infradead.org
Subject: [PATCH v3 4/4] hw/core: fix platform bus node name
Date: Wed, 10 Aug 2022 19:46:12 +0100 [thread overview]
Message-ID: <20220810184612.157317-5-mail@conchuod.ie> (raw)
In-Reply-To: <20220810184612.157317-1-mail@conchuod.ie>
From: Conor Dooley <conor.dooley@microchip.com>
"platform" is not a valid name for a bus node in dt-schema, so warnings
can be see in dt-validate on a dump of the riscv virt dtb:
/stuff/qemu/qemu.dtb: platform@4000000: $nodename:0: 'platform@4000000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
From schema: /home/conor/.local/lib/python3.9/site-packages/dtschema/schemas/simple-bus.yaml
"platform-bus" is a valid name, so use that instead.
CC: Rob Herring <robh@kernel.org>
Fixes: 11d306b9df ("hw/arm/sysbus-fdt: helpers for platform bus nodes addition")
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
hw/core/sysbus-fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c
index 19d22cbe73..edb0c49b19 100644
--- a/hw/core/sysbus-fdt.c
+++ b/hw/core/sysbus-fdt.c
@@ -539,7 +539,7 @@ void platform_bus_add_all_fdt_nodes(void *fdt, const char *intc, hwaddr addr,
assert(fdt);
- node = g_strdup_printf("/platform@%"PRIx64, addr);
+ node = g_strdup_printf("/platform-bus@%"PRIx64, addr);
/* Create a /platform node that we can put all devices into */
qemu_fdt_add_subnode(fdt, node);
--
2.37.1
next prev parent reply other threads:[~2022-08-10 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 18:46 [PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs Conor Dooley
2022-08-10 18:46 ` [PATCH v3 1/4] hw/riscv: virt: fix uart node name Conor Dooley
2022-08-10 18:46 ` [PATCH v3 2/4] hw/riscv: virt: fix the plic's address cells Conor Dooley
2022-08-10 18:46 ` [PATCH v3 3/4] hw/riscv: virt: fix syscon subnode paths Conor Dooley
2022-08-14 21:55 ` Alistair Francis
2022-08-10 18:46 ` Conor Dooley [this message]
2022-08-22 3:34 ` [PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810184612.157317-5-mail@conchuod.ie \
--to=mail@conchuod.ie \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=conor.dooley@microchip.com \
--cc=jrtc27@jrtc27.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).