From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 02/10] hw/virtio: gracefully handle unset vhost_dev vdev
Date: Wed, 17 Aug 2022 12:14:36 -0400 [thread overview]
Message-ID: <20220817161342.240674-3-mst@redhat.com> (raw)
In-Reply-To: <20220817161342.240674-1-mst@redhat.com>
From: Alex Bennée <alex.bennee@linaro.org>
I've noticed asserts firing because we query the status of vdev after
a vhost connection is closed down. Rather than faulting on the NULL
indirect just quietly reply false.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220728135503.1060062-3-alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/vhost.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 0827d631c0..f758f177bb 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -306,7 +306,7 @@ static inline void vhost_dev_log_resize(struct vhost_dev *dev, uint64_t size)
dev->log_size = size;
}
-static int vhost_dev_has_iommu(struct vhost_dev *dev)
+static bool vhost_dev_has_iommu(struct vhost_dev *dev)
{
VirtIODevice *vdev = dev->vdev;
@@ -316,8 +316,12 @@ static int vhost_dev_has_iommu(struct vhost_dev *dev)
* does not have IOMMU, there's no need to enable this feature
* which may cause unnecessary IOTLB miss/update transactions.
*/
- return virtio_bus_device_iommu_enabled(vdev) &&
- virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
+ if (vdev) {
+ return virtio_bus_device_iommu_enabled(vdev) &&
+ virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
+ } else {
+ return false;
+ }
}
static void *vhost_memory_map(struct vhost_dev *dev, hwaddr addr,
--
MST
next prev parent reply other threads:[~2022-08-17 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 16:14 [PULL 00/10] pc,virtio: fixes Michael S. Tsirkin
2022-08-17 16:14 ` [PULL 01/10] virtio-scsi: fix race in virtio_scsi_dataplane_start() Michael S. Tsirkin
2022-08-17 16:14 ` Michael S. Tsirkin [this message]
2022-08-17 16:14 ` [PULL 03/10] hw/virtio: handle un-configured shutdown in virtio-pci Michael S. Tsirkin
2022-08-17 16:14 ` [PULL 04/10] hw/virtio: fix vhost_user_read tracepoint Michael S. Tsirkin
2022-08-17 16:14 ` [PULL 05/10] x86: disable rng seeding via setup_data Michael S. Tsirkin
2022-08-18 9:27 ` Paolo Bonzini
2022-08-18 9:54 ` Michael S. Tsirkin
2022-08-18 11:56 ` Gerd Hoffmann
2022-08-18 15:39 ` Jason A. Donenfeld
2022-08-17 16:14 ` [PULL 06/10] hw/cxl: Add stub write function for RO MemoryRegionOps entries Michael S. Tsirkin
2022-08-17 16:14 ` [PULL 07/10] hw/cxl: Fix Get LSA input payload size which should be 8 bytes Michael S. Tsirkin
2022-08-17 16:14 ` [PULL 08/10] hw/cxl: Correctly handle variable sized mailbox input payloads Michael S. Tsirkin
2022-08-17 16:15 ` [PULL 09/10] tests: acpi: silence applesmc warning about invalid key Michael S. Tsirkin
2022-08-17 16:15 ` [PULL 10/10] virtio-pci: don't touch pci on virtio reset Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817161342.240674-3-mst@redhat.com \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).