qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH v5 9/9] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD
Date: Mon, 22 Aug 2022 11:05:17 +0200	[thread overview]
Message-ID: <20220822090517.2289697-10-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20220822090517.2289697-1-alexander.ivanov@virtuozzo.com>

Replace the way we use mutex in parallels_co_check() for simplier
and less error prone code.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org> 
---
 block/parallels.c | 33 ++++++++++++++-------------------
 1 file changed, 14 insertions(+), 19 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index 0fe6dd3237..47ef25b193 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -563,30 +563,25 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
     BDRVParallelsState *s = bs->opaque;
     int ret;
 
-    qemu_co_mutex_lock(&s->lock);
+    WITH_QEMU_LOCK_GUARD(&s->lock) {
+        parallels_check_unclean(bs, res, fix);
 
-    parallels_check_unclean(bs, res, fix);
+        ret = parallels_check_outside_image(bs, res, fix);
+        if (ret < 0) {
+            return ret;
+        }
 
-    ret = parallels_check_outside_image(bs, res, fix);
-    if (ret < 0) {
-        goto out;
-    }
+        ret = parallels_check_leak(bs, res, fix);
+        if (ret < 0) {
+            return ret;
+        }
 
-    ret = parallels_check_leak(bs, res, fix);
-    if (ret < 0) {
-        goto out;
+        parallels_collect_statistics(bs, res, fix);
     }
 
-    parallels_collect_statistics(bs, res, fix);
-
-out:
-    qemu_co_mutex_unlock(&s->lock);
-
-    if (ret == 0) {
-        ret = bdrv_co_flush(bs);
-        if (ret < 0) {
-            res->check_errors++;
-        }
+    ret = bdrv_co_flush(bs);
+    if (ret < 0) {
+        res->check_errors++;
     }
 
     return ret;
-- 
2.34.1



      parent reply	other threads:[~2022-08-22  9:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  9:05 [PATCH v5 0/9] parallels: Refactor the code of images checks and fix a bug Alexander Ivanov
2022-08-22  9:05 ` [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation Alexander Ivanov
2022-08-23  6:58   ` Vladimir Sementsov-Ogievskiy
2022-08-23  7:23     ` Alexander Ivanov
2022-08-23  7:59       ` Vladimir Sementsov-Ogievskiy
2022-08-23  9:45         ` Vladimir Sementsov-Ogievskiy
2022-08-23  9:20       ` Denis V. Lunev
2022-08-23  9:49         ` Alexander Ivanov
2022-08-23  9:58         ` Vladimir Sementsov-Ogievskiy
2022-08-23 10:11           ` Denis V. Lunev
2022-08-24  8:50             ` Vladimir Sementsov-Ogievskiy
2022-08-23 13:50           ` Alexander Ivanov
2022-08-23 15:43             ` Vladimir Sementsov-Ogievskiy
2022-08-23  9:34     ` Denis V. Lunev
2022-08-23  9:47       ` Vladimir Sementsov-Ogievskiy
2022-08-23 10:02         ` Denis V. Lunev
2022-08-23  9:51   ` Denis V. Lunev
2022-08-22  9:05 ` [PATCH v5 2/9] parallels: Fix data_end field value in parallels_co_check() Alexander Ivanov
2022-08-23  7:38   ` Vladimir Sementsov-Ogievskiy
2022-08-23  9:00     ` Alexander Ivanov
2022-08-23  9:23   ` Denis V. Lunev
2022-08-22  9:05 ` [PATCH v5 3/9] parallels: create parallels_set_bat_entry_helper() to assign BAT value Alexander Ivanov
2022-08-22  9:05 ` [PATCH v5 4/9] parallels: Use generic infrastructure for BAT writing in parallels_co_check() Alexander Ivanov
2022-08-23  9:36   ` Denis V. Lunev
2022-08-22  9:05 ` [PATCH v5 5/9] parallels: Move check of unclean image to a separate function Alexander Ivanov
2022-08-22  9:05 ` [PATCH v5 6/9] parallels: Move check of cluster outside " Alexander Ivanov
2022-08-22  9:05 ` [PATCH v5 7/9] parallels: Move check of leaks " Alexander Ivanov
2022-08-23  9:40   ` Denis V. Lunev
2022-08-23  9:56     ` Alexander Ivanov
2022-08-22  9:05 ` [PATCH v5 8/9] parallels: Move statistic collection " Alexander Ivanov
2022-08-22  9:05 ` Alexander Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822090517.2289697-10-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).