qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH  v1 1/6] tests/avocado: push default timeout to QemuBaseTest
Date: Mon, 22 Aug 2022 17:56:03 +0100	[thread overview]
Message-ID: <20220822165608.2980552-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220822165608.2980552-1-alex.bennee@linaro.org>

All of the QEMU tests eventually end up derrived from this class. Move
the default timeout from LinuxTest to ensure we catch them all. As 15
minutes is fairly excessive we drop the default down to 2 minutes
which is a more reasonable target for tests to aim for.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220816133831.2166761-1-alex.bennee@linaro.org>

---
v2
  - lower timeout to 2 minutes/120 seconds
---
 tests/avocado/avocado_qemu/__init__.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
index ed4853c805..0efd2bd212 100644
--- a/tests/avocado/avocado_qemu/__init__.py
+++ b/tests/avocado/avocado_qemu/__init__.py
@@ -227,6 +227,10 @@ def exec_command_and_wait_for_pattern(test, command,
     _console_interaction(test, success_message, failure_message, command + '\r')
 
 class QemuBaseTest(avocado.Test):
+
+    # default timeout for all tests, can be overridden
+    timeout = 120
+
     def _get_unique_tag_val(self, tag_name):
         """
         Gets a tag value, if unique for a key
@@ -512,7 +516,6 @@ class LinuxTest(LinuxSSHMixIn, QemuSystemTest):
     to start with than the more vanilla `QemuSystemTest` class.
     """
 
-    timeout = 900
     distro = None
     username = 'root'
     password = 'password'
-- 
2.30.2



  reply	other threads:[~2022-08-22 18:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 16:56 [PATCH for 7.1 v1 0/6] testing fixes and doc tweak pre-PR Alex Bennée
2022-08-22 16:56 ` Alex Bennée [this message]
2022-08-22 20:50   ` [PATCH v1 1/6] tests/avocado: push default timeout to QemuBaseTest Richard Henderson
2022-08-25 14:11   ` Philippe Mathieu-Daudé via
2022-08-22 16:56 ` [PATCH v1 2/6] tests/qtest/migration-test: Only wait for serial output where migration succeeds Alex Bennée
2022-08-22 21:14   ` Juan Quintela
2022-08-22 16:56 ` [PATCH v1 3/6] tests/migration/aarch64: Speed up the aarch64 migration test Alex Bennée
2022-08-22 16:56 ` [PATCH v1 4/6] tests/migration/i386: Speed up the i386 migration test (when using TCG) Alex Bennée
2022-08-22 16:56 ` [PATCH v1 5/6] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan Alex Bennée
2022-08-22 21:26   ` Juan Quintela
2022-08-22 16:56 ` [PATCH v1 6/6] qemu-options: try and clarify preferred block semantics Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822165608.2980552-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).