From: Samuel Thibault <samuel.thibault@gnu.org>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Daniel P . Berrange" <berrange@redhat.com>
Subject: Re: [PATCH v2 for-7.2 0/6] Drop libslirp submodule
Date: Wed, 24 Aug 2022 21:46:50 +0200 [thread overview]
Message-ID: <20220824194650.ygpenow5za5fszbk@begin> (raw)
In-Reply-To: <20220824151122.704946-1-thuth@redhat.com>
Thomas Huth, le mer. 24 août 2022 17:11:16 +0200, a ecrit:
> At the point in time we're going to release QEMU 7.2, all supported
> host OS distributions will have a libslirp package available, so
> there is no need anymore for us to ship the slirp submodule. Thus
> let's clean up the related tests and finally remove the submodule now.
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> v2:
> - Added patches to clean up and adapt the tests
> - Rebased the removal patch to the latest version of the master branch
>
> Thomas Huth (6):
> tests/docker: Update the debian-all-test-cross container to Debian 11
> tests/vm: Add libslirp to the VM tests
> tests/lcitool/libvirt-ci: Update the lcitool module to the latest
> version
> tests: Refresh dockerfiles and FreeBSD vars with lcitool
> tests/avocado: Do not run tests that require libslirp if it is not
> available
> Remove the slirp submodule (i.e. compile only with an external
> libslirp)
>
> configure | 24 ----
> meson.build | 121 ++++--------------
> .gitlab-ci.d/buildtest.yml | 20 ++-
> .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-
> .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
> .gitlab-ci.d/container-cross.yml | 1 -
> .gitmodules | 3 -
> MAINTAINERS | 1 -
> meson_options.txt | 5 +-
> scripts/archive-source.sh | 2 +-
> scripts/meson-buildoptions.sh | 4 +-
> slirp | 1 -
> tests/avocado/avocado_qemu/__init__.py | 7 +
> tests/avocado/info_usernet.py | 1 +
> tests/avocado/replay_linux.py | 1 +
> tests/docker/Makefile.include | 1 -
> .../dockerfiles/debian-all-test-cross.docker | 9 +-
> tests/docker/dockerfiles/opensuse-leap.docker | 2 +-
> tests/docker/dockerfiles/ubuntu2004.docker | 2 +-
> tests/lcitool/libvirt-ci | 2 +-
> tests/vm/freebsd | 3 +
> tests/vm/haiku.x86_64 | 3 +-
> tests/vm/netbsd | 3 +
> 23 files changed, 64 insertions(+), 156 deletions(-)
> delete mode 160000 slirp
>
> --
> 2.31.1
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
next prev parent reply other threads:[~2022-08-24 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:11 [PATCH v2 for-7.2 0/6] Drop libslirp submodule Thomas Huth
2022-08-24 15:11 ` [PATCH 1/6] tests/docker: Update the debian-all-test-cross container to Debian 11 Thomas Huth
2022-08-24 15:11 ` [PATCH 2/6] tests/vm: Add libslirp to the VM tests Thomas Huth
2022-08-24 15:11 ` [PATCH 3/6] tests/lcitool/libvirt-ci: Update the lcitool module to the latest version Thomas Huth
2022-08-24 15:11 ` [PATCH 4/6] tests: Refresh dockerfiles and FreeBSD vars with lcitool Thomas Huth
2022-08-24 15:11 ` [PATCH 5/6] tests/avocado: Do not run tests that require libslirp if it is not available Thomas Huth
2022-08-24 15:11 ` [PATCH v2 6/6] Remove the slirp submodule (i.e. compile only with an external libslirp) Thomas Huth
2022-08-24 19:46 ` Samuel Thibault [this message]
2022-09-30 16:50 ` [PATCH v2 for-7.2 0/6] Drop libslirp submodule Christian Schoenebeck
2022-09-30 17:27 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824194650.ygpenow5za5fszbk@begin \
--to=samuel.thibault@gnu.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).