From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Huacai Chen" <chenhuacai@kernel.org>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 09/10] hw/isa/vt82c686: Embed RTCState in host device
Date: Tue, 30 Aug 2022 21:00:47 +0200 [thread overview]
Message-ID: <20220830190048.67448-10-shentey@gmail.com> (raw)
In-Reply-To: <20220830190048.67448-1-shentey@gmail.com>
Embed the rtc in the host device, analoguous to the other child devices
and analoguous to PIIX4.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/isa/vt82c686.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 150e9401d0..0ef9446374 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -549,6 +549,7 @@ struct ViaISAState {
qemu_irq cpu_intr;
qemu_irq *isa_irqs;
ViaSuperIOState via_sio;
+ RTCState rtc;
PCIIDEState ide;
UHCIState uhci[2];
ViaPMState pm;
@@ -570,6 +571,7 @@ static void via_isa_init(Object *obj)
{
ViaISAState *s = VIA_ISA(obj);
+ object_initialize_child(obj, "rtc", &s->rtc, TYPE_MC146818_RTC);
object_initialize_child(obj, "ide", &s->ide, "via-ide");
object_initialize_child(obj, "uhci1", &s->uhci[0], "vt82c686b-usb-uhci");
object_initialize_child(obj, "uhci2", &s->uhci[1], "vt82c686b-usb-uhci");
@@ -623,7 +625,15 @@ static void via_isa_realize(PCIDevice *d, Error **errp)
isa_bus_irqs(isa_bus, s->isa_irqs);
i8254_pit_init(isa_bus, 0x40, 0, NULL);
i8257_dma_init(isa_bus, 0);
- mc146818_rtc_init(isa_bus, 2000, NULL);
+
+ /* RTC */
+ qdev_prop_set_int32(DEVICE(&s->rtc), "base_year", 2000);
+ if (!qdev_realize(DEVICE(&s->rtc), BUS(isa_bus), errp)) {
+ return;
+ }
+ object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(&s->rtc),
+ "date");
+ isa_connect_gpio_out(ISA_DEVICE(&s->rtc), 0, s->rtc.isairq);
for (i = 0; i < PCI_CONFIG_HEADER_SIZE; i++) {
if (i < PCI_COMMAND || i >= PCI_REVISION_ID) {
--
2.37.2
next prev parent reply other threads:[~2022-08-30 19:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:00 [PATCH v2 00/10] Instantiate VT82xx functions in host device Bernhard Beschow
2022-08-30 19:00 ` [PATCH v2 01/10] hw/isa/vt82c686: Resolve chip-specific realize methods Bernhard Beschow
2022-08-30 19:00 ` [PATCH v2 02/10] hw/isa/vt82c686: Resolve unneeded attribute Bernhard Beschow
2022-08-30 19:00 ` [PATCH v2 03/10] hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory() Bernhard Beschow
2022-08-30 22:41 ` BALATON Zoltan
2022-08-30 19:00 ` [PATCH v2 04/10] hw/isa/vt82c686: Reuse errp Bernhard Beschow
2022-08-30 19:00 ` [PATCH v2 05/10] hw/isa/vt82c686: Instantiate IDE function in host device Bernhard Beschow
2022-08-30 19:00 ` [PATCH v2 06/10] hw/isa/vt82c686: Instantiate USB functions " Bernhard Beschow
2022-08-30 22:33 ` BALATON Zoltan
2022-08-31 10:06 ` BB
2022-08-30 19:00 ` [PATCH v2 07/10] hw/isa/vt82c686: Instantiate PM function " Bernhard Beschow
2022-08-30 22:39 ` BALATON Zoltan
2022-08-31 10:04 ` BB
2022-08-30 19:00 ` [PATCH v2 08/10] hw/isa/vt82c686: Instantiate AC97 and MC97 functions " Bernhard Beschow
2022-08-30 19:00 ` Bernhard Beschow [this message]
2022-08-30 19:00 ` [PATCH v2 10/10] hw/isa/vt82c686: Create rtc-time alias in boards instead Bernhard Beschow
2022-08-30 21:46 ` Philippe Mathieu-Daudé via
2022-09-09 12:43 ` Bernhard Beschow
2022-08-30 21:49 ` [PATCH v2 00/10] Instantiate VT82xx functions in host device Philippe Mathieu-Daudé via
2022-08-30 21:49 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830190048.67448-10-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).