qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Victor Toso <victortoso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	John Snow <jsnow@redhat.com>, Michael Roth <michael.roth@amd.com>
Subject: [PATCH v2 06/10] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event
Date: Thu,  1 Sep 2022 10:58:36 +0200	[thread overview]
Message-ID: <20220901085840.22520-7-victortoso@redhat.com> (raw)
In-Reply-To: <20220901085840.22520-1-victortoso@redhat.com>

Example output is missing a ',' delimiter and it has an extra ending
curly bracket. Fix it.

Problem was noticed when trying to load the example into python's json
library.

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
 qapi/qdev.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/qapi/qdev.json b/qapi/qdev.json
index 26cd10106b..2708fb4e99 100644
--- a/qapi/qdev.json
+++ b/qapi/qdev.json
@@ -150,10 +150,9 @@
 #
 # Example:
 #
-# <- { "event": "DEVICE_UNPLUG_GUEST_ERROR"
+# <- { "event": "DEVICE_UNPLUG_GUEST_ERROR",
 #      "data": { "device": "core1",
 #                "path": "/machine/peripheral/core1" },
-#      },
 #      "timestamp": { "seconds": 1615570772, "microseconds": 202844 } }
 #
 ##
-- 
2.37.2



  parent reply	other threads:[~2022-09-01  9:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01  8:58 [PATCH v2 00/10] qapi examples fixes, simplified version Victor Toso
2022-09-01  8:58 ` [PATCH v2 01/10] qapi: fix example of query-ballon command Victor Toso
2022-09-01  8:58 ` [PATCH v2 02/10] qapi: fix example of query-vnc command Victor Toso
2022-09-01  8:58 ` [PATCH v2 03/10] qapi: fix example of query-dump-guest-memory-capability command Victor Toso
2022-09-01  8:58 ` [PATCH v2 04/10] qapi: fix example of BLOCK_JOB_READY event Victor Toso
2022-09-01  8:58 ` [PATCH v2 05/10] qapi: fix example of NIC_RX_FILTER_CHANGED event Victor Toso
2022-09-01  8:58 ` Victor Toso [this message]
2022-09-01  8:58 ` [PATCH v2 07/10] qapi: fix example of MEM_UNPLUG_ERROR event Victor Toso
2022-09-01  8:58 ` [PATCH v2 08/10] qapi: fix examples of blockdev-add with qcow2 Victor Toso
2022-09-01  8:58 ` [PATCH v2 09/10] qapi: fix example of query-hotpluggable-cpus command Victor Toso
2022-09-01  8:58 ` [PATCH v2 10/10] qapi: fix examples of events missing timestamp Victor Toso
2022-09-01 12:20 ` [PATCH v2 00/10] qapi examples fixes, simplified version Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220901085840.22520-7-victortoso@redhat.com \
    --to=victortoso@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).