From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH 4/6] parallels: Use highest_offset() helper in leak check
Date: Fri, 2 Sep 2022 10:52:58 +0200 [thread overview]
Message-ID: <20220902085300.508078-5-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20220902085300.508078-1-alexander.ivanov@virtuozzo.com>
Deduplicate code by using highest_offset() helper.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 339ce45634..688aa081e2 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -535,16 +535,9 @@ static int parallels_check_leak(BlockDriverState *bs,
BdrvCheckMode fix)
{
BDRVParallelsState *s = bs->opaque;
- int64_t off, high_off, count, cut_out;
- uint32_t i;
+ int64_t high_off, count, cut_out;
- high_off = 0;
- for (i = 0; i < s->bat_size; i++) {
- off = bat2sect(s, i) << BDRV_SECTOR_BITS;
- if (off > high_off) {
- high_off = off;
- }
- }
+ high_off = highest_offset(s);
cut_out = parallels_handle_leak(bs, res, high_off, fix & BDRV_FIX_LEAKS);
if (cut_out < 0) {
--
2.34.1
next prev parent reply other threads:[~2022-09-02 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 8:52 [PATCH 0/6] parallels: Add duplication check, repair at open, fix bugs Alexander Ivanov
2022-09-02 8:52 ` [PATCH 1/6] parallels: Incorrect data end calculation in parallels_open() Alexander Ivanov
2022-09-07 15:23 ` Denis V. Lunev
2022-09-02 8:52 ` [PATCH 2/6] parallels: Create parallels_handle_leak() to truncate excess clusters Alexander Ivanov
2022-09-07 16:15 ` Denis V. Lunev
2022-09-02 8:52 ` [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT Alexander Ivanov
2022-09-07 16:14 ` Denis V. Lunev
2022-09-08 17:15 ` Denis V. Lunev
2022-09-08 17:45 ` Denis V. Lunev
2022-09-09 7:37 ` Alexander Ivanov
2022-09-02 8:52 ` Alexander Ivanov [this message]
2022-09-07 15:39 ` [PATCH 4/6] parallels: Use highest_offset() helper in leak check Denis V. Lunev
2022-09-02 8:52 ` [PATCH 5/6] parallels: Replace fprintf by qemu_log Alexander Ivanov
2022-09-07 15:41 ` Denis V. Lunev
2022-09-02 8:53 ` [PATCH 6/6] parallels: Image repairing in parallels_open() Alexander Ivanov
2022-09-07 15:53 ` Denis V. Lunev
2022-09-08 16:54 ` Denis V. Lunev
2022-09-07 16:23 ` [PATCH 0/6] parallels: Add duplication check, repair at open, fix bugs Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902085300.508078-5-alexander.ivanov@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).