qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, Victor Toso <victortoso@redhat.com>
Subject: [PULL 08/10] qapi: fix examples of blockdev-add with qcow2
Date: Wed,  7 Sep 2022 17:03:25 +0200	[thread overview]
Message-ID: <20220907150327.538464-9-armbru@redhat.com> (raw)
In-Reply-To: <20220907150327.538464-1-armbru@redhat.com>

From: Victor Toso <victortoso@redhat.com>

The examples use "qcow2" driver with the wrong member name for
BlockdevRef alternate type. This patch changes all wrong member names
from "file" to "data-file" which is the correct member name in
BlockdevOptionsQcow2 for the BlockdevRef field.

Problem was noticed when using the example as a test case for Go
bindings.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Message-Id: <20220901085840.22520-9-victortoso@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/block-core.json | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 882b266532..f21fa235f2 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1541,8 +1541,8 @@
 # -> { "execute": "blockdev-add",
 #      "arguments": { "driver": "qcow2",
 #                     "node-name": "node1534",
-#                     "file": { "driver": "file",
-#                               "filename": "hd1.qcow2" },
+#                     "data-file": { "driver": "file",
+#                                    "filename": "hd1.qcow2" },
 #                     "backing": null } }
 #
 # <- { "return": {} }
@@ -4378,7 +4378,7 @@
 #      "arguments": {
 #           "driver": "qcow2",
 #           "node-name": "test1",
-#           "file": {
+#           "data-file": {
 #               "driver": "file",
 #               "filename": "test.qcow2"
 #            }
@@ -4395,7 +4395,7 @@
 #           "cache": {
 #              "direct": true
 #            },
-#            "file": {
+#           "data-file": {
 #              "driver": "file",
 #              "filename": "/tmp/test.qcow2"
 #            },
@@ -4477,7 +4477,7 @@
 #      "arguments": {
 #           "driver": "qcow2",
 #           "node-name": "node0",
-#           "file": {
+#           "data-file": {
 #               "driver": "file",
 #               "filename": "test.qcow2"
 #           }
-- 
2.37.2



  parent reply	other threads:[~2022-09-07 15:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 15:03 [PULL 00/10] QAPI patches patches for 2022-09-07 Markus Armbruster
2022-09-07 15:03 ` [PULL 01/10] qapi: fix example of query-ballon command Markus Armbruster
2022-09-07 15:03 ` [PULL 02/10] qapi: fix example of query-vnc command Markus Armbruster
2022-09-07 15:03 ` [PULL 03/10] qapi: fix example of query-dump-guest-memory-capability command Markus Armbruster
2022-09-07 15:03 ` [PULL 04/10] qapi: fix example of BLOCK_JOB_READY event Markus Armbruster
2022-09-07 15:03 ` [PULL 05/10] qapi: fix example of NIC_RX_FILTER_CHANGED event Markus Armbruster
2022-09-07 15:03 ` [PULL 06/10] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event Markus Armbruster
2022-09-07 15:03 ` [PULL 07/10] qapi: fix example of MEM_UNPLUG_ERROR event Markus Armbruster
2022-09-07 15:03 ` Markus Armbruster [this message]
2022-09-07 15:03 ` [PULL 09/10] qapi: fix example of query-hotpluggable-cpus command Markus Armbruster
2022-09-07 15:03 ` [PULL 10/10] qapi: fix examples of events missing timestamp Markus Armbruster
2022-09-07 18:43 ` [PULL 00/10] QAPI patches patches for 2022-09-07 Stefan Hajnoczi
2022-09-08 10:58 ` Kevin Wolf
2022-09-08 11:33   ` Markus Armbruster
2022-09-08 11:39     ` Markus Armbruster
2022-09-19 11:39       ` Markus Armbruster
2022-09-30 15:29         ` Markus Armbruster
2022-09-30 17:20           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907150327.538464-9-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=victortoso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).