qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Maksim Davydov <davydov-max@yandex-team.ru>
To: qemu-devel@nongnu.org
Cc: davydov-max@yandex-team.ru, yc-core@yandex-team.ru,
	pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net,
	marcel.apfelbaum@gmail.com, f4bug@amsat.org,
	wangyanan55@huawei.com, armbru@redhat.com, alxndr@bu.edu,
	bsd@redhat.com, stefanha@redhat.com, thuth@redhat.com,
	darren.kenny@oracle.com, Qiuhao.Li@outlook.com,
	lvivier@redhat.com, jsnow@redhat.com, crosa@redhat.com,
	bleal@redhat.com
Subject: [PATCH 1/4] qom: add devault value
Date: Thu,  8 Sep 2022 13:36:47 +0300	[thread overview]
Message-ID: <20220908103650.9518-2-davydov-max@yandex-team.ru> (raw)
In-Reply-To: <20220908103650.9518-1-davydov-max@yandex-team.ru>

qmp_qom_list_properties can print default values if they are available
as qmp_device_list_properties does, because both of them use the
ObjectPropertyInfo structure with default_value field. This can be useful
when working with "not device" types.

Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
---
 qom/qom-qmp-cmds.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 2e63a4c184..1d7867dc19 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -217,6 +217,8 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename,
         info->type = g_strdup(prop->type);
         info->has_description = !!prop->description;
         info->description = g_strdup(prop->description);
+        info->default_value = qobject_ref(prop->defval);
+        info->has_default_value = !!info->default_value;
 
         QAPI_LIST_PREPEND(prop_list, info);
     }
-- 
2.25.1



  reply	other threads:[~2022-09-08 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08 10:36 [PATCH 0/4] compare machine type compat_props Maksim Davydov
2022-09-08 10:36 ` Maksim Davydov [this message]
2022-09-10 10:46   ` [PATCH 1/4] qom: add devault value Vladimir Sementsov-Ogievskiy
2022-09-08 10:36 ` [PATCH 2/4] qmp: add dump machine type compatible properties Maksim Davydov
2022-09-10 11:27   ` Vladimir Sementsov-Ogievskiy
2022-09-08 10:36 ` [PATCH 3/4] python/qmp: increase read buffer size Maksim Davydov
2022-09-10 11:29   ` Vladimir Sementsov-Ogievskiy
2022-09-08 10:36 ` [PATCH 4/4] scripts: add script to compare compatible properties Maksim Davydov
2022-09-10 12:05   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220908103650.9518-2-davydov-max@yandex-team.ru \
    --to=davydov-max@yandex-team.ru \
    --cc=Qiuhao.Li@outlook.com \
    --cc=alxndr@bu.edu \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=bsd@redhat.com \
    --cc=crosa@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=jsnow@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=yc-core@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).