From: liuhaiwei <liuhaiwei9699@126.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: stefanha@redhat.com, fam@euphon.net, eblake@redhat.com,
vsementsov@yandex-team.ru, jsnow@redhat.com, quintela@redhat.com,
dgilbert@redhat.com, liuhaiwei <liuhaiwei@inpsur.com>,
liuhaiwei <liuhaiwei9699@126.com>
Subject: [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block size 1T 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s)
Date: Thu, 8 Sep 2022 08:35:25 -0400 [thread overview]
Message-ID: <20220908123525.197397-1-liuhaiwei9699@126.com> (raw)
From: liuhaiwei <liuhaiwei@inpsur.com>
so we set the fake pending size when pending size > threshold size
Signed-off-by: liuhaiwei <liuhaiwei@inpsur.com>
Signed-off-by: liuhaiwei <liuhaiwei9699@126.com>
---
migration/block-dirty-bitmap.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index 9aba7d9c22..6086d8d1c3 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -782,7 +782,10 @@ static void dirty_bitmap_save_pending(QEMUFile *f, void *opaque,
}
qemu_mutex_unlock_iothread();
-
+ /*we set the fake pending size when the dirty bitmap size more than max_size(bandwith of speed) */
+ if(pending > max_size && max_size == 0){
+ pending = max_size - 1;
+ }
trace_dirty_bitmap_save_pending(pending, max_size);
*res_postcopy_only += pending;
--
2.27.0
next reply other threads:[~2022-09-08 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 12:35 liuhaiwei [this message]
2022-09-08 14:14 ` [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block size 1T 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s) Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908123525.197397-1-liuhaiwei9699@126.com \
--to=liuhaiwei9699@126.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=liuhaiwei@inpsur.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).