* [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block size 1T 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s)
@ 2022-09-08 12:35 liuhaiwei
2022-09-08 14:14 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: liuhaiwei @ 2022-09-08 12:35 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: stefanha, fam, eblake, vsementsov, jsnow, quintela, dgilbert,
liuhaiwei, liuhaiwei
From: liuhaiwei <liuhaiwei@inpsur.com>
so we set the fake pending size when pending size > threshold size
Signed-off-by: liuhaiwei <liuhaiwei@inpsur.com>
Signed-off-by: liuhaiwei <liuhaiwei9699@126.com>
---
migration/block-dirty-bitmap.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index 9aba7d9c22..6086d8d1c3 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -782,7 +782,10 @@ static void dirty_bitmap_save_pending(QEMUFile *f, void *opaque,
}
qemu_mutex_unlock_iothread();
-
+ /*we set the fake pending size when the dirty bitmap size more than max_size(bandwith of speed) */
+ if(pending > max_size && max_size == 0){
+ pending = max_size - 1;
+ }
trace_dirty_bitmap_save_pending(pending, max_size);
*res_postcopy_only += pending;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block size 1T 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s)
2022-09-08 12:35 [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block size 1T 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s) liuhaiwei
@ 2022-09-08 14:14 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2022-09-08 14:14 UTC (permalink / raw)
To: liuhaiwei
Cc: qemu-devel, qemu-block, stefanha, fam, eblake, vsementsov, jsnow,
quintela, dgilbert, liuhaiwei
Your subject line is waaaaay too long.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-08 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08 12:35 [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block size 1T 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s) liuhaiwei
2022-09-08 14:14 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).