From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B59A4ECAAD3 for ; Wed, 14 Sep 2022 13:13:39 +0000 (UTC) Received: from localhost ([::1]:55726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYSCv-0003jZ-2r for qemu-devel@archiver.kernel.org; Wed, 14 Sep 2022 09:13:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYQwg-0000kT-V0 for qemu-devel@nongnu.org; Wed, 14 Sep 2022 07:52:53 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:43874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYQwY-00008o-It for qemu-devel@nongnu.org; Wed, 14 Sep 2022 07:52:46 -0400 Received: by mail-wm1-x333.google.com with SMTP id z14-20020a05600c0a0e00b003b486df42a3so6241740wmp.2 for ; Wed, 14 Sep 2022 04:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=x7RzGIn8LNVYPu9Oy+agYCMaoOcO7iYBjnlAKBL8SJM=; b=w5sefo6fHLzQtgKluFmt+SQb1+xxZbyPZoA+pFzegUmP7msP746lwgIHKSTDqJUs/m o1qbc/MBz2u4DsfvTTM1JFLRAolcZGcSpGQIah74m8Csc5aXnwYDHP1O24u5Kbbzrd+d y0YdHmLPplrkQGUPPAuSdg0tUg0hx1uWcmrNBYx+X8DIxmcrKHDa+sOOOYURGgKzOcGV GrepFSKgbnDV+cjJBGL8JssGnnNL31qPmDEbUkPlQf8u2sFoUQY8KgcdplcfAWMUyyWz X8hDr0fen/yQN+gCV92jmB5jap7YLROye6NQyGMzj2rDVmXNEgCn9YkkYN9b5OUqAP7r XotA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=x7RzGIn8LNVYPu9Oy+agYCMaoOcO7iYBjnlAKBL8SJM=; b=X+oVXNHBjZblnEjBtRbvp/dFmtmc8eke+wqbCKFTn8SAjXHVcTeJeTxwE0N6US8Vae HVWmE8uyE0HVAU79q1cc2EZ9Wmjyzio5tWtLaSjQRS2Ucl+/0SKn+JYGn8R5p2vbJrrS /0Ihosqd1+qONLeGGja1gtmxVjTUfQraej/xl1YXA+vW/nDCeVL2KZYJEepZMYGgmxZm 3VWKS4TXOK0GsLEL+PeF6I21Tb5blSF5yYFIrl4G00kMS2skyJRwAMk4mvg15oHvlDl4 XHNPCvYGRnapOgk2gTRx66WFYfAEYAR+o/cGcbFE9dMo3sg2sntKh7bHj+5hgxsavRt9 56MQ== X-Gm-Message-State: ACgBeo082mBzJHV6l/PbFtK5UrcmVhE/5hvKRjCKovWY79TtmP3JVM8Y I6Yx0CPQrkbwOxUfx84xH4+I8nEGccFZbidA X-Google-Smtp-Source: AA6agR7lHrQkreZ4BLFD0RLyHviXf/tSTNbtdZaasiLD3l/Xx7sueYh0SLVoQ/aV3C89URL+maEvkw== X-Received: by 2002:a1c:c91a:0:b0:3a6:38bf:2c36 with SMTP id f26-20020a1cc91a000000b003a638bf2c36mr2858923wmb.38.1663156357174; Wed, 14 Sep 2022 04:52:37 -0700 (PDT) Received: from stoup.. ([89.101.193.70]) by smtp.gmail.com with ESMTPSA id t9-20020a5d6909000000b0022a3a887ceasm13712970wru.49.2022.09.14.04.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 04:52:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 19/20] target/arm: Remove useless TARGET_BIG_ENDIAN check in armv7m_load_kernel() Date: Wed, 14 Sep 2022 12:52:16 +0100 Message-Id: <20220914115217.117532-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220914115217.117532-1-richard.henderson@linaro.org> References: <20220914115217.117532-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Arm system emulation targets always have TARGET_BIG_ENDIAN clear, so there is no need to have handling in armv7m_load_kernel() for the case when it is defined. Remove the unnecessary code. Side notes: * our M-profile implementation is always little-endian (that is, it makes the IMPDEF choice that the read-only AIRCR.ENDIANNESS is 0) * if we did want to handle big-endian ELF files here we should do it the way that hw/arm/boot.c:arm_load_elf() does, by looking at the ELF header to see what endianness the file itself is Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220823160417.3858216-2-peter.maydell@linaro.org> Signed-off-by: Richard Henderson --- hw/arm/armv7m.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 990861ee5e..fa4c2c735d 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -572,17 +572,10 @@ void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size) { ssize_t image_size; uint64_t entry; - int big_endian; AddressSpace *as; int asidx; CPUState *cs = CPU(cpu); -#if TARGET_BIG_ENDIAN - big_endian = 1; -#else - big_endian = 0; -#endif - if (arm_feature(&cpu->env, ARM_FEATURE_EL3)) { asidx = ARMASIdx_S; } else { @@ -593,7 +586,7 @@ void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size) if (kernel_filename) { image_size = load_elf_as(kernel_filename, NULL, NULL, NULL, &entry, NULL, NULL, - NULL, big_endian, EM_ARM, 1, 0, as); + NULL, 0, EM_ARM, 1, 0, as); if (image_size < 0) { image_size = load_image_targphys_as(kernel_filename, 0, mem_size, as); -- 2.34.1