qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [RFC PATCH 0/4] use MemTxAttrs to signal cpu index
Date: Wed, 14 Sep 2022 17:09:51 +0100	[thread overview]
Message-ID: <20220914160955.812151-1-alex.bennee@linaro.org> (raw)

Hi,

This ostensibly fixes a bug with gdbstub when accessing the GIC state
(via system registers). It also proposes a pattern for removing
current_cpu/qtest_enabled() hacks in hw/ by passing the cpu index via
MemTxAttrs. For the ARM timer code we also assert that those accesses
do come from a CPU (as opposed to HW DMA attempting to overwrite
stuff).

We do need to audit helpers in target/ which use the address_space API
to read and write data and ensure they properly form their MxTxAttrs
so this works cleanly.

What do people think?

Alex Bennée (4):
  hw: encode accessing CPU index in MemTxAttrs
  qtest: make read/write operation appear to be from CPU
  hw/intc/gic: use MxTxAttrs to divine accessing CPU
  hw/timer: convert mptimer access to attrs to derive cpu index

 include/exec/memattrs.h |  4 +++-
 accel/tcg/cputlb.c      | 22 ++++++++++++++++------
 hw/core/cpu-sysemu.c    | 17 +++++++++++++----
 hw/intc/arm_gic.c       | 39 ++++++++++++++++++++++-----------------
 hw/timer/arm_mptimer.c  | 25 ++++++++++++++-----------
 softmmu/qtest.c         | 31 +++++++++++++++++++------------
 6 files changed, 87 insertions(+), 51 deletions(-)

-- 
2.34.1



             reply	other threads:[~2022-09-14 17:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 16:09 Alex Bennée [this message]
2022-09-14 16:09 ` [RFC PATCH 1/4] hw: encode accessing CPU index in MemTxAttrs Alex Bennée
2022-09-15  8:05   ` Richard Henderson
2022-09-16 15:19   ` Peter Maydell
2022-09-14 16:09 ` [RFC PATCH 2/4] qtest: make read/write operation appear to be from CPU Alex Bennée
2022-09-15  8:08   ` Richard Henderson
2022-09-16 14:40     ` Philippe Mathieu-Daudé via
2022-09-14 16:09 ` [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU Alex Bennée
2022-09-15  8:16   ` Richard Henderson
2022-09-16 14:49     ` Philippe Mathieu-Daudé via
2022-09-16 15:28       ` Alex Bennée
2022-09-17  8:33         ` Richard Henderson
2022-09-14 16:09 ` [RFC PATCH 4/4] hw/timer: convert mptimer access to attrs to derive cpu index Alex Bennée
2022-09-15  8:17   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220914160955.812151-1-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).