From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: berrange@redhat.com, imammedo@redhat.com, jsnow@redhat.com,
pbonzini@redhat.com, peter.maydell@linaro.org,
qemu-devel@nongnu.org, thuth@redhat.com
Subject: Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits
Date: Sat, 17 Sep 2022 16:28:16 -0400 [thread overview]
Message-ID: <20220917162606-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAARzgwwpy6yUJfuxxfM2vAUDqh+RyxjLqd+1xARiazqwTLbN9A@mail.gmail.com>
On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote:
> On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha <ani@anisinha.ca> wrote:
> >
> >
> >
> > On Mon, 25 Jul 2022, Ani Sinha wrote:
> >
> > >
> > >
> > > On Sat, 16 Jul 2022, Michael S. Tsirkin wrote:
> > >
> > > > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote:
> > > > >
> > > > >
> > > > > On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin <mst@redhat.com> wrote:
> > > > >
> > > > > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote:
> > > > > > > Instead of all this mess, can't we just spawn e.g. "git clone --depth
> > > > > 1"?
> > > > > > > And if the directory exists I would fetch and checkout.
> > > > > >
> > > > > > There are two reasons I can think of why I do not like this idea:
> > > > > >
> > > > > > (a) a git clone of a whole directory would download all versions of the
> > > > > > binary whereas we want only a specific version.
> > > > >
> > > > > You mention shallow clone yourself, and I used --depth 1 above.
> > > > >
> > > > > > Downloading a single file
> > > > > > by shallow cloning or creating a git archive is overkill IMHO when a wget
> > > > > > style retrieval works just fine.
> > > > >
> > > > > However, it does not provide for versioning, tagging etc so you have
> > > > > to implement your own schema.
> > > > >
> > > > >
> > > > > Hmm I’m not sure if we need all that. Bits has its own versioning mechanism and
> > > > > I think all we need to do is maintain the same versioning logic and maintain
> > > > > binaries of different versions. Do we really need the power of git/version
> > > > > control here? Dunno.
> > > >
> > > > Well we need some schema. Given we are not using official bits releases
> > > > I don't think we can reuse theirs.
> > >
> > > OK fine. Lets figuire out how to push bits somewhere in git.qemu.org and
> > > the binaries in some other repo first. Everything else hinges on that. We
> > > can fix the rest of the bits later incrementally.
> >
> > DanPB, any thoughts on putting bits on git.qemu.org or where and how to
> > keep the binaries?
>
> Can we please conclude on this?
> Peter, can you please fork the repo? I have tried many times to reach
> you on IRC but failed.
Probably because of travel around KVM forum.
I think given our CI is under pressure again due to gitlab free tier
limits, tying binaries to CI isn't a great idea at this stage.
Can Ani just upload binaies to qemu.org for now?
--
MST
next prev parent reply other threads:[~2022-09-17 20:29 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 17:00 [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits Ani Sinha
2022-07-10 17:00 ` [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits Ani Sinha
2022-07-11 20:38 ` John Snow
2022-07-12 7:17 ` Ani Sinha
2022-07-12 15:23 ` John Snow
2022-07-12 15:38 ` Ani Sinha
2022-07-12 15:42 ` John Snow
2022-07-12 15:46 ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 02/11] acpi/tests/bits: add SPDX license identifiers for bios bits tests Ani Sinha
2022-07-14 13:56 ` Daniel P. Berrangé
2022-07-14 14:12 ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 03/11] acpi/tests/bits: disable acpi PSS tests that are failing in biosbits Ani Sinha
2022-07-10 17:00 ` [PATCH v2 04/11] acpi/tests/bits: add smilatency test suite from bits in order to disable it Ani Sinha
2022-07-10 17:00 ` [PATCH v2 05/11] acpi/tests/bits: add SPDX license identifiers for bios bits smilatency tests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 06/11] acpi/tests/bits: disable smilatency test since it does not pass everytime Ani Sinha
2022-07-10 17:00 ` [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits Ani Sinha
2022-07-11 20:42 ` John Snow
2022-07-12 7:15 ` Ani Sinha
2022-09-06 13:05 ` Daniel P. Berrangé
2022-07-14 14:05 ` Daniel P. Berrangé
2022-07-14 14:19 ` Ani Sinha
2022-07-14 17:49 ` Ani Sinha
2022-07-14 20:43 ` Michael S. Tsirkin
2022-07-14 20:41 ` Michael S. Tsirkin
2022-07-15 4:17 ` Ani Sinha
2022-07-15 6:50 ` Michael S. Tsirkin
2022-07-16 6:36 ` Ani Sinha
2022-07-16 15:30 ` Michael S. Tsirkin
2022-07-25 18:02 ` Ani Sinha
2022-07-27 18:38 ` Ani Sinha
2022-09-16 16:00 ` Ani Sinha
2022-09-17 20:28 ` Michael S. Tsirkin [this message]
2022-09-27 8:13 ` Ani Sinha
2022-09-27 8:33 ` Daniel P. Berrangé
2022-09-27 10:07 ` Ani Sinha
2022-09-27 10:18 ` Daniel P. Berrangé
2022-09-27 10:24 ` Ani Sinha
2022-09-27 11:42 ` Ani Sinha
2022-09-27 14:05 ` Ani Sinha
2022-09-27 15:45 ` Daniel P. Berrangé
2022-09-27 21:21 ` Michael S. Tsirkin
2022-09-28 8:31 ` Thomas Huth
2022-09-28 8:35 ` Daniel P. Berrangé
2022-09-28 9:47 ` Michael S. Tsirkin
2022-09-28 9:35 ` Michael S. Tsirkin
2022-09-28 9:39 ` Thomas Huth
2022-09-28 9:56 ` Michael S. Tsirkin
2022-10-06 7:58 ` Ani Sinha
2022-10-06 8:11 ` Ani Sinha
2022-10-06 10:18 ` Ani Sinha
2022-09-27 21:19 ` Michael S. Tsirkin
2022-09-27 21:18 ` Michael S. Tsirkin
2022-09-28 3:08 ` Ani Sinha
2022-09-28 3:58 ` Michael S. Tsirkin
2022-09-28 6:06 ` Ani Sinha
2022-10-06 12:12 ` Michael S. Tsirkin
2022-09-28 6:58 ` Daniel P. Berrangé
2022-09-28 7:15 ` Ani Sinha
2022-09-28 7:26 ` Daniel P. Berrangé
2022-09-28 9:19 ` Michael S. Tsirkin
2022-09-27 21:44 ` Paolo Bonzini
2022-09-27 22:09 ` Michael S. Tsirkin
2022-09-27 23:10 ` Paolo Bonzini
2022-09-28 5:53 ` Michael S. Tsirkin
2022-09-28 7:06 ` Daniel P. Berrangé
2022-09-28 7:43 ` Thomas Huth
2022-10-09 5:21 ` Ani Sinha
2022-10-09 6:30 ` Ani Sinha
2022-10-09 16:06 ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 08/11] acpi/tests/bits: add biosbits config file for running bios tests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 09/11] acpi/tests/bits: add a README file describing bits pytests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 10/11] pytest: add pytest to the meson build system Ani Sinha
2022-07-11 20:46 ` John Snow
2022-07-12 6:52 ` Ani Sinha
2022-09-06 13:10 ` Daniel P. Berrangé
2022-09-27 21:26 ` Michael S. Tsirkin
2022-09-28 7:32 ` Thomas Huth
2022-09-28 9:23 ` Michael S. Tsirkin
2022-07-10 17:00 ` [PATCH v2 11/11] MAINTAINERS: add myself as the maintainer for acpi biosbits pytests Ani Sinha
2022-07-11 9:33 ` [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits Michael S. Tsirkin
2022-07-14 13:24 ` Peter Maydell
2022-09-06 6:26 ` Ani Sinha
2022-09-06 8:19 ` Michael S. Tsirkin
2022-09-06 13:15 ` Daniel P. Berrangé
2022-09-06 13:28 ` Ani Sinha
2022-09-06 13:30 ` Daniel P. Berrangé
2022-09-09 12:53 ` Ani Sinha
2022-09-06 14:03 ` Michael S. Tsirkin
2022-09-06 14:10 ` Daniel P. Berrangé
2022-09-06 14:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220917162606-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).