qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	Patrick Venture <venture@google.com>,
	Hao Wu <wuhaotsh@google.com>
Subject: [PULL 04/15] tests/qtest: npcm7xx-emc-test: Skip checking MAC
Date: Tue, 20 Sep 2022 17:35:01 +0200	[thread overview]
Message-ID: <20220920153512.187283-5-thuth@redhat.com> (raw)
In-Reply-To: <20220920153512.187283-1-thuth@redhat.com>

From: Patrick Venture <venture@google.com>

The register tests walks all the registers to verify they are initially
0 when appropriate.  However, if the MAC address is set in the register
space, this should not be checked against 0.

Reviewed-by: Hao Wu <wuhaotsh@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
Message-Id: <20220906163138.2831353-1-venture@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/npcm7xx_emc-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/npcm7xx_emc-test.c b/tests/qtest/npcm7xx_emc-test.c
index c373d24e1e..b046f1d76a 100644
--- a/tests/qtest/npcm7xx_emc-test.c
+++ b/tests/qtest/npcm7xx_emc-test.c
@@ -381,7 +381,8 @@ static void test_init(gconstpointer test_data)
 
 #undef CHECK_REG
 
-    for (i = 0; i < NUM_CAMML_REGS; ++i) {
+    /* Skip over the MAC address registers, which is BASE+0 */
+    for (i = 1; i < NUM_CAMML_REGS; ++i) {
         g_assert_cmpuint(emc_read(qts, mod, REG_CAMM_BASE + i * 2), ==,
                          0);
         g_assert_cmpuint(emc_read(qts, mod, REG_CAML_BASE + i * 2), ==,
-- 
2.31.1



  parent reply	other threads:[~2022-09-20 20:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 15:34 [PULL 00/15] Testing, qga and misc patches Thomas Huth
2022-09-20 15:34 ` [PULL 01/15] tests: mark io-command test as skipped if socat is missing Thomas Huth
2022-09-20 15:34 ` [PULL 02/15] tests/vm: update NetBSD to 9.3 Thomas Huth
2022-09-20 15:35 ` [PULL 03/15] .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build Thomas Huth
2022-09-20 15:35 ` Thomas Huth [this message]
2022-09-20 15:35 ` [PULL 05/15] qtest/fuzz-lsi53c895a-test: set guest RAM to 2G Thomas Huth
2022-09-20 15:35 ` [PULL 06/15] tests: Fix error strings Thomas Huth
2022-09-20 15:35 ` [PULL 07/15] meson-build: Enable CONFIG_REPLICATION only when replication is set Thomas Huth
2022-09-20 15:35 ` [PULL 08/15] bios-tables-test: Make oem-fields tests be consistent Thomas Huth
2022-09-20 15:35 ` [PULL 09/15] bios-tables-test: Sort all x86_64 tests by machine type Thomas Huth
2022-09-20 15:35 ` [PULL 10/15] bios-tables-test: Only run test for machine types compiled in Thomas Huth
2022-09-20 15:35 ` [PULL 11/15] tests: Only run intel-hda-tests if machine type is " Thomas Huth
2022-09-20 15:35 ` [PULL 12/15] tests: sb16 has both pc and q35 tests Thomas Huth
2022-09-20 15:35 ` [PULL 13/15] gitlab-ci: Update the FreeBSD 13 job from 13.0 to 13.1 Thomas Huth
2022-09-20 15:35 ` [PULL 14/15] qga: Replace 'blacklist' command line and config file options by 'block-rpcs' Thomas Huth
2022-09-20 15:35 ` [PULL 15/15] qga: Replace 'blacklist' and 'whitelist' in the guest agent sources Thomas Huth
2022-09-21 17:33 ` [PULL 00/15] Testing, qga and misc patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920153512.187283-5-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=venture@google.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).