From: Helge Deller <deller@gmx.de>
To: qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: deller@gmx.de
Subject: [PULL 07/12] linux-user: Fix strace of chmod() if mode == 0
Date: Tue, 20 Sep 2022 19:31:47 +0200 [thread overview]
Message-ID: <20220920173152.199359-8-deller@gmx.de> (raw)
In-Reply-To: <20220920173152.199359-1-deller@gmx.de>
If the mode parameter of chmod() is zero, this value isn't shown
when stracing a program:
chmod("filename",)
This patch fixes it up to show the zero-value as well:
chmod("filename",000)
Signed-off-by: Helge Deller <deller@gmx.de>
---
linux-user/strace.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 5ac64df02b..2f539845bb 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1505,6 +1505,11 @@ print_file_mode(abi_long mode, int last)
const char *sep = "";
const struct flags *m;
+ if (mode == 0) {
+ qemu_log("000%s", get_comma(last));
+ return;
+ }
+
for (m = &mode_flags[0]; m->f_string != NULL; m++) {
if ((m->f_value & mode) == m->f_value) {
qemu_log("%s%s", m->f_string, sep);
--
2.37.3
next prev parent reply other threads:[~2022-09-20 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 17:31 [PULL 00/12] Publish1 patches Helge Deller
2022-09-20 17:31 ` [PULL 01/12] linux-user: Add missing signals in strace output Helge Deller
2022-09-20 17:31 ` [PULL 02/12] linux-user: Add missing clock_gettime64() syscall strace Helge Deller
2022-09-20 17:31 ` [PULL 03/12] linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls Helge Deller
2022-09-20 17:31 ` [PULL 04/12] linux-user: Log failing executable in EXCP_DUMP() Helge Deller
2022-09-20 17:31 ` [PULL 05/12] linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info Helge Deller
2022-09-20 17:31 ` [PULL 06/12] linux-user/hppa: Dump IIR on register dump Helge Deller
2022-09-20 17:31 ` Helge Deller [this message]
2022-09-20 17:31 ` [PULL 08/12] linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch Helge Deller
2022-09-20 17:31 ` [PULL 09/12] linux-user: Add strace for clock_nanosleep() Helge Deller
2022-09-20 17:31 ` [PULL 10/12] linux-user: Show timespec on strace for futex() Helge Deller
2022-09-20 17:31 ` [PULL 11/12] linux-user: Add close_range() syscall Helge Deller
2022-09-20 17:31 ` [PULL 12/12] linux-user: Add parameters of getrandom() syscall for strace Helge Deller
2022-09-21 17:59 ` [PULL 00/12] Publish1 patches Philippe Mathieu-Daudé via
2022-09-22 9:37 ` Peter Maydell
2022-09-22 13:00 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2022-09-13 19:13 [PULL 00/12] linux-user patches Helge Deller
2022-09-13 19:13 ` [PULL 07/12] linux-user: Fix strace of chmod() if mode == 0 Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920173152.199359-8-deller@gmx.de \
--to=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).