From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
peterx@redhat.com, Juan Quintela <quintela@redhat.com>
Subject: [PATCH 0/5] migration: Bug fixes (prepare for preempt-full)
Date: Tue, 20 Sep 2022 18:37:55 -0400 [thread overview]
Message-ID: <20220920223800.47467-1-peterx@redhat.com> (raw)
This patchset does bug fixes that I found when testing preempt-full.
Patch 1 should fix a possible deadloop when I hit when testing the
preempt-full code. I didn't verify it because it's so hard to trigger, but
the logic should be explained in the patch.
Patch 2 fixes a race condition I can easily trigger with the latest
preempt-full code when running with recovery+tls test. The bug hides quite
deep and took time to debug. Fundamentally it's about qemufile API, I hope
someday we can have something better than that but still so far there's no
strong enough reason to rework the whole thing.
Patch 3-4 are two patches to disable either postcopy or preempt mode only
for xbzrle/compression.
Patch 5 is something nice to have to optimize the bitmap ops.
The last two patches are actually part of my preempt-full RFC series.
I picked these patches out explicitly from preempt-full series, because at
least patches 1-4 fix real bugs in current code base, so they should get
more focus.
Thanks,
Peter Xu (5):
migration: Fix possible deadloop of ram save process
migration: Fix race on qemu_file_shutdown()
migration: Disallow xbzrle with postcopy
migration: Disallow postcopy preempt to be used with compress
migration: Use non-atomic ops for clear log bitmap
include/exec/ram_addr.h | 11 +++++-----
include/exec/ramblock.h | 3 +++
include/qemu/bitmap.h | 1 +
migration/migration.c | 16 +++++++++++++++
migration/qemu-file.c | 27 ++++++++++++++++++++++---
migration/ram.c | 16 +++++++++++----
util/bitmap.c | 45 +++++++++++++++++++++++++++++++++++++++++
7 files changed, 107 insertions(+), 12 deletions(-)
--
2.32.0
next reply other threads:[~2022-09-20 23:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 22:37 Peter Xu [this message]
2022-09-20 22:37 ` [PATCH 1/5] migration: Fix possible deadloop of ram save process Peter Xu
2022-09-22 14:49 ` Dr. David Alan Gilbert
2022-09-22 15:25 ` Peter Xu
2022-09-22 16:41 ` Dr. David Alan Gilbert
2022-10-04 14:25 ` Peter Xu
2022-10-04 15:02 ` Dr. David Alan Gilbert
2022-09-20 22:37 ` [PATCH 2/5] migration: Fix race on qemu_file_shutdown() Peter Xu
2022-09-22 15:43 ` Dr. David Alan Gilbert
2022-09-22 16:58 ` Daniel P. Berrangé
2022-09-22 19:37 ` Peter Xu
2022-09-23 7:14 ` Daniel P. Berrangé
2022-09-23 18:27 ` Peter Xu
2022-09-20 22:37 ` [PATCH 3/5] migration: Disallow xbzrle with postcopy Peter Xu
2022-09-22 15:56 ` Dr. David Alan Gilbert
2022-09-22 19:28 ` Peter Xu
2022-09-20 22:37 ` [PATCH 4/5] migration: Disallow postcopy preempt to be used with compress Peter Xu
2022-09-22 16:29 ` Dr. David Alan Gilbert
2022-09-20 22:38 ` [PATCH 5/5] migration: Use non-atomic ops for clear log bitmap Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920223800.47467-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).