From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, afaria@redhat.com
Subject: [PATCH v3 00/26] block: fix coroutine_fn annotations
Date: Thu, 22 Sep 2022 10:48:58 +0200 [thread overview]
Message-ID: <20220922084924.201610-1-pbonzini@redhat.com> (raw)
As discussed at KVM Forum 2022, I am reposting this series to
add more coroutine_fn annotations. Fixing the annotations
enables static analysis of which functions are coroutine-only
and which are mixed (coroutine/non-coroutine).
A lot of the patches are similar to the ones that Marc-André Lureau
wrote back in 2017 (posted at [1]) but due to the changes in the code
it was easier to redo them.
This is a simple rebase of v2 (posted at [2]) with the following changes:
- patch 1 is new
- create_file_fallback_zero_first_sector is now marked as coroutine_fn
- blk_pwrite_zeroes is not a coroutine_fn anymore
- blk_pwrite is not a coroutine_fn anymore
- tracked_request_end is already a coroutine_fn in master
- some changes in commit messages
Paolo
[1] https://patchew.org/QEMU/20170704220346.29244-1-marcandre.lureau@redhat.com/).
[2] https://patchew.org/QEMU/20220509103019.215041-1-pbonzini@redhat.com/
Marc-André Lureau (3):
9p: add missing coroutine_fn annotations
migration: add missing coroutine_fn annotations
test-coroutine: add missing coroutine_fn annotations
Paolo Bonzini (23):
block/nvme: separate nvme_get_free_req cases for
coroutine/non-coroutine context
block: add missing coroutine_fn annotations
qcow2: remove incorrect coroutine_fn annotations
nbd: remove incorrect coroutine_fn annotations
coroutine: remove incorrect coroutine_fn annotations
blkdebug: add missing coroutine_fn annotations
blkverify: add missing coroutine_fn annotations
file-posix: add missing coroutine_fn annotations
iscsi: add missing coroutine_fn annotations
nbd: add missing coroutine_fn annotations
nfs: add missing coroutine_fn annotations
nvme: add missing coroutine_fn annotations
parallels: add missing coroutine_fn annotations
qcow2: add missing coroutine_fn annotations
copy-before-write: add missing coroutine_fn annotations
curl: add missing coroutine_fn annotations
qed: add missing coroutine_fn annotations
quorum: add missing coroutine_fn annotations
throttle: add missing coroutine_fn annotations
vmdk: add missing coroutine_fn annotations
job: add missing coroutine_fn annotations
coroutine-lock: add missing coroutine_fn annotations
raw-format: add missing coroutine_fn annotations
block.c | 6 ++---
block/blkdebug.c | 14 +++++-----
block/blkverify.c | 2 +-
block/block-backend.c | 10 +++----
block/copy-before-write.c | 8 +++---
block/curl.c | 2 +-
block/file-posix.c | 2 +-
block/io.c | 22 +++++++--------
block/iscsi.c | 2 +-
block/nbd.c | 10 +++----
block/nfs.c | 2 +-
block/nvme.c | 53 ++++++++++++++++++++++---------------
block/parallels.c | 5 ++--
block/qcow2-cluster.c | 18 ++++++-------
block/qcow2-refcount.c | 6 ++---
block/qcow2.c | 4 +--
block/qcow2.h | 18 ++++++-------
block/qed.c | 4 +--
block/quorum.c | 35 ++++++++++++------------
block/raw-format.c | 2 +-
block/throttle.c | 2 +-
block/vmdk.c | 20 +++++++-------
hw/9pfs/9p.h | 9 ++++---
include/block/nbd.h | 2 +-
include/qemu/coroutine.h | 2 +-
include/qemu/job.h | 2 +-
job.c | 2 +-
migration/migration.c | 3 ++-
tests/unit/test-coroutine.c | 2 +-
util/qemu-coroutine-lock.c | 14 +++++-----
util/qemu-coroutine.c | 2 +-
31 files changed, 150 insertions(+), 135 deletions(-)
--
2.37.3
next reply other threads:[~2022-09-22 8:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 8:48 Paolo Bonzini [this message]
2022-09-22 8:48 ` [PATCH 01/26] block/nvme: separate nvme_get_free_req cases for coroutine/non-coroutine context Paolo Bonzini
2022-09-22 8:49 ` [PATCH 02/26] block: add missing coroutine_fn annotations Paolo Bonzini
2022-09-22 15:11 ` Alberto Campinho Faria
2022-09-24 13:41 ` Paolo Bonzini
2022-10-05 18:11 ` Alberto Campinho Faria
2022-09-22 8:49 ` [PATCH 03/26] qcow2: remove incorrect " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 04/26] nbd: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 05/26] coroutine: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 06/26] blkdebug: add missing " Paolo Bonzini
2022-10-05 10:32 ` Kevin Wolf
2022-10-05 21:11 ` Paolo Bonzini
2022-10-06 8:45 ` Kevin Wolf
2022-09-22 8:49 ` [PATCH 07/26] blkverify: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 08/26] file-posix: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 09/26] iscsi: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 10/26] nbd: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 11/26] nfs: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 12/26] nvme: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 13/26] parallels: " Paolo Bonzini
2022-10-05 10:44 ` Kevin Wolf
2022-09-22 8:49 ` [PATCH 14/26] qcow2: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 15/26] copy-before-write: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 16/26] curl: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 17/26] qed: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 18/26] quorum: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 19/26] throttle: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 20/26] vmdk: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 21/26] job: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 22/26] coroutine-lock: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 23/26] raw-format: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 24/26] 9p: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 25/26] migration: " Paolo Bonzini
2022-09-22 8:49 ` [PATCH 26/26] test-coroutine: " Paolo Bonzini
2022-10-06 12:17 ` [PATCH v3 00/26] block: fix " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922084924.201610-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaria@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).