From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Yicong Yang <yangyicong@huawei.com>
Cc: <mst@redhat.com>, <imammedo@redhat.com>, <ani@anisinha.ca>,
<eduardo@habkost.net>, <marcel.apfelbaum@gmail.com>,
<f4bug@amsat.org>, <wangyanan55@huawei.com>,
<qemu-devel@nongnu.org>, <linuxarm@huawei.com>,
<yangyicong@hisilicon.com>, <prime.zeng@huawei.com>,
<hesham.almatary@huawei.com>, <ionela.voinescu@arm.com>,
<darren@os.amperecomputing.com>
Subject: Re: [PATCH 0/4] Only generate cluster node in PPTT when specified
Date: Thu, 22 Sep 2022 15:31:28 +0100 [thread overview]
Message-ID: <20220922153128.000035a4@huawei.com> (raw)
In-Reply-To: <20220922131143.58003-1-yangyicong@huawei.com>
On Thu, 22 Sep 2022 21:11:39 +0800
Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> This series mainly change the policy for building a cluster topology node
> in PPTT. Previously we'll always build a cluster node in PPTT without
> asking the user, after this set the cluster node will be built only the
> the user specify through "-smp clusters=X".
>
> Update the tests and test tables accordingly.
Hi Yicong,
Does this bring an issue with backwards compatibility?
I'm assuming we need to make this something controlled in
virt_machine_7_1_options()?
One of those things we probably should have noticed originally but now
we are stuck with the slightly messy backwards compatibility problem.
Also, looks like you picked up a bunch of tables that are unrelated
to the change.
Jonathan
>
> Yicong Yang (4):
> hw/acpi/aml-build: Only generate cluster node in PPTT when specified
> tests: virt: update expected ACPI tables for virt test
> tests: acpi: aarch64: add topology test for aarch64
> tests: acpi: aarch64: add *.topology tables
>
> hw/acpi/aml-build.c | 2 +-
> hw/core/machine-smp.c | 3 +++
> include/hw/boards.h | 2 ++
> tests/data/acpi/virt/APIC.pxb | Bin 0 -> 168 bytes
> tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes
> tests/data/acpi/virt/DBG2.memhp | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DBG2.numamem | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DBG2.pxb | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DBG2.topology | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes
> tests/data/acpi/virt/FACP.pxb | Bin 0 -> 268 bytes
> tests/data/acpi/virt/FACP.topology | Bin 0 -> 268 bytes
> tests/data/acpi/virt/GTDT.pxb | Bin 0 -> 96 bytes
> tests/data/acpi/virt/GTDT.topology | Bin 0 -> 96 bytes
> tests/data/acpi/virt/IORT.topology | Bin 0 -> 128 bytes
> tests/data/acpi/virt/MCFG.pxb | Bin 0 -> 60 bytes
> tests/data/acpi/virt/MCFG.topology | Bin 0 -> 60 bytes
> tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes
> tests/data/acpi/virt/PPTT.memhp | Bin 0 -> 76 bytes
> tests/data/acpi/virt/PPTT.numamem | Bin 0 -> 76 bytes
> tests/data/acpi/virt/PPTT.pxb | Bin 0 -> 76 bytes
> tests/data/acpi/virt/PPTT.topology | Bin 0 -> 336 bytes
> tests/data/acpi/virt/SPCR.pxb | Bin 0 -> 80 bytes
> tests/data/acpi/virt/SPCR.topology | Bin 0 -> 80 bytes
> tests/qtest/bios-tables-test.c | 22 ++++++++++++++++++++++
> 25 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 tests/data/acpi/virt/APIC.pxb
> create mode 100644 tests/data/acpi/virt/APIC.topology
> create mode 100644 tests/data/acpi/virt/DBG2.memhp
> create mode 100644 tests/data/acpi/virt/DBG2.numamem
> create mode 100644 tests/data/acpi/virt/DBG2.pxb
> create mode 100644 tests/data/acpi/virt/DBG2.topology
> create mode 100644 tests/data/acpi/virt/DSDT.topology
> create mode 100644 tests/data/acpi/virt/FACP.pxb
> create mode 100644 tests/data/acpi/virt/FACP.topology
> create mode 100644 tests/data/acpi/virt/GTDT.pxb
> create mode 100644 tests/data/acpi/virt/GTDT.topology
> create mode 100644 tests/data/acpi/virt/IORT.topology
> create mode 100644 tests/data/acpi/virt/MCFG.pxb
> create mode 100644 tests/data/acpi/virt/MCFG.topology
> create mode 100644 tests/data/acpi/virt/PPTT.memhp
> create mode 100644 tests/data/acpi/virt/PPTT.numamem
> create mode 100644 tests/data/acpi/virt/PPTT.pxb
> create mode 100644 tests/data/acpi/virt/PPTT.topology
> create mode 100644 tests/data/acpi/virt/SPCR.pxb
> create mode 100644 tests/data/acpi/virt/SPCR.topology
>
next prev parent reply other threads:[~2022-09-22 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 13:11 [PATCH 0/4] Only generate cluster node in PPTT when specified Yicong Yang via
2022-09-22 13:11 ` [PATCH 1/4] hw/acpi/aml-build: " Yicong Yang via
2022-10-07 13:48 ` Michael S. Tsirkin
2022-10-12 2:15 ` Yicong Yang via
2022-10-09 6:46 ` wangyanan (Y) via
2022-10-12 2:12 ` Yicong Yang via
2022-09-22 13:11 ` [PATCH 2/4] tests: virt: update expected ACPI tables for virt test Yicong Yang via
2022-09-22 13:11 ` [PATCH 3/4] tests: acpi: aarch64: add topology test for aarch64 Yicong Yang via
2022-09-22 13:11 ` [PATCH 4/4] tests: acpi: aarch64: add *.topology tables Yicong Yang via
2022-09-22 14:31 ` Jonathan Cameron via [this message]
2022-09-23 7:50 ` [PATCH 0/4] Only generate cluster node in PPTT when specified Yicong Yang via
2022-10-07 13:46 ` Michael S. Tsirkin
2022-10-26 14:52 ` Michael S. Tsirkin
2022-10-27 3:06 ` Yicong Yang via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922153128.000035a4@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=ani@anisinha.ca \
--cc=darren@os.amperecomputing.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=hesham.almatary@huawei.com \
--cc=imammedo@redhat.com \
--cc=ionela.voinescu@arm.com \
--cc=linuxarm@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=prime.zeng@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).