From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Vikram Garhwal <vikram.garhwal@amd.com>,
qemu-devel@nongnu.org, edgar.iglesias@amd.com,
francisco.iglesias@amd.com,
Vikram Garhwal <fnu.vikram@xilinx.com>,
Jason Wang <jasowang@redhat.com>,
Alistair Francis <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"open list:Xilinx ZynqMP and..." <qemu-arm@nongnu.org>
Subject: Re: [QEMU][PATCH 2/5] hw/net/can: Introduce Xilinx Versal CANFD controller
Date: Thu, 22 Sep 2022 18:27:09 +0200 [thread overview]
Message-ID: <202209221827.09886.pisa@cmp.felk.cvut.cz> (raw)
In-Reply-To: <CAFEAcA9=O6yPo9RdFWgq6eJZ=7vX4bQFuaoV6y+JCoM-=+TSTg@mail.gmail.com>
Hello Peter,
thanks for the review and Vikram for his work, I do not know
much about Xilinx emulation nor Xilixn CAN controllers so I cannot
comment much on this part.
On Thursday 22 of September 2022 16:46:48 Peter Maydell wrote:
> On Sat, 10 Sept 2022 at 07:13, Vikram Garhwal <vikram.garhwal@amd.com> > > To create virtual CAN on the host machine, please check the QEMU CAN
> > docs: https://github.com/qemu/qemu/blob/master/docs/can.txt
>
> That link is a 404. You could just give the relative path to the
> docs in the repo, which is docs/system/devices/can.rst
The actual generated documentation is located at
https://www.qemu.org/docs/master/system/devices/can.html
I think that that URL is stable for some time... Could it
be used directly in source to provide path to formated version?
> For the machine specifics, you should include (either in the patch 4
> where you add this to the xlnx-versal-virt board, or in a separate patch
> if it seems too big) updates to docs/system/arm/xlnx-versal-virt.rst
> which document the new functionality, including, if it's useful to users,
> some documentation of how to use it.
Some short example how to use emulation even with Xilinx Zynq and Ultra Scale
would be nice if added into the document. If the document length expands
too much, then probably division into individual documents per controllers
would be nice.
By the way, CAN in Automation publishes our overview article about our CAN
activities including some short netion of QEMU integration
https://can-newsletter.org/uploads/media/raw/a9abe317ae034be55d99fee4410ad70e.pdf
I hope I wind some time for CAN in QEMU, RTEMS and Linux ongoing projects,
but I need to finish some promissed project for ESA the first.
Best wishes,
Pavel
--
Pavel Pisa
phone: +420 603531357
e-mail: pisa@cmp.felk.cvut.cz
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://control.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
RISC-V education: https://comparch.edu.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
next prev parent reply other threads:[~2022-09-22 17:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 6:12 [QEMU][PATCH 1/5] MAINTAINERS: Update maintainer's email for Xilinx CAN Vikram Garhwal
2022-09-10 6:12 ` [QEMU][PATCH 2/5] hw/net/can: Introduce Xilinx Versal CANFD controller Vikram Garhwal
2022-09-22 14:46 ` Peter Maydell
2022-09-22 16:27 ` Pavel Pisa [this message]
2022-10-21 22:36 ` Vikram Garhwal
2022-09-10 6:12 ` [QEMU][PATCH 3/5] xlnx-zynqmp: Connect Xilinx VERSAL CANFD controllers Vikram Garhwal
2022-09-22 14:31 ` Peter Maydell
2022-09-10 6:12 ` [QEMU][PATCH 4/5] tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller Vikram Garhwal
2022-09-19 17:52 ` Thomas Huth
2022-09-10 6:12 ` [QEMU][PATCH 5/5] MAINTAINERS: Include canfd tests under Xilinx CAN Vikram Garhwal
2022-09-22 14:21 ` Peter Maydell
2022-09-26 11:35 ` [QEMU][PATCH 1/5] MAINTAINERS: Update maintainer's email for " Francisco Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209221827.09886.pisa@cmp.felk.cvut.cz \
--to=pisa@cmp.felk.cvut.cz \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@amd.com \
--cc=edgar.iglesias@gmail.com \
--cc=fnu.vikram@xilinx.com \
--cc=francisco.iglesias@amd.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vikram.garhwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).