From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH 1/3] block: bdrv_child_get_parent_aio_context is not GS
Date: Fri, 23 Sep 2022 14:52:25 +0200 [thread overview]
Message-ID: <20220923125227.300202-2-hreitz@redhat.com> (raw)
In-Reply-To: <20220923125227.300202-1-hreitz@redhat.com>
All implementations of bdrv_child_get_parent_aio_context() are IO_CODE
(or do not mark anything in the case of block jobs), so this too can be
IO_CODE. By the definition of "I/O API functions" in block-io.h, this
is a strict relaxation, as I/O code can be run from both GS and I/O code
arbitrarily.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index bc85f46eed..7f2a9d4df0 100644
--- a/block.c
+++ b/block.c
@@ -1499,7 +1499,7 @@ const BdrvChildClass child_of_bds = {
AioContext *bdrv_child_get_parent_aio_context(BdrvChild *c)
{
- GLOBAL_STATE_CODE();
+ IO_CODE();
return c->klass->get_parent_aio_context(c);
}
--
2.36.1
next prev parent reply other threads:[~2022-09-23 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 12:52 [PATCH 0/3] blcok: Start/end drain on correct AioContext Hanna Reitz
2022-09-23 12:52 ` Hanna Reitz [this message]
2022-10-07 8:44 ` [PATCH 1/3] block: bdrv_child_get_parent_aio_context is not GS Kevin Wolf
2022-09-23 12:52 ` [PATCH 2/3] block-backend: Update ctx immediately after root Hanna Reitz
2022-10-07 8:48 ` Kevin Wolf
2022-09-23 12:52 ` [PATCH 3/3] block: Start/end drain on correct AioContext Hanna Reitz
2022-10-07 9:05 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923125227.300202-2-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).