From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFDADC07E9D for ; Mon, 26 Sep 2022 20:02:06 +0000 (UTC) Received: from localhost ([::1]:45480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocuIg-0000Zu-BX for qemu-devel@archiver.kernel.org; Mon, 26 Sep 2022 16:02:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocu8E-0008L1-6F for qemu-devel@nongnu.org; Mon, 26 Sep 2022 15:51:11 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:57959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocu87-0005vo-2V for qemu-devel@nongnu.org; Mon, 26 Sep 2022 15:51:07 -0400 Received: from lenovo-t14s.redhat.com ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MlbPO-1p2vDl2mSg-00ijIb; Mon, 26 Sep 2022 21:50:51 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Jason Wang , Greg Kurz , David Gibson , Thomas Huth , Eric Blake , "Dr. David Alan Gilbert" , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Markus Armbruster , Ralph Schmieder , Stefano Brivio Subject: [PATCH v9 00/16] qapi: net: add unix socket type support to netdev backend Date: Mon, 26 Sep 2022 21:50:32 +0200 Message-Id: <20220926195048.487915-1-lvivier@redhat.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:/fMcXVkUaehE4PRP2fEUrEVxffo17So5Se3Q+bCXpv+5obvN990 xfqBlnMo+Es3SByCzNauqZ0wtDQ10p6MSse9lIWjRdlRyKKZFQ/qVwAO1laoqbAnEh+YfHy w2F/OQtRRjRz8UYe61jSemveV9/4le23cyjWz7t8tkNiqtd/r0G2J0TR6f/hQ21gd+tXFuA uirUyCOIou+f5YPxLzLMA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vSuDALP12mw=:9JM+OYf7x4V34Hfha2y06c vK2TSa4LcfTwzYgLyo/Tbe36Jd6R1P+dUn3g5dc7gZpjEnn6UQ+dOKDCakjJO7S6dyRCqssXX PFys5HK16mlxA9q4c7yB7QTshLgKygW3fd45xzG9TVytqzniTgtyGXEgjuege2/qjV5aBb1Ik Tsk5tvhHjU/RUPT+7qDKZiETT9NLCHTOZm7eGInjobVvoPaNxBHs7wKzPJyfZ8HCEY0IodGP6 +5zFpnuvmcDeLd257tu/xFbBabAMWf/D/rj6JMHXA/FJFhVao8wIhX8wuvqB/0sULEpe7sV/6 MB4Fs7LpYUafpeIvHBnvOspJiwKQz3Aa/x6uKP3zd7njOrhBHIm57hYIaPyRHmZR+fdxrLTfP JTiBHH7GnLh/SIdjhYSgHLuPfXPcN9xAoHYYsXroYV/wnN9xeKLUygCTjEWc01wW8xt0ObLEC k0By1TrR5QkUHpV9hJLWLaz4NIYWzUGqlhZsKCqbFWhxCj3d/qvw+VvuBNeXUeAou1fuZu/TI srfw8C+rpIjx8jJKp9CJnOQPYJSWPLuN9yRILyySaoQdHAq75gi+O4xhyKUa1A5HfTEu45/kZ TAzVqyetyMk+inpaWWiFzBAXFRSPL3vCLBBpcaIumcAts+oNVZ4axNDNPGJbdjVk8tHqJgM0c tMcm2+n9RtblCVMMGVXGE93RL7HgDGK6g8fZlGAES8Ox7gVjCvMK3SE0hwp29l8tSyYok4D9L fCVrA6gUjTnsel4Pm/eb8r4HauB22DyWv+o51VCmAypVac4zcnFtLh9DqLP53ffaecPETFc5m 1ZvRPQC Received-SPF: permerror client-ip=212.227.126.133; envelope-from=lvivier@redhat.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_FAIL=0.001, SPF_HELO_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "-netdev socket" only supports inet sockets.=0D =0D It's not a complex task to add support for unix sockets, but=0D the socket netdev parameters are not defined to manage well unix=0D socket parameters.=0D =0D As discussed in:=0D =0D "socket.c added support for unix domain socket datagram transport"=0D https://lore.kernel.org/qemu-devel/1C0E1BC5-904F-46B0-8044-68E43E67BE60@g= mail.com/=0D =0D This series adds support of unix socket type using SocketAddress QAPI struc= ture.=0D =0D Two new netdev backends, "stream" and "dgram" are added, that are barely a = copy of "socket"=0D backend but they use the SocketAddress QAPI to provide socket parameters.=0D And then they also implement unix sockets (TCP and UDP).=0D =0D Some examples of CLI syntax:=0D =0D for TCP:=0D =0D -netdev stream,id=3Dsocket0,addr.type=3Dinet,addr.host=3Dlocalhost,addr.p= ort=3D1234=0D -netdev stream,id=3Dsocket0,server=3Doff,addr.type=3Dinet,addr.host=3Dloc= alhost,addr.port=3D1234=0D =0D -netdev dgram,id=3Dsocket0,\=0D local.type=3Dinet,local.host=3Dlocalhost,local.port=3D1234,\=0D remote.type=3Dinet,remote.host=3Dlocalhost,remote.port=3D1235=0D =0D for UNIX:=0D =0D -netdev stream,id=3Dsocket0,addr.type=3Dunix,addr.path=3D/tmp/qemu0=0D -netdev stream,id=3Dsocket0,server=3Doff,addr.type=3Dunix,addr.path=3D/tm= p/qemu0=0D =0D -netdev dgram,id=3Dsocket0,\=0D local.type=3Dunix,local.path=3D/tmp/qemu0,\=0D remote.type=3Dunix,remote.path=3D/tmp/qemu1=0D =0D for FD:=0D =0D -netdev stream,id=3Dsocket0,addr.type=3Dfd,addr.str=3D4=0D -netdev stream,id=3Dsocket0,server=3Doff,addr.type=3Dfd,addr.str=3D5=0D =0D -netdev dgram,id=3Dsocket0,local.type=3Dfd,addr.str=3D4=0D =0D v9:=0D - add events to report stream connection/disconnection=0D - remove from net/dgram.c send_fn, listen_fd, net_dgram_accept()=0D net_dgram_connect() and net_dgram_send() that are only=0D needed by net/stream.c=0D - remove from net/stream.c send_fn=0D - add Red Hat copyright=0D - add original net/socket.c Stefano's patch (EINVAL)=0D =0D v8:=0D - test ipv4 and ipv6 parameters (stream inet)=0D - test abstract parameter (stream unix)=0D - add SocketAddressInet supported parameters in qemu-options.hx=0D (only stream, supported by the move to QIO)=0D - with qio_channel_writev() replace (ret =3D=3D -1 && errno =3D=3D EAGAIN= )=0D by (ret =3D=3D QIO_CHANNEL_ERR_BLOCK)=0D =0D v7:=0D - add qtests=0D - update parameters table in net.json=0D - update socket_uri() and socket_parse()=0D =0D v6:=0D - s/netdev option/-netdev option/ PATCH 4=0D - s/=C2=A0/ /=0D - update @NetdevStreamOptions and @NetdevDgramOptions comments=0D - update PATCH 4 description message=0D - add missing return in error case for unix stream socket=0D - split socket_uri() patch: move and rename, then change content=0D =0D v5:=0D - remove RFC prefix=0D - put the change of net_client_parse() into its own patch (exit() in the= =0D function)=0D - update comments regarding netdev_is_modern() and netdev_parse_modern()= =0D - update error case in net_stream_server_init()=0D - update qemu-options.hx with unix type=0D - fix HMP "info network" with unix protocol/server side.=0D =0D v4:=0D - net_client_parse() fails with exit() rather than with return.=0D - keep "{ 'name': 'vmnet-host', 'if': 'CONFIG_VMNET' }" on its=0D own line in qapi/net.json=0D - add a comment in qapi/net.json about parameters usage=0D - move netdev_is_modern() check to qemu_init()=0D - in netdev_is_modern(), check for JSON and use qemu_opts_do_parse()=0D to parse parameters and detect type value.=0D - add a blank line after copyright comment=0D =0D v3:=0D - remove support of "-net" for dgram and stream. They are only=0D supported with "-netdev" option.=0D - use &error_fatal directly in net_client_inits()=0D - update qemu-options.hx=0D - move to QIO for stream socket=0D =0D v2:=0D - use "stream" and "dgram" rather than "socket-ng,mode=3Dstream"=0D and ""socket-ng,mode=3Ddgram"=0D - extract code to bypass qemu_opts_parse_noisily() to=0D a new patch=0D - do not ignore EINVAL (Stefano)=0D - fix "-net" option=0D =0D CC: Ralph Schmieder =0D CC: Stefano Brivio =0D CC: Daniel P. Berrang=C3=A9 =0D CC: Markus Armbruster =0D =0D Laurent Vivier (14):=0D net: introduce convert_host_port()=0D net: remove the @errp argument of net_client_inits()=0D net: simplify net_client_parse() error management=0D qapi: net: introduce a way to bypass qemu_opts_parse_noisily()=0D qapi: net: add stream and dgram netdevs=0D net: stream: add unix socket=0D net: dgram: make dgram_dst generic=0D net: dgram: move mcast specific code from net_socket_fd_init_dgram()=0D net: dgram: add unix socket=0D qemu-sockets: move and rename SocketAddress_to_str()=0D qemu-sockets: update socket_uri() and socket_parse() to be consistent=0D net: stream: move to QIO to enable additional parameters=0D tests/qtest: netdev: test stream and dgram backends=0D net: stream: add QAPI events to report connection state=0D =0D Stefano Brivio (2):=0D net: socket: Don't ignore EINVAL on netdev socket connection=0D net: stream: Don't ignore EINVAL on netdev socket connection=0D =0D hmp-commands.hx | 2 +-=0D include/net/net.h | 6 +-=0D include/qemu/sockets.h | 4 +-=0D monitor/hmp-cmds.c | 23 +-=0D net/clients.h | 6 +=0D net/dgram.c | 619 ++++++++++++++++++++++++++++++++++++=0D net/hub.c | 2 +=0D net/meson.build | 2 +=0D net/net.c | 169 +++++++---=0D net/socket.c | 3 +-=0D net/stream.c | 384 ++++++++++++++++++++++=0D qapi/net.json | 109 ++++++-=0D qemu-options.hx | 14 +=0D softmmu/vl.c | 16 +-=0D tests/qtest/meson.build | 1 +=0D tests/qtest/netdev-socket.c | 391 +++++++++++++++++++++++=0D util/qemu-sockets.c | 25 ++=0D 17 files changed, 1692 insertions(+), 84 deletions(-)=0D create mode 100644 net/dgram.c=0D create mode 100644 net/stream.c=0D create mode 100644 tests/qtest/netdev-socket.c=0D =0D -- =0D 2.37.3=0D =0D