qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ani Sinha <ani@anisinha.ca>, qemu-devel <qemu-devel@nongnu.org>,
	Thomas Huth <thuth@redhat.com>,
	"Maydell, Peter" <peter.maydell@linaro.org>,
	"P. Berrange, Daniel" <berrange@redhat.com>,
	John Snow <jsnow@redhat.com>,
	"Mammedov, Igor" <imammedo@redhat.com>
Subject: Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits
Date: Tue, 27 Sep 2022 18:09:22 -0400	[thread overview]
Message-ID: <20220927175440-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CABgObfYW8O-JGhjLm47HmHG7WRhOQDO1EhUCTP59TZo4DnkQVg@mail.gmail.com>

On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote:
> I also second the idea of using avocado instead of pytest, by the way.
> 
> Paolo

I do not think this is a good fit for bios tests.
bios tests are intended for a wide audience of ACPI developers
across a variety of host systems. They basically do not need anything
from the host and they need to be super easy to configure
since we have lots of drive through contributors.


Problem is I don't think avocado is yet at the level where I can
ask random developers to use it to check their ACPI patches.

I just went ahead and rechecked and the situation isn't much better
yet. I think the focus of avocado is system testing of full guests with
KVM, not unit testing of ACPI.

Let's start with installation on a clean box:

following
https://avocado-framework.readthedocs.io/en/98.0/guides/user/chapters/installing.html

Ugh pip, will install a bunch of stuff in ~/.local and ask me to tweak
PATH ... and what about security? No thanks!

So ...
do I want LTS or latest? Well I donnu .... let's try LTS?

$ dnf module enable avocado:82lts
[sudo] password for mst: 
Last metadata expiration check: 6 days, 15:20:21 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
Dependencies resolved.
==========================================================================================================================================
 Package                          Architecture                    Version                          Repository                        Size
==========================================================================================================================================
Enabling module streams:
 avocado                                                          82lts                                                                  

Transaction Summary
==========================================================================================================================================

Is this ok [y/N]: y
Complete!
[mst@tuck linux]$  dnf module install avocado
Last metadata expiration check: 6 days, 15:20:41 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
No default profiles for module avocado:82lts. Available profiles: default, minimal
Error: Problems in request:
broken groups or modules: avocado


Ugh I guess latest then?


[mst@tuck linux]$ dnf module enable avocado:latest
Last metadata expiration check: 6 days, 15:25:21 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
Dependencies resolved.
The operation would result in switching of module 'avocado' stream '82lts' to stream 'latest'
Error: It is not possible to switch enabled streams of a module unless explicitly enabled via configuration option module_stream_switch.
It is recommended to rather remove all installed content from the module, and reset the module using 'dnf module reset <module_name>' command. After you reset the module, you can install the other stream.



Scary ... I don't really know what are streams and I am guessing module
is avocado here? and what will this affect. Oh well, I'll risk this:



[mst@tuck linux]$ dnf module reset  avocado
Last metadata expiration check: 6 days, 15:25:46 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
Dependencies resolved.
==========================================================================================================================================
 Package                          Architecture                    Version                          Repository                        Size
==========================================================================================================================================
Resetting modules:
 avocado                                                                                                                                 

Transaction Summary
==========================================================================================================================================

Is this ok [y/N]: y
Complete!
[mst@tuck linux]$ dnf module enable avocado:latest
Last metadata expiration check: 6 days, 15:25:55 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
Dependencies resolved.
==========================================================================================================================================
 Package                          Architecture                    Version                          Repository                        Size
==========================================================================================================================================
Enabling module streams:
 avocado                                                          latest                                                                 

Transaction Summary
==========================================================================================================================================

Is this ok [y/N]: y
Complete!
[mst@tuck linux]$  dnf module install avocado
Last metadata expiration check: 6 days, 15:26:03 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
Dependencies resolved.
==========================================================================================================================================
 Package                                              Architecture  Version                                  Repository              Size
==========================================================================================================================================
Installing group/module packages:
 python3-avocado                                      noarch        97.0-1.module_f35+14550+3bc43fee         updates-modular        603 k
 python3-avocado-plugins-output-html                  noarch        97.0-1.module_f35+14550+3bc43fee         updates-modular         99 k
 python3-avocado-plugins-varianter-yaml-to-mux        noarch        97.0-1.module_f35+14550+3bc43fee         updates-modular         29 k
Installing dependencies:
 gdb-gdbserver                                        x86_64        12.1-1.fc35                              updates                300 k
 python-avocado-common                                noarch        97.0-1.module_f35+14550+3bc43fee         updates-modular         29 k
Installing module profiles:
 avocado/default                                                                                                                         

Transaction Summary
==========================================================================================================================================
Install  5 Packages

Total download size: 1.0 M
Installed size: 3.5 M
Is this ok [y/N]: y
Downloading Packages:
(1/5): python-avocado-common-97.0-1.module_f35+14550+3bc43fee.noarch.rpm                                   40 kB/s |  29 kB     00:00    
(2/5): python3-avocado-plugins-output-html-97.0-1.module_f35+14550+3bc43fee.noarch.rpm                    109 kB/s |  99 kB     00:00    
(3/5): python3-avocado-plugins-varianter-yaml-to-mux-97.0-1.module_f35+14550+3bc43fee.noarch.rpm           28 kB/s |  29 kB     00:01    
(4/5): python3-avocado-97.0-1.module_f35+14550+3bc43fee.noarch.rpm                                        479 kB/s | 603 kB     00:01    
(5/5): gdb-gdbserver-12.1-1.fc35.x86_64.rpm                                                               232 kB/s | 300 kB     00:01    
------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                     204 kB/s | 1.0 MB     00:05     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
Regex version mismatch, expected: 10.40 2022-04-14 actual: 10.35 2020-05-09
  Preparing        :                                                                                                                  1/1 
  Installing       : python-avocado-common-97.0-1.module_f35+14550+3bc43fee.noarch                                                    1/5 
  Installing       : gdb-gdbserver-12.1-1.fc35.x86_64                                                                                 2/5 
  Installing       : python3-avocado-97.0-1.module_f35+14550+3bc43fee.noarch                                                          3/5 
  Installing       : python3-avocado-plugins-output-html-97.0-1.module_f35+14550+3bc43fee.noarch                                      4/5 
  Installing       : python3-avocado-plugins-varianter-yaml-to-mux-97.0-1.module_f35+14550+3bc43fee.noarch                            5/5 
  Running scriptlet: python3-avocado-plugins-varianter-yaml-to-mux-97.0-1.module_f35+14550+3bc43fee.noarch                            5/5 
  Verifying        : gdb-gdbserver-12.1-1.fc35.x86_64                                                                                 1/5 
  Verifying        : python-avocado-common-97.0-1.module_f35+14550+3bc43fee.noarch                                                    2/5 
  Verifying        : python3-avocado-97.0-1.module_f35+14550+3bc43fee.noarch                                                          3/5 
  Verifying        : python3-avocado-plugins-output-html-97.0-1.module_f35+14550+3bc43fee.noarch                                      4/5 
  Verifying        : python3-avocado-plugins-varianter-yaml-to-mux-97.0-1.module_f35+14550+3bc43fee.noarch                            5/5 

Installed:
  gdb-gdbserver-12.1-1.fc35.x86_64                                                                                                        
  python-avocado-common-97.0-1.module_f35+14550+3bc43fee.noarch                                                                           
  python3-avocado-97.0-1.module_f35+14550+3bc43fee.noarch                                                                                 
  python3-avocado-plugins-output-html-97.0-1.module_f35+14550+3bc43fee.noarch                                                             
  python3-avocado-plugins-varianter-yaml-to-mux-97.0-1.module_f35+14550+3bc43fee.noarch                                                   

Complete!


Great! Except I want avocado-vt of course. I will pretend someone told
me that I need it.

Installing Avocado-VT on Fedora or Enterprise Linux is a matter of installing the avocado-plugins-vt package. Install it with:

$ yum install avocado-plugins-vt


I guess I will replace yum with dnf then?



[mst@tuck linux]$ dnf install avocado-plugins-vt
Last metadata expiration check: 6 days, 15:31:16 ago on Wed 21 Sep 2022 02:33:31 AM EDT.
No match for argument: avocado-plugins-vt
Error: Unable to find a match: avocado-plugins-vt


And this is Fedora. What do people do on debian? non Linux?


-- 
MST



  reply	other threads:[~2022-09-27 22:13 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 17:00 [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits Ani Sinha
2022-07-10 17:00 ` [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits Ani Sinha
2022-07-11 20:38   ` John Snow
2022-07-12  7:17     ` Ani Sinha
2022-07-12 15:23       ` John Snow
2022-07-12 15:38         ` Ani Sinha
2022-07-12 15:42           ` John Snow
2022-07-12 15:46             ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 02/11] acpi/tests/bits: add SPDX license identifiers for bios bits tests Ani Sinha
2022-07-14 13:56   ` Daniel P. Berrangé
2022-07-14 14:12     ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 03/11] acpi/tests/bits: disable acpi PSS tests that are failing in biosbits Ani Sinha
2022-07-10 17:00 ` [PATCH v2 04/11] acpi/tests/bits: add smilatency test suite from bits in order to disable it Ani Sinha
2022-07-10 17:00 ` [PATCH v2 05/11] acpi/tests/bits: add SPDX license identifiers for bios bits smilatency tests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 06/11] acpi/tests/bits: disable smilatency test since it does not pass everytime Ani Sinha
2022-07-10 17:00 ` [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits Ani Sinha
2022-07-11 20:42   ` John Snow
2022-07-12  7:15     ` Ani Sinha
2022-09-06 13:05       ` Daniel P. Berrangé
2022-07-14 14:05   ` Daniel P. Berrangé
2022-07-14 14:19     ` Ani Sinha
2022-07-14 17:49       ` Ani Sinha
2022-07-14 20:43       ` Michael S. Tsirkin
2022-07-14 20:41   ` Michael S. Tsirkin
2022-07-15  4:17     ` Ani Sinha
2022-07-15  6:50       ` Michael S. Tsirkin
2022-07-16  6:36         ` Ani Sinha
2022-07-16 15:30           ` Michael S. Tsirkin
2022-07-25 18:02             ` Ani Sinha
2022-07-27 18:38               ` Ani Sinha
2022-09-16 16:00                 ` Ani Sinha
2022-09-17 20:28                   ` Michael S. Tsirkin
2022-09-27  8:13                     ` Ani Sinha
2022-09-27  8:33                       ` Daniel P. Berrangé
2022-09-27 10:07                         ` Ani Sinha
2022-09-27 10:18                           ` Daniel P. Berrangé
2022-09-27 10:24                             ` Ani Sinha
2022-09-27 11:42                             ` Ani Sinha
2022-09-27 14:05                               ` Ani Sinha
2022-09-27 15:45                                 ` Daniel P. Berrangé
2022-09-27 21:21                                   ` Michael S. Tsirkin
2022-09-28  8:31                                     ` Thomas Huth
2022-09-28  8:35                                       ` Daniel P. Berrangé
2022-09-28  9:47                                         ` Michael S. Tsirkin
2022-09-28  9:35                                       ` Michael S. Tsirkin
2022-09-28  9:39                                         ` Thomas Huth
2022-09-28  9:56                                           ` Michael S. Tsirkin
2022-10-06  7:58                                             ` Ani Sinha
2022-10-06  8:11                                               ` Ani Sinha
2022-10-06 10:18                                                 ` Ani Sinha
2022-09-27 21:19                           ` Michael S. Tsirkin
2022-09-27 21:18                         ` Michael S. Tsirkin
2022-09-28  3:08                           ` Ani Sinha
2022-09-28  3:58                             ` Michael S. Tsirkin
2022-09-28  6:06                               ` Ani Sinha
2022-10-06 12:12                                 ` Michael S. Tsirkin
2022-09-28  6:58                           ` Daniel P. Berrangé
2022-09-28  7:15                             ` Ani Sinha
2022-09-28  7:26                               ` Daniel P. Berrangé
2022-09-28  9:19                             ` Michael S. Tsirkin
2022-09-27 21:44   ` Paolo Bonzini
2022-09-27 22:09     ` Michael S. Tsirkin [this message]
2022-09-27 23:10       ` Paolo Bonzini
2022-09-28  5:53         ` Michael S. Tsirkin
2022-09-28  7:06       ` Daniel P. Berrangé
2022-09-28  7:43         ` Thomas Huth
2022-10-09  5:21           ` Ani Sinha
2022-10-09  6:30             ` Ani Sinha
2022-10-09 16:06           ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 08/11] acpi/tests/bits: add biosbits config file for running bios tests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 09/11] acpi/tests/bits: add a README file describing bits pytests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 10/11] pytest: add pytest to the meson build system Ani Sinha
2022-07-11 20:46   ` John Snow
2022-07-12  6:52     ` Ani Sinha
2022-09-06 13:10       ` Daniel P. Berrangé
2022-09-27 21:26         ` Michael S. Tsirkin
2022-09-28  7:32           ` Thomas Huth
2022-09-28  9:23             ` Michael S. Tsirkin
2022-07-10 17:00 ` [PATCH v2 11/11] MAINTAINERS: add myself as the maintainer for acpi biosbits pytests Ani Sinha
2022-07-11  9:33 ` [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits Michael S. Tsirkin
2022-07-14 13:24   ` Peter Maydell
2022-09-06  6:26     ` Ani Sinha
2022-09-06  8:19       ` Michael S. Tsirkin
2022-09-06 13:15     ` Daniel P. Berrangé
2022-09-06 13:28       ` Ani Sinha
2022-09-06 13:30         ` Daniel P. Berrangé
2022-09-09 12:53           ` Ani Sinha
2022-09-06 14:03       ` Michael S. Tsirkin
2022-09-06 14:10         ` Daniel P. Berrangé
2022-09-06 14:19           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927175440-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=berrange@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).