From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F797C04A95 for ; Wed, 28 Sep 2022 10:04:28 +0000 (UTC) Received: from localhost ([::1]:46444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odTvX-00010u-4l for qemu-devel@archiver.kernel.org; Wed, 28 Sep 2022 06:04:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odSE5-00087k-Vy for qemu-devel@nongnu.org; Wed, 28 Sep 2022 04:15:30 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:33311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odSE3-00089t-No for qemu-devel@nongnu.org; Wed, 28 Sep 2022 04:15:29 -0400 Received: from quad ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MDQmW-1oU8pd2npO-00ASW9; Wed, 28 Sep 2022 10:15:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Subject: [PULL 01/38] linux-user: use 'max' instead of 'qemu32' / 'qemu64' by default Date: Wed, 28 Sep 2022 10:14:40 +0200 Message-Id: <20220928081517.734954-2-laurent@vivier.eu> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220928081517.734954-1-laurent@vivier.eu> References: <20220928081517.734954-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:e345ae5atdF0YMpk8asE0ffRIPJ41+q9N1OBzYNeq2TVkT/qDtD aAMSB0wWLtGvXA4OFt16C53Ii9BGXwHrOprOgmVynbMaXJ6JqWTHQjpEtpa+uDNzZHr2Ycc MwoS8qiczEvaU7eY5KeaAy6EGq4wL4YBb2zPf+Rmkn6lBqaljy2ti+CQoHQ4f8ivTNqkATD KSVgqK/BkG00PTEDgKsXg== X-UI-Out-Filterresults: notjunk:1;V03:K0:pCR6V7K3E4Y=:RhM5zCHz0wNSjQIpTbM2lo GDYtafErBtIw23zYgZERSxjVty8P2uRxjEiWxjGmHBMf21hOWCrOh9ss+Jtc4V5bS/9buq6BC L/7a0ChlHZKoNOoclh0U8LhAzUAAL5P6u7JOQOAiJAaOgZU3c1GS0ZcPwhFMa6FuvkDplYNkd yZDYUj9mo7w4ZMUt6ho7VJ/m4eCE21RSf1P1u7pawMFQo1th4xKnZ26W7KvciTCYMX91fA283 Wyj71UgB7h+8A7vhCnamSn09mqTJgrzYUMb1IEucUww0KN7FHE+l5DcTv18ZWkTpL+HZgXSXt PdgPLiGxANFbmvTH+VjcvFSVzW9jF2ZzW9r2al62JWBmSRvvbrNjIHgwAhT4xghAG2+qYr5zQ Dtmq99WalzPaOvP+dxUJqfnwxPnjQS1QbKyBP+i+EuP2zfgTVHZ3OJIeAJ1naxTiNflc1Xgka ooopCmb5gbRo0lcEKm3T9sLH38J7bg3yyMFsjXTd+E9jHSVKM8cN1jU6MTDxwirb2p1VvJ4p/ 5qtsXDj8CBJbsG8Gs5q4h3fIOhDRDYoWWRiaDG0SA7DwBYrieau6t6FddcRLoS6CiOz30amQu VogokSMhyB285Knxw6i6n6uqvY0L78iUZrW/woGleTHW352iHGsozWUSmd2ysu00dPhdUQrA0 OeIjpucf9/rWowO5Yu4MioqCCqZjiMmZO2JbSYx+dYWZBXzgssIyA/6SeANLCxYSYO/Yyu/+g L/elFKHU5FF1IAjjBUcJvyaVE4cFaxa98gKCQ0gQ2EoqIry6DcKc4T8QdGM//PUMlmfOqZCqL xoj2fzX Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Daniel P. Berrangé The 'qemu64' CPU model implements the least featureful x86_64 CPU that's possible. Historically this hasn't been an issue since it was rare for OS distros to build with a higher mandatory CPU baseline. With RHEL-9, however, the entire distro is built for the x86_64-v2 ABI baseline: https://developers.redhat.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level It is likely that other distros may take similar steps in the not too distant future. For example, it has been suggested for Fedora on a number of occasions. This new baseline is not compatible with the qemu64 CPU model though. While it is possible to pass a '-cpu xxx' flag to qemu-x86_64, the usage of QEMU doesn't always allow for this. For example, the args are typically controlled via binfmt rules that the user has no ability to change. This impacts users who are trying to use podman on aarch64 platforms, to run containers with x86_64 content. There's no arg to podman that can be used to change the qemu-x86_64 args, and a non-root user of podman can not change binfmt rules without elevating privileges: https://github.com/containers/podman/issues/15456#issuecomment-1228210973 Changing to the 'max' CPU model gives 'qemu-x86_64' maximum compatibility with binaries it is likely to encounter in the wild, and not likely to have a significant downside for existing usage. Most other architectures already use an 'any' CPU model, which is often mapped to 'max' (or similar) already, rather than the oldest possible CPU model. For the sake of consistency the 'i386' architecture is also changed from using 'qemu32' to 'max'. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Message-Id: <20220923110413.70593-1-berrange@redhat.com> Signed-off-by: Laurent Vivier --- linux-user/i386/target_elf.h | 2 +- linux-user/x86_64/target_elf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/i386/target_elf.h b/linux-user/i386/target_elf.h index 1c6142e7da0d..238a9aba738a 100644 --- a/linux-user/i386/target_elf.h +++ b/linux-user/i386/target_elf.h @@ -9,6 +9,6 @@ #define I386_TARGET_ELF_H static inline const char *cpu_get_model(uint32_t eflags) { - return "qemu32"; + return "max"; } #endif diff --git a/linux-user/x86_64/target_elf.h b/linux-user/x86_64/target_elf.h index 7b76a90de880..3f628f8d6619 100644 --- a/linux-user/x86_64/target_elf.h +++ b/linux-user/x86_64/target_elf.h @@ -9,6 +9,6 @@ #define X86_64_TARGET_ELF_H static inline const char *cpu_get_model(uint32_t eflags) { - return "qemu64"; + return "max"; } #endif -- 2.37.3