qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 14/37] linux-user: Fix madvise(MADV_DONTNEED) on alpha
Date: Wed, 28 Sep 2022 22:27:14 +0200	[thread overview]
Message-ID: <20220928202737.793171-15-laurent@vivier.eu> (raw)
In-Reply-To: <20220928202737.793171-1-laurent@vivier.eu>

From: Ilya Leoshkevich <iii@linux.ibm.com>

MADV_DONTNEED has a different value on alpha, compared to all the other
architectures. Fix by using TARGET_MADV_DONTNEED instead of
MADV_DONTNEED.

Fixes: 892a4f6a750a ("linux-user: Add partial support for MADV_DONTNEED")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220906000839.1672934-3-iii@linux.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/mmap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 83fdae7034ea..942bec7e8528 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -22,6 +22,7 @@
 #include "qemu.h"
 #include "user-internals.h"
 #include "user-mmap.h"
+#include "target_mman.h"
 
 static pthread_mutex_t mmap_mutex = PTHREAD_MUTEX_INITIALIZER;
 static __thread int mmap_lock_count;
@@ -897,7 +898,7 @@ abi_long target_madvise(abi_ulong start, abi_ulong len_in, int advice)
      * anonymous mappings. In this case passthrough is safe, so do it.
      */
     mmap_lock();
-    if (advice == MADV_DONTNEED &&
+    if (advice == TARGET_MADV_DONTNEED &&
         can_passthrough_madv_dontneed(start, end)) {
         ret = get_errno(madvise(g2h_untagged(start), len, MADV_DONTNEED));
         if (ret == 0) {
-- 
2.37.3



  parent reply	other threads:[~2022-09-28 20:43 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 20:27 [PULL 00/37] Linux user for 7.2 patches Laurent Vivier
2022-09-28 20:27 ` [PULL 01/37] linux-user: use 'max' instead of 'qemu32' / 'qemu64' by default Laurent Vivier
2022-09-28 20:27 ` [PULL 02/37] linux-user: fix readlinkat handling with magic exe symlink Laurent Vivier
2022-09-28 20:27 ` [PULL 03/37] linux-user: Add missing signals in strace output Laurent Vivier
2022-09-28 20:27 ` [PULL 04/37] linux-user: Add missing clock_gettime64() syscall strace Laurent Vivier
2022-09-28 20:27 ` [PULL 05/37] linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls Laurent Vivier
2022-09-28 20:27 ` [PULL 06/37] linux-user: Log failing executable in EXCP_DUMP() Laurent Vivier
2022-09-28 20:27 ` [PULL 07/37] linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info Laurent Vivier
2022-09-28 20:27 ` [PULL 08/37] linux-user/hppa: Dump IIR on register dump Laurent Vivier
2022-09-28 20:27 ` [PULL 09/37] linux-user: Fix strace of chmod() if mode == 0 Laurent Vivier
2022-09-28 20:27 ` [PULL 10/37] linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch Laurent Vivier
2022-09-28 20:27 ` [PULL 11/37] linux-user: Add strace for clock_nanosleep() Laurent Vivier
2022-09-28 20:27 ` [PULL 12/37] linux-user: Show timespec on strace for futex() Laurent Vivier
2022-09-28 20:27 ` [PULL 13/37] linux-user: Provide MADV_* definitions Laurent Vivier
2022-09-28 20:27 ` Laurent Vivier [this message]
2022-09-28 20:27 ` [PULL 15/37] linux-user: Implement stracing madvise() Laurent Vivier
2022-09-28 20:27 ` [PULL 16/37] linux-user: Passthrough MADV_DONTNEED for certain file mappings Laurent Vivier
2022-09-28 20:27 ` [PULL 17/37] tests/tcg/linux-test: Add linux-madvise test Laurent Vivier
2022-09-28 20:27 ` [PULL 18/37] linux-user: Fix TARGET_PROT_SEM for XTENSA Laurent Vivier
2022-09-28 20:27 ` [PULL 19/37] linux-user: Add proper strace format strings for getdents()/getdents64() Laurent Vivier
2022-09-28 20:27 ` [PULL 20/37] linux-user/hppa: Add signal trampoline for hppa target Laurent Vivier
2022-09-28 20:27 ` [PULL 21/37] linux-user/hppa: Drop stack guard page on " Laurent Vivier
2022-09-28 20:27 ` [PULL 22/37] linux-user/hppa: Increase guest stack size to 80MB for " Laurent Vivier
2022-09-28 20:27 ` [PULL 23/37] linux-user/hppa: Allow PROT_GROWSUP and PROT_GROWSDOWN in mprotect() Laurent Vivier
2022-09-28 20:27 ` [PULL 24/37] linux-user/hppa: Fix setup_sigcontext() Laurent Vivier
2022-09-28 20:27 ` [PULL 25/37] linux-user: fix bug about missing signum convert of sigqueue Laurent Vivier
2022-09-28 20:27 ` [PULL 26/37] linux-user: Don't assume 0 is not a valid host timer_t value Laurent Vivier
2022-09-28 20:27 ` [PULL 27/37] linux-user/s390x: Save/restore fpc when handling a signal Laurent Vivier
2022-09-28 20:27 ` [PULL 28/37] linux-user: Introduce stubs for ELF AT_BASE_PLATFORM Laurent Vivier
2022-09-28 20:27 ` [PULL 29/37] linux-user: Set ELF_BASE_PLATFORM for MIPS Laurent Vivier
2022-09-28 20:27 ` [PULL 30/37] linux-user: Combine do_futex and do_futex_time64 Laurent Vivier
2022-09-28 20:27 ` [PULL 31/37] linux-user: Sink call to do_safe_futex Laurent Vivier
2022-09-28 20:27 ` [PULL 32/37] linux-user: Implement FUTEX_WAKE_BITSET Laurent Vivier
2022-09-28 20:27 ` [PULL 33/37] linux-user: Convert signal number for FUTEX_FD Laurent Vivier
2022-09-28 20:27 ` [PULL 34/37] linux-user: Implement PI futexes Laurent Vivier
2022-09-28 20:27 ` [PULL 35/37] linux-user: Update print_futex_op Laurent Vivier
2022-09-28 20:27 ` [PULL 36/37] linux-user: Lock log around strace Laurent Vivier
2022-09-28 20:27 ` [PULL 37/37] linux-user: Add parameters of getrandom() syscall for strace Laurent Vivier
2022-09-29 14:48 ` [PULL 00/37] Linux user for 7.2 patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928202737.793171-15-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=iii@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).