qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>, Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 04/37] linux-user: Add missing clock_gettime64() syscall strace
Date: Wed, 28 Sep 2022 22:27:04 +0200	[thread overview]
Message-ID: <20220928202737.793171-5-laurent@vivier.eu> (raw)
In-Reply-To: <20220928202737.793171-1-laurent@vivier.eu>

From: Helge Deller <deller@gmx.de>

Allow linux-user to strace the clock_gettime64() syscall.
This syscall is used a lot on 32-bit guest architectures which use newer
glibc versions.

Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220918194555.83535-3-deller@gmx.de>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/strace.c    | 53 ++++++++++++++++++++++++++++++++++++++++++
 linux-user/strace.list |  4 ++++
 2 files changed, 57 insertions(+)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index a4eeef7ae1ca..816e67999539 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -82,6 +82,7 @@ UNUSED static void print_buf(abi_long addr, abi_long len, int last);
 UNUSED static void print_raw_param(const char *, abi_long, int);
 UNUSED static void print_timeval(abi_ulong, int);
 UNUSED static void print_timespec(abi_ulong, int);
+UNUSED static void print_timespec64(abi_ulong, int);
 UNUSED static void print_timezone(abi_ulong, int);
 UNUSED static void print_itimerval(abi_ulong, int);
 UNUSED static void print_number(abi_long, int);
@@ -795,6 +796,24 @@ print_syscall_ret_clock_gettime(CPUArchState *cpu_env, const struct syscallname
 #define print_syscall_ret_clock_getres     print_syscall_ret_clock_gettime
 #endif
 
+#if defined(TARGET_NR_clock_gettime64)
+static void
+print_syscall_ret_clock_gettime64(CPUArchState *cpu_env, const struct syscallname *name,
+                                abi_long ret, abi_long arg0, abi_long arg1,
+                                abi_long arg2, abi_long arg3, abi_long arg4,
+                                abi_long arg5)
+{
+    if (!print_syscall_err(ret)) {
+        qemu_log(TARGET_ABI_FMT_ld, ret);
+        qemu_log(" (");
+        print_timespec64(arg1, 1);
+        qemu_log(")");
+    }
+
+    qemu_log("\n");
+}
+#endif
+
 #ifdef TARGET_NR_gettimeofday
 static void
 print_syscall_ret_gettimeofday(CPUArchState *cpu_env, const struct syscallname *name,
@@ -1652,6 +1671,27 @@ print_timespec(abi_ulong ts_addr, int last)
     }
 }
 
+static void
+print_timespec64(abi_ulong ts_addr, int last)
+{
+    if (ts_addr) {
+        struct target__kernel_timespec *ts;
+
+        ts = lock_user(VERIFY_READ, ts_addr, sizeof(*ts), 1);
+        if (!ts) {
+            print_pointer(ts_addr, last);
+            return;
+        }
+        qemu_log("{tv_sec = %lld"
+                 ",tv_nsec = %lld}%s",
+                 (long long)tswap64(ts->tv_sec), (long long)tswap64(ts->tv_nsec),
+                 get_comma(last));
+        unlock_user(ts, ts_addr, 0);
+    } else {
+        qemu_log("NULL%s", get_comma(last));
+    }
+}
+
 static void
 print_timezone(abi_ulong tz_addr, int last)
 {
@@ -2267,6 +2307,19 @@ print_clock_gettime(CPUArchState *cpu_env, const struct syscallname *name,
 #define print_clock_getres     print_clock_gettime
 #endif
 
+#if defined(TARGET_NR_clock_gettime64)
+static void
+print_clock_gettime64(CPUArchState *cpu_env, const struct syscallname *name,
+                    abi_long arg0, abi_long arg1, abi_long arg2,
+                    abi_long arg3, abi_long arg4, abi_long arg5)
+{
+    print_syscall_prologue(name);
+    print_enums(clockids, arg0, 0);
+    print_pointer(arg1, 1);
+    print_syscall_epilogue(name);
+}
+#endif
+
 #ifdef TARGET_NR_clock_settime
 static void
 print_clock_settime(CPUArchState *cpu_env, const struct syscallname *name,
diff --git a/linux-user/strace.list b/linux-user/strace.list
index 72e17b1acf00..a78cdf3cdfef 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -1676,3 +1676,7 @@
 #ifdef TARGET_NR_copy_file_range
 { TARGET_NR_copy_file_range, "copy_file_range", "%s(%d,%p,%d,%p,"TARGET_ABI_FMT_lu",%u)", NULL, NULL },
 #endif
+#ifdef TARGET_NR_clock_gettime64
+{ TARGET_NR_clock_gettime64, "clock_gettime64" , NULL, print_clock_gettime64,
+                           print_syscall_ret_clock_gettime64 },
+#endif
-- 
2.37.3



  parent reply	other threads:[~2022-09-28 20:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 20:27 [PULL 00/37] Linux user for 7.2 patches Laurent Vivier
2022-09-28 20:27 ` [PULL 01/37] linux-user: use 'max' instead of 'qemu32' / 'qemu64' by default Laurent Vivier
2022-09-28 20:27 ` [PULL 02/37] linux-user: fix readlinkat handling with magic exe symlink Laurent Vivier
2022-09-28 20:27 ` [PULL 03/37] linux-user: Add missing signals in strace output Laurent Vivier
2022-09-28 20:27 ` Laurent Vivier [this message]
2022-09-28 20:27 ` [PULL 05/37] linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls Laurent Vivier
2022-09-28 20:27 ` [PULL 06/37] linux-user: Log failing executable in EXCP_DUMP() Laurent Vivier
2022-09-28 20:27 ` [PULL 07/37] linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info Laurent Vivier
2022-09-28 20:27 ` [PULL 08/37] linux-user/hppa: Dump IIR on register dump Laurent Vivier
2022-09-28 20:27 ` [PULL 09/37] linux-user: Fix strace of chmod() if mode == 0 Laurent Vivier
2022-09-28 20:27 ` [PULL 10/37] linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch Laurent Vivier
2022-09-28 20:27 ` [PULL 11/37] linux-user: Add strace for clock_nanosleep() Laurent Vivier
2022-09-28 20:27 ` [PULL 12/37] linux-user: Show timespec on strace for futex() Laurent Vivier
2022-09-28 20:27 ` [PULL 13/37] linux-user: Provide MADV_* definitions Laurent Vivier
2022-09-28 20:27 ` [PULL 14/37] linux-user: Fix madvise(MADV_DONTNEED) on alpha Laurent Vivier
2022-09-28 20:27 ` [PULL 15/37] linux-user: Implement stracing madvise() Laurent Vivier
2022-09-28 20:27 ` [PULL 16/37] linux-user: Passthrough MADV_DONTNEED for certain file mappings Laurent Vivier
2022-09-28 20:27 ` [PULL 17/37] tests/tcg/linux-test: Add linux-madvise test Laurent Vivier
2022-09-28 20:27 ` [PULL 18/37] linux-user: Fix TARGET_PROT_SEM for XTENSA Laurent Vivier
2022-09-28 20:27 ` [PULL 19/37] linux-user: Add proper strace format strings for getdents()/getdents64() Laurent Vivier
2022-09-28 20:27 ` [PULL 20/37] linux-user/hppa: Add signal trampoline for hppa target Laurent Vivier
2022-09-28 20:27 ` [PULL 21/37] linux-user/hppa: Drop stack guard page on " Laurent Vivier
2022-09-28 20:27 ` [PULL 22/37] linux-user/hppa: Increase guest stack size to 80MB for " Laurent Vivier
2022-09-28 20:27 ` [PULL 23/37] linux-user/hppa: Allow PROT_GROWSUP and PROT_GROWSDOWN in mprotect() Laurent Vivier
2022-09-28 20:27 ` [PULL 24/37] linux-user/hppa: Fix setup_sigcontext() Laurent Vivier
2022-09-28 20:27 ` [PULL 25/37] linux-user: fix bug about missing signum convert of sigqueue Laurent Vivier
2022-09-28 20:27 ` [PULL 26/37] linux-user: Don't assume 0 is not a valid host timer_t value Laurent Vivier
2022-09-28 20:27 ` [PULL 27/37] linux-user/s390x: Save/restore fpc when handling a signal Laurent Vivier
2022-09-28 20:27 ` [PULL 28/37] linux-user: Introduce stubs for ELF AT_BASE_PLATFORM Laurent Vivier
2022-09-28 20:27 ` [PULL 29/37] linux-user: Set ELF_BASE_PLATFORM for MIPS Laurent Vivier
2022-09-28 20:27 ` [PULL 30/37] linux-user: Combine do_futex and do_futex_time64 Laurent Vivier
2022-09-28 20:27 ` [PULL 31/37] linux-user: Sink call to do_safe_futex Laurent Vivier
2022-09-28 20:27 ` [PULL 32/37] linux-user: Implement FUTEX_WAKE_BITSET Laurent Vivier
2022-09-28 20:27 ` [PULL 33/37] linux-user: Convert signal number for FUTEX_FD Laurent Vivier
2022-09-28 20:27 ` [PULL 34/37] linux-user: Implement PI futexes Laurent Vivier
2022-09-28 20:27 ` [PULL 35/37] linux-user: Update print_futex_op Laurent Vivier
2022-09-28 20:27 ` [PULL 36/37] linux-user: Lock log around strace Laurent Vivier
2022-09-28 20:27 ` [PULL 37/37] linux-user: Add parameters of getrandom() syscall for strace Laurent Vivier
2022-09-29 14:48 ` [PULL 00/37] Linux user for 7.2 patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928202737.793171-5-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).