From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3BC3C04A95 for ; Thu, 29 Sep 2022 07:48:39 +0000 (UTC) Received: from localhost ([::1]:60118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odoHe-0002Bo-Uo for qemu-devel@archiver.kernel.org; Thu, 29 Sep 2022 03:48:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odnjf-0003Hf-Kc for qemu-devel@nongnu.org; Thu, 29 Sep 2022 03:13:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odnjb-0003p7-9p for qemu-devel@nongnu.org; Thu, 29 Sep 2022 03:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664435606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uidj0sWkcBhauPHgW1Mk2o9OcKlm6ghdzeFqOEIA57Q=; b=BmvG0yZm0Y209yWfZrheZljNBwgC5d0c7nvVpAhEPaEqXms836AZUc53uwJ1ZDoxA9QiUg bR4ni0IAhXP5TjR4mrMqMNFe3oyfDkQn3lssQidxnM2zZnhmEqRFL1x6rt22m7H67Wek28 +McrOXfArTwNDc7Ov790eAgQQeHus9w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-98-sE2CpdoQMmOR5zk8Xg8W9g-1; Thu, 29 Sep 2022 03:13:17 -0400 X-MC-Unique: sE2CpdoQMmOR5zk8Xg8W9g-1 Received: by mail-wm1-f72.google.com with SMTP id d5-20020a05600c34c500b003b4fb42ccdeso2553063wmq.8 for ; Thu, 29 Sep 2022 00:13:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=uidj0sWkcBhauPHgW1Mk2o9OcKlm6ghdzeFqOEIA57Q=; b=NvkX4x17XgD/s1C26/7KSNJt5ec6NvAN2oWMLnKx89mJlGqnGcuo1LDtC8HwOKY1hA 6RbJuvJ2SuzfKLGCKeciRviuFVKqDMEAtoA94zhe3E/G97Hweyi331f/2cm5xmeP9fnQ x/vpPJ9iIY87heW7rSTPEvUkOoxCHvz9L3ZXEmaEIuZN1szAbaaZZb75F7Q4Cua3FSjf PnOYbMJwPApZ9e7CQMKjqRT2HFA+9LvXxeZD24MylunVFf8rueiOIK7hvcynA+C/o8Yb HkVmBHiFxTB9nbe4GFU/GatdQA6IPxGk59Px9sOI3fpwNkNnPZrWJBP77gDetf4WjggS basg== X-Gm-Message-State: ACrzQf0EKJnUI1DFxR3RyYekqMQSIA+GcWBzEwSfJ8gSp91Ioe7HgwpF cRQOl7kfA/Bwy/XSf2KV0l4RWY4I1Q3DmJdkZuir0fTHUBvMpwG5/c5KPJTmVcDzoql3XVoX/Zx UXauEMJQ2L61MxB0= X-Received: by 2002:a5d:650e:0:b0:228:b09e:de9a with SMTP id x14-20020a5d650e000000b00228b09ede9amr1139852wru.360.1664435595705; Thu, 29 Sep 2022 00:13:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM510xK7NyhtUXYuJO7C2rpx5NBEgckrHo67IdQ2j6kTBtkfmJI6teayZ9i6nzF+rio3xN0DjA== X-Received: by 2002:a5d:650e:0:b0:228:b09e:de9a with SMTP id x14-20020a5d650e000000b00228b09ede9amr1139827wru.360.1664435595445; Thu, 29 Sep 2022 00:13:15 -0700 (PDT) Received: from redhat.com ([2.55.47.213]) by smtp.gmail.com with ESMTPSA id f2-20020adff982000000b0022afedf3c87sm5782220wrr.105.2022.09.29.00.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 00:13:14 -0700 (PDT) Date: Thu, 29 Sep 2022 03:13:10 -0400 From: "Michael S. Tsirkin" To: Si-Wei Liu Cc: Eugenio Perez Martin , Jason Wang , qemu-devel , Paolo Bonzini , Harpreet Singh Anand , Cindy Lu , Liuxiangdong , Stefano Garzarella , Zhu Lingshan , Gautam Dawar , Eli Cohen , "Gonglei (Arei)" , Laurent Vivier , Cornelia Huck , Stefan Hajnoczi , Parav Pandit Subject: Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup Message-ID: <20220929031210-mutt-send-email-mst@kernel.org> References: <20220906163621.1144675-3-eperezma@redhat.com> <34969f96-b7c4-c9f8-2248-3e84a84148b2@oracle.com> <411586c9-22a2-1bd5-fbcd-a7658fd00446@oracle.com> <5c5ad692-7162-ec05-cf40-dffa310706c8@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c5ad692-7162-ec05-cf40-dffa310706c8@oracle.com> Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 21, 2022 at 04:00:58PM -0700, Si-Wei Liu wrote: > > > > The spec doesn't explicitly say anything about that > > > > as far as I see. > > > Here the spec is totally ruled by the (software artifact of) > > > implementation rather than what a real device is expected to work with > > > VLAN rx filters. Are we sure we'd stick to this flawed device > > > implementation? The guest driver seems to be agnostic with this broken > > > spec behavior so far, and I am afraid it's an overkill to add another > > > feature bit or ctrl command to VLAN filter in clean way. > > > > > I agree with all of the above. So, double checking, all vlan should be > > allowed by default at device start? > That is true only when VIRTIO_NET_F_CTRL_VLAN is not negotiated. If the > guest already negotiated VIRTIO_NET_F_CTRL_VLAN before being migrated, > device should resume with all VLANs filtered/disallowed. > > > Maybe the spec needs to be more > > clear in that regard? > Yes, I think this is crucial. Otherwise we can't get consistent behavior, > either from software to vDPA, or cross various vDPA vendors. OK. Can you open a github issue for the spec? We'll try to address. Also, is it ok if we make it a SHOULD, i.e. best effort filtering? -- MST