qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: den@virtuozzo.com, michael.roth@amd.com, kkostiuk@redhat.com
Subject: [PATCH 7/7] qga: Add HW address getting for FreeBSD
Date: Thu, 29 Sep 2022 09:52:39 +0200	[thread overview]
Message-ID: <20220929075239.1675374-8-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20220929075239.1675374-1-alexander.ivanov@virtuozzo.com>

Replace a dumb function in commands-bsd.c by the code of HW address
getting.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 qga/commands-bsd.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/qga/commands-bsd.c b/qga/commands-bsd.c
index ca81114171..f9997ee1ec 100644
--- a/qga/commands-bsd.c
+++ b/qga/commands-bsd.c
@@ -20,6 +20,8 @@
 #include <sys/param.h>
 #include <sys/ucred.h>
 #include <sys/mount.h>
+#include <net/if_dl.h>
+#include <net/ethernet.h>
 #include <paths.h>
 
 #if defined(CONFIG_FSFREEZE) || defined(CONFIG_FSTRIM)
@@ -178,10 +180,15 @@ GuestCpuStatsList *qmp_guest_get_cpustats(Error **errp)
  */
 int guest_get_hw_addr(struct ifaddrs *ifa, unsigned char *buf, Error **errp)
 {
-    /*
-     * We can't get the hw addr of this interface,
-     * but that's not a fatal error.
-     */
-    return 0;
+    struct sockaddr_dl *sdp;
+
+    if (ifa->ifa_addr->sa_family != AF_LINK) {
+        /* We can get HW address only for AF_LINK family */
+        g_debug("failed to get MAC address of %s", ifa->ifa_name);
+        return 0;
+    }
+    sdp = (struct sockaddr_dl *)ifa->ifa_addr;
+    memcpy(buf, sdp->sdl_data + sdp->sdl_nlen, ETHER_ADDR_LEN);
+    return 1;
 }
 #endif /* HAVE_GETIFADDRS */
-- 
2.34.1



  parent reply	other threads:[~2022-09-29  7:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  7:52 [PATCH v2 0/7] qga: Add FreeBSD support Alexander Ivanov
2022-09-29  7:52 ` [PATCH 1/7] qga: Add initial " Alexander Ivanov
2022-09-29 11:29   ` Marc-André Lureau
2022-09-29 14:11     ` Alexander Ivanov
2022-09-29  7:52 ` [PATCH 2/7] qga: Move Linux-specific FS freeze/thaw code to a separate file Alexander Ivanov
2022-09-29 11:29   ` Marc-André Lureau
2022-09-29  7:52 ` [PATCH 3/7] qga: Add UFS freeze/thaw support for FreeBSD Alexander Ivanov
2022-09-29 11:28   ` Marc-André Lureau
2022-09-29  7:52 ` [PATCH 4/7] qga: Add shutdown/halt/reboot " Alexander Ivanov
2022-09-29 11:28   ` Marc-André Lureau
2022-09-29  7:52 ` [PATCH 5/7] qga: Add support for user password setting in FreeBSD Alexander Ivanov
2022-09-29 11:22   ` Marc-André Lureau
2022-09-29 14:29     ` Alexander Ivanov
2022-09-30  8:19       ` Marc-André Lureau
2022-09-30 13:11         ` Alexander Ivanov
2022-09-29  7:52 ` [PATCH 6/7] qga: Move HW address getting to a separate function Alexander Ivanov
2022-09-29 11:28   ` Marc-André Lureau
2022-09-29 14:33     ` Alexander Ivanov
2022-09-29  7:52 ` Alexander Ivanov [this message]
2022-09-29 11:28   ` [PATCH 7/7] qga: Add HW address getting for FreeBSD Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220929075239.1675374-8-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=kkostiuk@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).