qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
	aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com,
	crosa@redhat.com, minyihh@uci.edu, ma.mandourr@gmail.com,
	Luke.Craig@ll.mit.edu, cota@braap.org,
	aaron@os.amperecomputing.com, kuhn.chenqun@huawei.com,
	robhenry@microsoft.com, mahmoudabdalghany@outlook.com,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v1 25/51] configure: move tests/tcg/Makefile.prereqs to root build directory
Date: Thu, 29 Sep 2022 12:42:05 +0100	[thread overview]
Message-ID: <20220929114231.583801-26-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220929114231.583801-1-alex.bennee@linaro.org>

From: Paolo Bonzini <pbonzini@redhat.com>

It will not be specific to tests/tcg anymore, since it will be possible to
build firmware using container-based cross compilers too.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 configure              | 15 +++++++--------
 Makefile               |  5 ++++-
 tests/Makefile.include |  3 ---
 3 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/configure b/configure
index ceb1213292..cbeac99b2b 100755
--- a/configure
+++ b/configure
@@ -2185,6 +2185,7 @@ write_target_makefile() {
 }
 
 write_container_target_makefile() {
+  echo "$1: docker-image-$container_image" >> Makefile.prereqs
   echo "EXTRA_CFLAGS=$target_cflags"
   if test -n "$container_cross_cc"; then
     echo "CC=$docker_py cc --cc $container_cross_cc -i qemu/$container_image -s $source_path --"
@@ -2297,6 +2298,8 @@ for f in $LINKS ; do
     fi
 done
 
+echo "# Automatically generated by configure - do not modify" > Makefile.prereqs
+
 # Mac OS X ships with a broken assembler
 roms=
 if test "$targetos" != "darwin" && test "$targetos" != "sunos" && \
@@ -2524,10 +2527,7 @@ if test "$safe_stack" = "yes"; then
 fi
 
 # tests/tcg configuration
-(makefile=tests/tcg/Makefile.prereqs
-echo "# Automatically generated by configure - do not modify" > $makefile
-
-config_host_mak=tests/tcg/config-host.mak
+(config_host_mak=tests/tcg/config-host.mak
 mkdir -p tests/tcg
 echo "# Automatically generated by configure - do not modify" > $config_host_mak
 echo "SRC_PATH=$source_path" >> $config_host_mak
@@ -2565,8 +2565,7 @@ for target in $target_list; do
       write_target_makefile >> "$config_target_mak"
   elif test -n "$container_image"; then
       build_static=y
-      echo "build-tcg-tests-$target: docker-image-$container_image" >> $makefile
-      write_container_target_makefile >> "$config_target_mak"
+      write_container_target_makefile build-tcg-tests-$target >> "$config_target_mak"
       got_cross_cc=yes
   fi
   if test $got_cross_cc = yes; then
@@ -2576,11 +2575,11 @@ for target in $target_list; do
       echo "TARGET=$target" >> "$config_target_mak"
       echo "QEMU=$PWD/$qemu" >> "$config_target_mak"
       echo "BUILD_STATIC=$build_static" >> "$config_target_mak"
-      echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >> $makefile
+      echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >> Makefile.prereqs
       tcg_tests_targets="$tcg_tests_targets $target"
   fi
 done
-echo "TCG_TESTS_TARGETS=$tcg_tests_targets" >> $makefile)
+echo "TCG_TESTS_TARGETS=$tcg_tests_targets" >> config-host.mak)
 
 if test "$skip_meson" = no; then
   cross="config-meson.cross.new"
diff --git a/Makefile b/Makefile
index 0fcde48bec..357592ad39 100644
--- a/Makefile
+++ b/Makefile
@@ -42,6 +42,9 @@ configure: ;
 ifneq ($(wildcard config-host.mak),)
 include config-host.mak
 
+include Makefile.prereqs
+Makefile.prereqs: config-host.mak
+
 git-submodule-update:
 .git-submodule-status: git-submodule-update config-host.mak
 Makefile: .git-submodule-status
@@ -217,7 +220,7 @@ qemu-%.tar.bz2:
 
 distclean: clean recurse-distclean
 	-$(quiet-@)test -f build.ninja && $(NINJA) $(NINJAFLAGS) -t clean -g || :
-	rm -f config-host.mak qemu-bundle
+	rm -f config-host.mak Makefile.prereqs qemu-bundle
 	rm -f tests/tcg/config-*.mak
 	rm -f config.status
 	rm -f roms/seabios/config.mak
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 9ed67721e2..9422ddaece 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -36,9 +36,6 @@ export SRC_PATH
 
 SPEED = quick
 
--include tests/tcg/Makefile.prereqs
-tests/tcg/Makefile.prereqs: config-host.mak
-
 # Per guest TCG tests
 BUILD_TCG_TARGET_RULES=$(patsubst %,build-tcg-tests-%, $(TCG_TESTS_TARGETS))
 CLEAN_TCG_TARGET_RULES=$(patsubst %,clean-tcg-tests-%, $(TCG_TESTS_TARGETS))
-- 
2.34.1



  parent reply	other threads:[~2022-09-29 14:00 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 11:41 [PATCH v1 00/51] maintainer pre-PR (testing, plugins, gitdm, semihosting) Alex Bennée
2022-09-29 11:41 ` [PATCH v1 01/51] scripts/ci/setup: ninja missing from build-environment Alex Bennée
2022-09-29 11:41 ` [PATCH v1 02/51] scripts/ci/setup: Fix libxen requirements Alex Bennée
2022-09-29 11:41 ` [PATCH v1 03/51] scripts/ci/setup: spice-server only on x86 aarch64 Alex Bennée
2022-09-29 11:41 ` [PATCH v1 04/51] tests/docker: run script use realpath instead of readlink Alex Bennée
2022-09-29 11:41 ` [PATCH v1 05/51] configure: move detected gdb to TCG's config-host.mak Alex Bennée
2022-09-29 11:41 ` [PATCH v1 06/51] target/hexagon: add flex/bison/glib2 to qemu.yml Alex Bennée
2022-09-29 11:41 ` [PATCH v1 07/51] target/hexagon: regenerate docker/cirrus files Alex Bennée
2022-09-29 11:41 ` [PATCH v1 08/51] target/hexagon: manually add flex/bison/glib2 to remaining containers Alex Bennée
2022-09-29 11:41 ` [PATCH v1 09/51] tests/docker: update fedora-win[32|64]-cross with lcitool Alex Bennée
2022-09-29 11:41 ` [PATCH v1 10/51] tests/docker: move alpine from edge to tagged release Alex Bennée
2022-09-29 11:41 ` [PATCH v1 11/51] tests/qtest: bump up QOS_PATH_MAX_ELEMENT_SIZE Alex Bennée
2022-09-29 11:41 ` [PATCH v1 12/51] configure: do not invoke as/ld directly for pc-bios/optionrom Alex Bennée
2022-09-29 11:41 ` [PATCH v1 13/51] pc-bios/optionrom: detect CC options just once Alex Bennée
2022-09-29 11:41 ` [PATCH v1 14/51] pc-bios/s390-ccw: " Alex Bennée
2022-09-29 11:41 ` [PATCH v1 15/51] vof: add distclean target Alex Bennée
2022-09-29 14:36   ` BALATON Zoltan
2022-09-29 16:25     ` Alex Bennée
2022-09-29 16:45     ` Alex Bennée
2022-09-29 11:41 ` [PATCH v1 16/51] build: add recursive distclean rules Alex Bennée
2022-09-29 11:41 ` [PATCH v1 17/51] configure: return status code from probe_target_compiler Alex Bennée
2022-09-29 11:41 ` [PATCH v1 18/51] configure: store container engine in config-host.mak Alex Bennée
2022-09-29 11:41 ` [PATCH v1 19/51] tests: simplify Makefile invocation for tests/tcg Alex Bennée
2022-09-29 11:42 ` [PATCH v1 20/51] tests/tcg: remove -f from Makefile invocation Alex Bennée
2022-09-29 11:42 ` [PATCH v1 21/51] tests/tcg: add distclean rule Alex Bennée
2022-09-29 11:42 ` [PATCH v1 22/51] tests/tcg: unify ppc64 and ppc64le Makefiles Alex Bennée
2022-09-29 11:42 ` [PATCH v1 23/51] tests/tcg: clean up calls to run-test Alex Bennée
2022-09-29 11:42 ` [PATCH v1 24/51] tests/tcg: move compiler tests to Makefiles Alex Bennée
2022-09-29 11:42 ` Alex Bennée [this message]
2022-09-29 11:42 ` [PATCH v1 26/51] configure: unify creation of cross-compilation Makefiles Alex Bennée
2022-09-29 11:42 ` [PATCH v1 27/51] configure: cleanup creation of tests/tcg target config Alex Bennée
2022-09-29 11:42 ` [PATCH v1 28/51] configure: build ROMs with container-based cross compilers Alex Bennée
2022-09-29 11:42 ` [PATCH v1 29/51] pc-bios/optionrom: Adopt meson style Make output Alex Bennée
2022-09-29 11:42 ` [PATCH v1 30/51] pc-bios/s390-ccw: " Alex Bennée
2022-09-29 11:42 ` [PATCH v1 31/51] pc-bios/vof: " Alex Bennée
2022-09-29 11:42 ` [PATCH v1 32/51] monitor: expose monitor_puts to rest of code Alex Bennée
2022-09-29 11:42 ` [PATCH v1 33/51] disas: generalise plugin_printf and use for monitor_disas Alex Bennée
2022-09-29 11:42 ` [PATCH v1 34/51] disas: use result of ->read_memory_func Alex Bennée
2022-09-29 11:42 ` [PATCH v1 35/51] plugins: extend execlog to filter matches Alex Bennée
2022-09-29 11:42 ` [PATCH v1 36/51] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr Alex Bennée
2022-09-29 11:42 ` [PATCH v1 37/51] docs/devel: clean-up qemu invocations in tcg-plugins Alex Bennée
2022-09-29 11:42 ` [PATCH v1 38/51] docs/devel: move API to end of tcg-plugins.rst Alex Bennée
2022-09-29 11:42 ` [PATCH v1 39/51] contrib/plugins: reset skip when matching in execlog Alex Bennée
2022-09-29 11:42 ` [PATCH v1 40/51] docs/devel: document the test plugins Alex Bennée
2022-09-29 11:42 ` [PATCH v1 41/51] semihosting: update link to spec Alex Bennée
2022-09-29 11:42 ` [PATCH v1 42/51] gdbstub: move into its own sub directory Alex Bennée
2022-09-29 11:42 ` [PATCH v1 43/51] gdbstub: move sstep flags probing into AccelClass Alex Bennée
2022-09-29 11:42 ` [PATCH v1 44/51] gdbstub: move breakpoint logic to accel ops Alex Bennée
2022-09-29 11:42 ` [PATCH v1 45/51] gdbstub: move guest debug support check to ops Alex Bennée
2022-09-29 11:42 ` [PATCH v1 46/51] accel/kvm: move kvm_update_guest_debug to inline stub Alex Bennée
2022-09-29 11:42 ` [PATCH v1 47/51] contrib/gitdm: add mapping for Loongson Technology Alex Bennée
2022-09-29 11:42 ` [PATCH v1 48/51] contrib/gitdm: add Paul to individual contributors Alex Bennée
2022-09-29 11:42 ` [PATCH v1 49/51] contrib/gitdm: add WANG Xuerui to individual contributers Alex Bennée
2022-09-29 11:42 ` [PATCH v1 50/51] contrib/gitdm: add ISCAS to the academics group Alex Bennée
2022-09-29 11:42 ` [PATCH v1 51/51] contrib/gitdm: add China Telecom to the domain map Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220929114231.583801-26-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Luke.Craig@ll.mit.edu \
    --cc=aaron@os.amperecomputing.com \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=kuhn.chenqun@huawei.com \
    --cc=ma.mandourr@gmail.com \
    --cc=mahmoudabdalghany@outlook.com \
    --cc=minyihh@uci.edu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=robhenry@microsoft.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).