From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com,
crosa@redhat.com, minyihh@uci.edu, ma.mandourr@gmail.com,
Luke.Craig@ll.mit.edu, cota@braap.org,
aaron@os.amperecomputing.com, kuhn.chenqun@huawei.com,
robhenry@microsoft.com, mahmoudabdalghany@outlook.com,
"Richard Henderson" <richard.henderson@linaro.org>,
"Damien Hedde" <damien.hedde@greensocs.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>
Subject: [PATCH v1 36/51] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr
Date: Thu, 29 Sep 2022 12:42:16 +0100 [thread overview]
Message-ID: <20220929114231.583801-37-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220929114231.583801-1-alex.bennee@linaro.org>
From: Richard Henderson <richard.henderson@linaro.org>
Coverity reports out-of-bound accesses here. This should be a
false positive due to how the index is decoded from MemOpIdx.
Fixes: Coverity CID 1487201
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Message-Id: <20220401190233.329360-1-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220921160801.1490125-7-alex.bennee@linaro.org>
---
plugins/api.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/plugins/api.c b/plugins/api.c
index 7bf71b189d..2078b16edb 100644
--- a/plugins/api.c
+++ b/plugins/api.c
@@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,
enum qemu_plugin_mem_rw rw = get_plugin_meminfo_rw(info);
hwaddr_info.is_store = (rw & QEMU_PLUGIN_MEM_W) != 0;
+ assert(mmu_idx < NB_MMU_MODES);
+
if (!tlb_plugin_lookup(cpu, vaddr, mmu_idx,
hwaddr_info.is_store, &hwaddr_info)) {
error_report("invalid use of qemu_plugin_get_hwaddr");
--
2.34.1
next prev parent reply other threads:[~2022-09-29 13:33 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:41 [PATCH v1 00/51] maintainer pre-PR (testing, plugins, gitdm, semihosting) Alex Bennée
2022-09-29 11:41 ` [PATCH v1 01/51] scripts/ci/setup: ninja missing from build-environment Alex Bennée
2022-09-29 11:41 ` [PATCH v1 02/51] scripts/ci/setup: Fix libxen requirements Alex Bennée
2022-09-29 11:41 ` [PATCH v1 03/51] scripts/ci/setup: spice-server only on x86 aarch64 Alex Bennée
2022-09-29 11:41 ` [PATCH v1 04/51] tests/docker: run script use realpath instead of readlink Alex Bennée
2022-09-29 11:41 ` [PATCH v1 05/51] configure: move detected gdb to TCG's config-host.mak Alex Bennée
2022-09-29 11:41 ` [PATCH v1 06/51] target/hexagon: add flex/bison/glib2 to qemu.yml Alex Bennée
2022-09-29 11:41 ` [PATCH v1 07/51] target/hexagon: regenerate docker/cirrus files Alex Bennée
2022-09-29 11:41 ` [PATCH v1 08/51] target/hexagon: manually add flex/bison/glib2 to remaining containers Alex Bennée
2022-09-29 11:41 ` [PATCH v1 09/51] tests/docker: update fedora-win[32|64]-cross with lcitool Alex Bennée
2022-09-29 11:41 ` [PATCH v1 10/51] tests/docker: move alpine from edge to tagged release Alex Bennée
2022-09-29 11:41 ` [PATCH v1 11/51] tests/qtest: bump up QOS_PATH_MAX_ELEMENT_SIZE Alex Bennée
2022-09-29 11:41 ` [PATCH v1 12/51] configure: do not invoke as/ld directly for pc-bios/optionrom Alex Bennée
2022-09-29 11:41 ` [PATCH v1 13/51] pc-bios/optionrom: detect CC options just once Alex Bennée
2022-09-29 11:41 ` [PATCH v1 14/51] pc-bios/s390-ccw: " Alex Bennée
2022-09-29 11:41 ` [PATCH v1 15/51] vof: add distclean target Alex Bennée
2022-09-29 14:36 ` BALATON Zoltan
2022-09-29 16:25 ` Alex Bennée
2022-09-29 16:45 ` Alex Bennée
2022-09-29 11:41 ` [PATCH v1 16/51] build: add recursive distclean rules Alex Bennée
2022-09-29 11:41 ` [PATCH v1 17/51] configure: return status code from probe_target_compiler Alex Bennée
2022-09-29 11:41 ` [PATCH v1 18/51] configure: store container engine in config-host.mak Alex Bennée
2022-09-29 11:41 ` [PATCH v1 19/51] tests: simplify Makefile invocation for tests/tcg Alex Bennée
2022-09-29 11:42 ` [PATCH v1 20/51] tests/tcg: remove -f from Makefile invocation Alex Bennée
2022-09-29 11:42 ` [PATCH v1 21/51] tests/tcg: add distclean rule Alex Bennée
2022-09-29 11:42 ` [PATCH v1 22/51] tests/tcg: unify ppc64 and ppc64le Makefiles Alex Bennée
2022-09-29 11:42 ` [PATCH v1 23/51] tests/tcg: clean up calls to run-test Alex Bennée
2022-09-29 11:42 ` [PATCH v1 24/51] tests/tcg: move compiler tests to Makefiles Alex Bennée
2022-09-29 11:42 ` [PATCH v1 25/51] configure: move tests/tcg/Makefile.prereqs to root build directory Alex Bennée
2022-09-29 11:42 ` [PATCH v1 26/51] configure: unify creation of cross-compilation Makefiles Alex Bennée
2022-09-29 11:42 ` [PATCH v1 27/51] configure: cleanup creation of tests/tcg target config Alex Bennée
2022-09-29 11:42 ` [PATCH v1 28/51] configure: build ROMs with container-based cross compilers Alex Bennée
2022-09-29 11:42 ` [PATCH v1 29/51] pc-bios/optionrom: Adopt meson style Make output Alex Bennée
2022-09-29 11:42 ` [PATCH v1 30/51] pc-bios/s390-ccw: " Alex Bennée
2022-09-29 11:42 ` [PATCH v1 31/51] pc-bios/vof: " Alex Bennée
2022-09-29 11:42 ` [PATCH v1 32/51] monitor: expose monitor_puts to rest of code Alex Bennée
2022-09-29 11:42 ` [PATCH v1 33/51] disas: generalise plugin_printf and use for monitor_disas Alex Bennée
2022-09-29 11:42 ` [PATCH v1 34/51] disas: use result of ->read_memory_func Alex Bennée
2022-09-29 11:42 ` [PATCH v1 35/51] plugins: extend execlog to filter matches Alex Bennée
2022-09-29 11:42 ` Alex Bennée [this message]
2022-09-29 11:42 ` [PATCH v1 37/51] docs/devel: clean-up qemu invocations in tcg-plugins Alex Bennée
2022-09-29 11:42 ` [PATCH v1 38/51] docs/devel: move API to end of tcg-plugins.rst Alex Bennée
2022-09-29 11:42 ` [PATCH v1 39/51] contrib/plugins: reset skip when matching in execlog Alex Bennée
2022-09-29 11:42 ` [PATCH v1 40/51] docs/devel: document the test plugins Alex Bennée
2022-09-29 11:42 ` [PATCH v1 41/51] semihosting: update link to spec Alex Bennée
2022-09-29 11:42 ` [PATCH v1 42/51] gdbstub: move into its own sub directory Alex Bennée
2022-09-29 11:42 ` [PATCH v1 43/51] gdbstub: move sstep flags probing into AccelClass Alex Bennée
2022-09-29 11:42 ` [PATCH v1 44/51] gdbstub: move breakpoint logic to accel ops Alex Bennée
2022-09-29 11:42 ` [PATCH v1 45/51] gdbstub: move guest debug support check to ops Alex Bennée
2022-09-29 11:42 ` [PATCH v1 46/51] accel/kvm: move kvm_update_guest_debug to inline stub Alex Bennée
2022-09-29 11:42 ` [PATCH v1 47/51] contrib/gitdm: add mapping for Loongson Technology Alex Bennée
2022-09-29 11:42 ` [PATCH v1 48/51] contrib/gitdm: add Paul to individual contributors Alex Bennée
2022-09-29 11:42 ` [PATCH v1 49/51] contrib/gitdm: add WANG Xuerui to individual contributers Alex Bennée
2022-09-29 11:42 ` [PATCH v1 50/51] contrib/gitdm: add ISCAS to the academics group Alex Bennée
2022-09-29 11:42 ` [PATCH v1 51/51] contrib/gitdm: add China Telecom to the domain map Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929114231.583801-37-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Luke.Craig@ll.mit.edu \
--cc=aaron@os.amperecomputing.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=crosa@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=erdnaxe@crans.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=kuhn.chenqun@huawei.com \
--cc=ma.mandourr@gmail.com \
--cc=mahmoudabdalghany@outlook.com \
--cc=minyihh@uci.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robhenry@microsoft.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).