From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, maz@kernel.org, eric.auger@redhat.com,
cohuck@redhat.com, zhenyzha@redhat.com,
richard.henderson@linaro.org, peter.maydell@linaro.org,
shan.gavin@gmail.com
Subject: [PATCH v4 3/6] hw/arm/virt: Introduce variable region_base in virt_set_high_memmap()
Date: Tue, 4 Oct 2022 08:26:24 +0800 [thread overview]
Message-ID: <20221004002627.59172-4-gshan@redhat.com> (raw)
In-Reply-To: <20221004002627.59172-1-gshan@redhat.com>
This introduces variable 'region_base' for the base address of the
specific high memory region. It's the preparatory work to optimize
high memory region address assignment.
No functional change intended.
Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
hw/arm/virt.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 187b3ee0e2..b0b679d1f4 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1692,15 +1692,15 @@ static uint64_t virt_cpu_mp_affinity(VirtMachineState *vms, int idx)
static void virt_set_high_memmap(VirtMachineState *vms,
hwaddr base, int pa_bits)
{
- hwaddr region_size;
+ hwaddr region_base, region_size;
bool fits;
int i;
for (i = VIRT_LOWMEMMAP_LAST; i < ARRAY_SIZE(extended_memmap); i++) {
+ region_base = ROUND_UP(base, extended_memmap[i].size);
region_size = extended_memmap[i].size;
- base = ROUND_UP(base, region_size);
- vms->memmap[i].base = base;
+ vms->memmap[i].base = region_base;
vms->memmap[i].size = region_size;
/*
@@ -1709,9 +1709,9 @@ static void virt_set_high_memmap(VirtMachineState *vms,
*
* For each device that doesn't fit, disable it.
*/
- fits = (base + region_size) <= BIT_ULL(pa_bits);
+ fits = (region_base + region_size) <= BIT_ULL(pa_bits);
if (fits) {
- vms->highest_gpa = base + region_size - 1;
+ vms->highest_gpa = region_base + region_size - 1;
}
switch (i) {
@@ -1726,7 +1726,7 @@ static void virt_set_high_memmap(VirtMachineState *vms,
break;
}
- base += region_size;
+ base = region_base + region_size;
}
}
--
2.23.0
next prev parent reply other threads:[~2022-10-04 0:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 0:26 [PATCH v4 0/6] hw/arm/virt: Improve address assignment for high memory regions Gavin Shan
2022-10-04 0:26 ` [PATCH v4 1/6] hw/arm/virt: Introduce virt_set_high_memmap() helper Gavin Shan
2022-10-04 0:26 ` [PATCH v4 2/6] hw/arm/virt: Rename variable size to region_size in virt_set_high_memmap() Gavin Shan
2022-10-04 10:15 ` Cornelia Huck
2022-10-04 0:26 ` Gavin Shan [this message]
2022-10-04 10:18 ` [PATCH v4 3/6] hw/arm/virt: Introduce variable region_base " Cornelia Huck
2022-10-04 0:26 ` [PATCH v4 4/6] hw/arm/virt: Introduce virt_get_high_memmap_enabled() helper Gavin Shan
2022-10-04 10:41 ` Cornelia Huck
2022-10-04 22:47 ` Gavin Shan
2022-10-11 16:45 ` Eric Auger
2022-10-11 23:06 ` Gavin Shan
2022-10-04 0:26 ` [PATCH v4 5/6] hw/arm/virt: Improve high memory region address Gavin Shan
2022-10-04 10:53 ` Cornelia Huck
2022-10-04 22:58 ` Gavin Shan
2022-10-04 0:26 ` [PATCH v4 6/6] hw/arm/virt: Add 'compact-highmem' property Gavin Shan
2022-10-04 17:39 ` Marc Zyngier
2022-10-04 23:33 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004002627.59172-4-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).