qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 17/54] configure: return status code from probe_target_compiler
Date: Tue,  4 Oct 2022 14:01:01 +0100	[thread overview]
Message-ID: <20221004130138.2299307-18-alex.bennee@linaro.org> (raw)
In-Reply-To: <20221004130138.2299307-1-alex.bennee@linaro.org>

From: Paolo Bonzini <pbonzini@redhat.com>

For now, return 1 for container-based compilers.  This will change as
soon as ROMs will be buildable with them.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220929114231.583801-18-alex.bennee@linaro.org>

diff --git a/configure b/configure
index aaa09fb957..f3984bb193 100755
--- a/configure
+++ b/configure
@@ -2147,6 +2147,7 @@ probe_target_compiler() {
     target_ranlib=
     target_strip=
   fi
+  test -n "$target_cc"
 }
 
 write_target_makefile() {
@@ -2294,10 +2295,9 @@ done
 
 # Mac OS X ships with a broken assembler
 roms=
-probe_target_compiler i386-softmmu
-if test -n "$target_cc" &&
-        test "$targetos" != "darwin" && test "$targetos" != "sunos" && \
-        test "$targetos" != "haiku" && test "$softmmu" = yes ; then
+if test "$targetos" != "darwin" && test "$targetos" != "sunos" && \
+        test "$targetos" != "haiku" && test "$softmmu" = yes && \
+        probe_target_compiler i386-softmmu; then
     roms="pc-bios/optionrom"
     config_mak=pc-bios/optionrom/config.mak
     echo "# Automatically generated by configure - do not modify" > $config_mak
@@ -2305,8 +2305,7 @@ if test -n "$target_cc" &&
     write_target_makefile >> $config_mak
 fi
 
-probe_target_compiler ppc-softmmu
-if test -n "$target_cc" && test "$softmmu" = yes; then
+if test "$softmmu" = yes && probe_target_compiler ppc-softmmu; then
     roms="$roms pc-bios/vof"
     config_mak=pc-bios/vof/config.mak
     echo "# Automatically generated by configure - do not modify" > $config_mak
@@ -2316,8 +2315,7 @@ fi
 
 # Only build s390-ccw bios if the compiler has -march=z900 or -march=z10
 # (which is the lowest architecture level that Clang supports)
-probe_target_compiler s390x-softmmu
-if test -n "$target_cc" && test "$softmmu" = yes; then
+if test "$softmmu" = yes && probe_target_compiler s390x-softmmu; then
   write_c_skeleton
   do_compiler "$target_cc" $target_cc_cflags -march=z900 -o $TMPO -c $TMPC
   has_z900=$?
-- 
2.34.1



  parent reply	other threads:[~2022-10-04 13:55 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 13:00 [PULL 00/54] testing, gdbstub, plugin and gitdm updates Alex Bennée
2022-10-04 13:00 ` [PULL 01/54] scripts/ci/setup: ninja missing from build-environment Alex Bennée
2022-10-04 13:00 ` [PULL 02/54] scripts/ci/setup: Fix libxen requirements Alex Bennée
2022-10-04 13:00 ` [PULL 03/54] scripts/ci/setup: spice-server only on x86 aarch64 Alex Bennée
2022-10-04 13:00 ` [PULL 04/54] tests/docker: run script use realpath instead of readlink Alex Bennée
2022-10-04 13:00 ` [PULL 05/54] configure: move detected gdb to TCG's config-host.mak Alex Bennée
2022-10-04 13:00 ` [PULL 06/54] target/hexagon: add flex/bison/glib2 to qemu.yml Alex Bennée
2022-10-04 13:00 ` [PULL 07/54] target/hexagon: regenerate docker/cirrus files Alex Bennée
2022-10-04 13:00 ` [PULL 08/54] target/hexagon: manually add flex/bison/glib2 to remaining containers Alex Bennée
2022-10-04 13:00 ` [PULL 09/54] tests/docker: update fedora-win[32|64]-cross with lcitool Alex Bennée
2022-10-04 13:00 ` [PULL 10/54] tests/docker: move alpine from edge to tagged release Alex Bennée
2022-10-04 13:00 ` [PULL 11/54] tests/qtest: bump up QOS_PATH_MAX_ELEMENT_SIZE Alex Bennée
2022-10-04 13:00 ` [PULL 12/54] configure: do not invoke as/ld directly for pc-bios/optionrom Alex Bennée
2022-10-04 13:00 ` [PULL 13/54] pc-bios/optionrom: detect CC options just once Alex Bennée
2022-10-04 13:00 ` [PULL 14/54] pc-bios/s390-ccw: " Alex Bennée
2022-10-04 13:00 ` [PULL 15/54] vof: add distclean target Alex Bennée
2022-10-04 13:01 ` [PULL 16/54] build: add recursive distclean rules Alex Bennée
2022-10-04 13:01 ` Alex Bennée [this message]
2022-10-04 13:01 ` [PULL 18/54] configure: store container engine in config-host.mak Alex Bennée
2022-10-04 13:01 ` [PULL 19/54] tests: simplify Makefile invocation for tests/tcg Alex Bennée
2022-10-04 13:01 ` [PULL 20/54] tests/tcg: remove -f from Makefile invocation Alex Bennée
2022-10-04 13:01 ` [PULL 21/54] tests/tcg: add distclean rule Alex Bennée
2022-10-04 13:01 ` [PULL 22/54] tests/tcg: unify ppc64 and ppc64le Makefiles Alex Bennée
2022-10-04 13:01 ` [PULL 23/54] tests/tcg: clean up calls to run-test Alex Bennée
2022-10-04 13:01 ` [PULL 24/54] tests/tcg: move compiler tests to Makefiles Alex Bennée
2022-10-04 13:01 ` [PULL 25/54] configure: move tests/tcg/Makefile.prereqs to root build directory Alex Bennée
2022-10-04 13:01 ` [PULL 26/54] configure: unify creation of cross-compilation Makefiles Alex Bennée
2022-10-06 20:33   ` Stefan Hajnoczi
2022-10-04 13:01 ` [PULL 27/54] configure: cleanup creation of tests/tcg target config Alex Bennée
2022-10-04 13:01 ` [PULL 28/54] configure: build ROMs with container-based cross compilers Alex Bennée
2022-10-06 20:37   ` Stefan Hajnoczi
2022-10-10 12:54   ` Daniel P. Berrangé
2022-10-10 13:07     ` Daniel P. Berrangé
2022-10-10 13:47     ` Alex Bennée
2022-10-04 13:01 ` [PULL 29/54] pc-bios/optionrom: Adopt meson style Make output Alex Bennée
2022-10-04 13:01 ` [PULL 30/54] pc-bios/s390-ccw: " Alex Bennée
2022-10-04 13:01 ` [PULL 31/54] pc-bios/vof: " Alex Bennée
2022-10-04 13:01 ` [PULL 32/54] monitor: expose monitor_puts to rest of code Alex Bennée
2022-10-04 13:01 ` [PULL 33/54] disas: generalise plugin_printf and use for monitor_disas Alex Bennée
2022-10-04 13:01 ` [PULL 34/54] disas: use result of ->read_memory_func Alex Bennée
2022-10-04 13:01 ` [PULL 35/54] plugins: extend execlog to filter matches Alex Bennée
2022-10-04 13:01 ` [PULL 36/54] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr Alex Bennée
2022-10-04 13:01 ` [PULL 37/54] docs/devel: clean-up qemu invocations in tcg-plugins Alex Bennée
2022-10-04 13:01 ` [PULL 38/54] docs/devel: move API to end of tcg-plugins.rst Alex Bennée
2022-10-04 13:01 ` [PULL 39/54] contrib/plugins: reset skip when matching in execlog Alex Bennée
2022-10-04 13:01 ` [PULL 40/54] docs/devel: document the test plugins Alex Bennée
2022-10-04 13:01 ` [PULL 41/54] semihosting: update link to spec Alex Bennée
2022-10-04 13:01 ` [PULL 42/54] gdbstub: move into its own sub directory Alex Bennée
2022-10-04 13:01 ` [PULL 43/54] gdbstub: move sstep flags probing into AccelClass Alex Bennée
2022-10-04 13:01 ` [PULL 44/54] gdbstub: move breakpoint logic to accel ops Alex Bennée
2022-10-04 13:01 ` [PULL 45/54] gdbstub: move guest debug support check to ops Alex Bennée
2022-10-04 13:01 ` [PULL 46/54] accel/kvm: move kvm_update_guest_debug to inline stub Alex Bennée
2022-10-04 13:01 ` [PULL 47/54] contrib/gitdm: add mapping for Loongson Technology Alex Bennée
2022-10-04 13:01 ` [PULL 48/54] contrib/gitdm: add Paul to individual contributors Alex Bennée
2022-10-04 13:01 ` [PULL 49/54] contrib/gitdm: add WANG Xuerui to individual contributers Alex Bennée
2022-10-04 13:01 ` [PULL 50/54] contrib/gitdm: add ISCAS to the academics group Alex Bennée
2022-10-04 13:01 ` [PULL 51/54] contrib/gitdm: add China Telecom to the domain map Alex Bennée
2022-10-04 13:01 ` [PULL 52/54] contrib/gitdm: add Simon to individual contributors Alex Bennée
2022-10-04 16:06   ` Simon Safar via
2022-10-04 13:01 ` [PULL 53/54] contrib/gitdm: add Université Grenoble Alpes Alex Bennée
2022-10-04 13:01 ` [PULL 54/54] plugins: add [pre|post]fork helpers to linux-user Alex Bennée
2022-10-05 14:16 ` [PULL 00/54] testing, gdbstub, plugin and gitdm updates Stefan Hajnoczi
2022-10-05 15:23   ` Alex Bennée
2022-10-05 23:17     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221004130138.2299307-18-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).