qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Jason Wang" <jasowang@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>, "Greg Kurz" <groug@kaod.org>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Stefano Brivio" <sbrivio@redhat.com>
Subject: [PATCH v10 07/17] net: socket: Don't ignore EINVAL on netdev socket connection
Date: Wed,  5 Oct 2022 18:20:41 +0200	[thread overview]
Message-ID: <20221005162051.1120041-8-lvivier@redhat.com> (raw)
In-Reply-To: <20221005162051.1120041-1-lvivier@redhat.com>

From: Stefano Brivio <sbrivio@redhat.com>

Other errors are treated as failure by net_socket_connect_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 net/socket.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index ade1ecf38b87..4944bb70d580 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *peer,
             if (errno == EINTR || errno == EWOULDBLOCK) {
                 /* continue */
             } else if (errno == EINPROGRESS ||
-                       errno == EALREADY ||
-                       errno == EINVAL) {
+                       errno == EALREADY) {
                 break;
             } else {
                 error_setg_errno(errp, errno, "can't connect socket");
-- 
2.37.3



  parent reply	other threads:[~2022-10-05 16:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 16:20 [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 01/17] net: introduce convert_host_port() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 02/17] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 03/17] net: simplify net_client_parse() error management Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 05/17] net: introduce qemu_set_info_str() function Laurent Vivier
2022-10-06  8:08   ` David Gibson
2022-10-05 16:20 ` [PATCH v10 06/17] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-10-05 16:20 ` Laurent Vivier [this message]
2022-10-06  8:13   ` [PATCH v10 07/17] net: socket: Don't ignore EINVAL on netdev socket connection David Gibson
2022-10-05 16:20 ` [PATCH v10 08/17] net: stream: " Laurent Vivier
2022-10-06  8:14   ` David Gibson
2022-10-05 16:20 ` [PATCH v10 09/17] net: stream: add unix socket Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 10/17] net: dgram: make dgram_dst generic Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 12/17] net: dgram: add unix socket Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 13/17] qemu-sockets: move and rename SocketAddress_to_str() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 15/17] net: stream: move to QIO to enable additional parameters Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 16/17] tests/qtest: netdev: test stream and dgram backends Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 17/17] net: stream: add QAPI events to report connection state Laurent Vivier
2022-10-06 11:20 ` [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend Michael S. Tsirkin
2022-10-09  5:52   ` Jason Wang
2022-10-11 20:04     ` Laurent Vivier
2022-10-12  1:18       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005162051.1120041-8-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sbrivio@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).