qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] gitmodules: recurse by default
Date: Thu, 6 Oct 2022 10:30:07 -0400	[thread overview]
Message-ID: <20221006102941-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA8K-4KdjuG8QqFU9gLEiZ7A3Xx3zG0FP4uP4482p0GFfA@mail.gmail.com>

On Thu, Oct 06, 2022 at 02:02:53PM +0100, Peter Maydell wrote:
> On Thu, 6 Oct 2022 at 13:36, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > The most commmon complaint about submodules is that
> > they don't follow when one switches branches in the
> > main repo. Enable recursing into submodules by default
> > to address that.
> 
> Just to check, because the git docs are a bit unclear to me,
> does this retain the existing behaviour that if a submodule
> isn't checked out at all then it remains not-checked-out ?
> (That is, we don't want to force developers to have checked
> out submodule sources for all the edk2 and other rom blob
> sources which aren't needed for day-to-day QEMU development.)
> 
> thanks
> -- PMM


I think so - by default submodules are considered inactive,
git only recurses into active modules.
I just tried the following:

>git clone qemu qemu-tst
>cd qemu-tst
>ls -l $(grep submodule .gitmodules |sed -e 's/[^"]*"//' -e 's/".//')
dtc:
total 0

meson:
total 0

roms/edk2:
total 0

roms/ipxe:
total 0

roms/openbios:
total 0

roms/opensbi:
total 0

roms/qboot:
total 0

roms/QemuMacDrivers:
total 0

roms/qemu-palcode:
total 0

roms/seabios:
total 0

roms/seabios-hppa:
total 0

roms/sgabios:
total 0

roms/skiboot:
total 0

roms/SLOF:
total 0

roms/u-boot:
total 0

roms/u-boot-sam460ex:
total 0

roms/vbootrom:
total 0

slirp:
total 0

subprojects/libvfio-user:
total 0

tests/fp/berkeley-softfloat-3:
total 0

tests/fp/berkeley-testfloat-3:
total 0

tests/lcitool/libvirt-ci:
total 0

ui/keycodemapdb:
total 0


HTH

-- 
MST



  reply	other threads:[~2022-10-06 14:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 11:39 [PATCH] gitmodules: recurse by default Michael S. Tsirkin
2022-10-06 13:02 ` Peter Maydell
2022-10-06 14:30   ` Michael S. Tsirkin [this message]
2022-10-06 15:10 ` Philippe Mathieu-Daudé via
2022-10-06 15:23   ` Peter Maydell
2022-10-06 15:29   ` Michael S. Tsirkin
2022-10-06 18:54 ` Daniel P. Berrangé
2022-10-07  0:24   ` Michael S. Tsirkin
2022-10-07  8:07     ` Daniel P. Berrangé
2022-10-07 10:11       ` Michael S. Tsirkin
2022-10-07 10:45         ` Daniel P. Berrangé
2022-10-07 11:09           ` Daniel P. Berrangé
2022-10-11 22:32             ` Michael S. Tsirkin
2022-10-12  7:51               ` Daniel P. Berrangé
2022-10-12 11:31                 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006102941-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).