qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	qemu-block@nongnu.org
Subject: [PATCH 05/18] block/vvfat: Unify the mkdir() call
Date: Thu,  6 Oct 2022 23:11:22 +0800	[thread overview]
Message-ID: <20221006151135.2078908-6-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20221006151135.2078908-1-bmeng.cn@gmail.com>

From: Bin Meng <bin.meng@windriver.com>

There is a difference in the mkdir() call for win32 and non-win32
platforms, and currently is handled in the codes with #ifdefs.

glib provides a portable g_mkdir() API and we can use it to unify
the codes without #ifdefs.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---

(no changes since v2)

Changes in v2:
- Change to use g_mkdir()

 block/vvfat.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index d6dd919683..723beef025 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -25,6 +25,7 @@
 
 #include "qemu/osdep.h"
 #include <dirent.h>
+#include <glib/gstdio.h>
 #include "qapi/error.h"
 #include "block/block_int.h"
 #include "block/qdict.h"
@@ -2726,13 +2727,9 @@ static int handle_renames_and_mkdirs(BDRVVVFATState* s)
             mapping_t* mapping;
             int j, parent_path_len;
 
-#ifdef __MINGW32__
-            if (mkdir(commit->path))
+            if (g_mkdir(commit->path, 0755)) {
                 return -5;
-#else
-            if (mkdir(commit->path, 0755))
-                return -5;
-#endif
+            }
 
             mapping = insert_mapping(s, commit->param.mkdir.cluster,
                     commit->param.mkdir.cluster + 1);
-- 
2.34.1



  parent reply	other threads:[~2022-10-06 15:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 15:11 [PATCH 00/18] tests/qtest: Enable running qtest on Windows Bin Meng
2022-10-06 15:11 ` [PATCH 01/18] semihosting/arm-compat-semi: Avoid using hardcoded /tmp Bin Meng
2022-10-06 15:11 ` [PATCH 02/18] tcg: " Bin Meng
2022-10-06 15:11 ` [PATCH 03/18] util/qemu-sockets: Use g_get_tmp_dir() to get the directory for temporary files Bin Meng
2022-10-06 15:11 ` [PATCH 04/18] tests/qtest: migration-test: Avoid using hardcoded /tmp Bin Meng
2022-10-06 15:11 ` Bin Meng [this message]
2022-10-06 15:11 ` [PATCH 06/18] fsdev/virtfs-proxy-helper: Use g_mkdir() Bin Meng
2022-10-06 15:11 ` [PATCH 07/18] hw/usb: dev-mtp: " Bin Meng
2022-10-06 15:11 ` [PATCH 08/18] accel/qtest: Support qtest accelerator for Windows Bin Meng
2022-10-06 15:11 ` [PATCH 09/18] tests/qtest: Use send/recv for socket communication Bin Meng
2022-10-06 15:11 ` [PATCH 10/18] tests/qtest: libqtest: Install signal handler via signal() Bin Meng
2022-10-06 15:11 ` [PATCH 11/18] tests/qtest: Support libqtest to build and run on Windows Bin Meng
2022-10-06 15:11 ` [PATCH 12/18] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled Bin Meng
2022-10-06 15:11 ` [PATCH 13/18] tests/qtest: libqtest: Correct the timeout unit of blocking receive calls for win32 Bin Meng
2022-10-06 15:11 ` [PATCH 14/18] io/channel-watch: Drop a superfluous '#ifdef WIN32' Bin Meng
2022-10-06 15:11 ` [PATCH 15/18] io/channel-watch: Drop the unnecessary cast Bin Meng
2022-10-06 15:11 ` [PATCH 16/18] io/channel-watch: Fix socket watch on Windows Bin Meng
2022-10-06 15:11 ` [PATCH 17/18] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes Bin Meng
2022-10-06 15:11 ` [PATCH 18/18] tests/qtest: Enable qtest build on Windows Bin Meng
2022-10-06 15:17 ` [PATCH 00/18] tests/qtest: Enable running qtest " Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006151135.2078908-6-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=bin.meng@windriver.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).