From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, peterx@redhat.com
Cc: qemu-devel@nongnu.org, yi.l.liu@intel.com,
yi.y.sun@linux.intel.com, Jason Wang <jasowang@redhat.com>
Subject: [PATCH V3 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry
Date: Sun, 9 Oct 2022 13:48:32 +0800 [thread overview]
Message-ID: <20221009054835.1540-2-jasowang@redhat.com> (raw)
In-Reply-To: <20221009054835.1540-1-jasowang@redhat.com>
We use to warn on wrong rid2pasid entry. But this error could be
triggered by the guest and could happens during initialization. So
let's don't warn in this case.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/i386/intel_iommu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 05d53a1aa9..3455e5d907 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1554,8 +1554,10 @@ static bool vtd_dev_pt_enabled(IntelIOMMUState *s, VTDContextEntry *ce)
if (s->root_scalable) {
ret = vtd_ce_get_rid2pasid_entry(s, ce, &pe);
if (ret) {
- error_report_once("%s: vtd_ce_get_rid2pasid_entry error: %"PRId32,
- __func__, ret);
+ /*
+ * This error is guest triggerable. We should assumt PT
+ * not enabled for safety.
+ */
return false;
}
return (VTD_PE_GET_TYPE(&pe) == VTD_SM_PASID_ENTRY_PT);
--
2.25.1
next prev parent reply other threads:[~2022-10-09 5:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 5:48 [PATCH V3 0/4] PASID support for Intel IOMMU Jason Wang
2022-10-09 5:48 ` Jason Wang [this message]
2022-10-14 15:05 ` [PATCH V3 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry Peter Xu
2022-10-09 5:48 ` [PATCH V3 2/4] intel-iommu: drop VTDBus Jason Wang
2022-10-09 5:48 ` [PATCH V3 3/4] intel-iommu: convert VTD_PE_GET_FPD_ERR() to be a function Jason Wang
2022-10-14 15:06 ` Peter Xu
2022-10-09 5:48 ` [PATCH V3 4/4] intel-iommu: PASID support Jason Wang
2022-10-14 16:17 ` Peter Xu
2022-10-17 7:52 ` Jason Wang
2022-10-17 15:13 ` Peter Xu
2022-10-18 6:24 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221009054835.1540-2-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).