* [PATCH] s390x/pv: remove semicolon from macro definition
@ 2022-10-10 15:10 Claudio Imbrenda
2022-10-10 15:19 ` Cornelia Huck
2022-10-17 8:11 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: Claudio Imbrenda @ 2022-10-10 15:10 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-s390x, david, thuth, borntraeger, frankja, pasic, cohuck
Remove spurious semicolon at the end of the macro s390_pv_cmd
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
hw/s390x/pv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/pv.c b/hw/s390x/pv.c
index 401b63d6cb..9bcd5d829f 100644
--- a/hw/s390x/pv.c
+++ b/hw/s390x/pv.c
@@ -45,7 +45,7 @@ static int __s390_pv_cmd(uint32_t cmd, const char *cmdname, void *data)
* This macro lets us pass the command as a string to the function so
* we can print it on an error.
*/
-#define s390_pv_cmd(cmd, data) __s390_pv_cmd(cmd, #cmd, data);
+#define s390_pv_cmd(cmd, data) __s390_pv_cmd(cmd, #cmd, data)
#define s390_pv_cmd_exit(cmd, data) \
{ \
int rc; \
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] s390x/pv: remove semicolon from macro definition
2022-10-10 15:10 [PATCH] s390x/pv: remove semicolon from macro definition Claudio Imbrenda
@ 2022-10-10 15:19 ` Cornelia Huck
2022-10-17 8:11 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2022-10-10 15:19 UTC (permalink / raw)
To: Claudio Imbrenda, qemu-devel
Cc: qemu-s390x, david, thuth, borntraeger, frankja, pasic
On Mon, Oct 10 2022, Claudio Imbrenda <imbrenda@linux.ibm.com> wrote:
> Remove spurious semicolon at the end of the macro s390_pv_cmd
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> hw/s390x/pv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390x/pv: remove semicolon from macro definition
2022-10-10 15:10 [PATCH] s390x/pv: remove semicolon from macro definition Claudio Imbrenda
2022-10-10 15:19 ` Cornelia Huck
@ 2022-10-17 8:11 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2022-10-17 8:11 UTC (permalink / raw)
To: Claudio Imbrenda, qemu-devel
Cc: qemu-s390x, david, borntraeger, frankja, pasic, cohuck
On 10/10/2022 17.10, Claudio Imbrenda wrote:
> Remove spurious semicolon at the end of the macro s390_pv_cmd
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> hw/s390x/pv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/pv.c b/hw/s390x/pv.c
> index 401b63d6cb..9bcd5d829f 100644
> --- a/hw/s390x/pv.c
> +++ b/hw/s390x/pv.c
> @@ -45,7 +45,7 @@ static int __s390_pv_cmd(uint32_t cmd, const char *cmdname, void *data)
> * This macro lets us pass the command as a string to the function so
> * we can print it on an error.
> */
> -#define s390_pv_cmd(cmd, data) __s390_pv_cmd(cmd, #cmd, data);
> +#define s390_pv_cmd(cmd, data) __s390_pv_cmd(cmd, #cmd, data)
> #define s390_pv_cmd_exit(cmd, data) \
> { \
> int rc; \
Thanks, queued to my s390x-next branch:
https://gitlab.com/thuth/qemu/-/commits/s390x-next/
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-10 15:10 [PATCH] s390x/pv: remove semicolon from macro definition Claudio Imbrenda
2022-10-10 15:19 ` Cornelia Huck
2022-10-17 8:11 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).