qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Julia Suvorova <jusual@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>,
	Julia Suvorova <jusual@redhat.com>
Subject: [PATCH v3 0/5] hw/smbios: add core_count2 to smbios table type 4
Date: Tue, 11 Oct 2022 13:17:26 +0200	[thread overview]
Message-ID: <20221011111731.101412-1-jusual@redhat.com> (raw)

The SMBIOS 3.0 specification provides the ability to reflect over
255 cores. The 64-bit entry point has been used for a while, but
structure type 4 has not been updated before, so the dmidecode output
looked like this (-smp 280):

    Handle 0x0400, DMI type 4, 42 bytes
    Processor Information
    ...
        Core Count: 24
        Core Enabled: 24
        Thread Count: 1
    ...

Big update in the bios-tables-test as it couldn't work with SMBIOS 3.0.

v3:
    * rebase on fresh master
    * crop lines to 80 characters [Igor]
    * add conditions for cc2 field check in the test [Igor]

v2:
    * generate tables type 4 of different sizes based on the
      selected smbios version
    * use SmbiosEntryPoint* types instead of creating new constants
    * refactor smbios_cpu_test [Igor, Ani]
    * clarify signature check [Igor]
    * add comments with specifications and clarification of the structure loop [Ani]


Julia Suvorova (5):
  hw/smbios: add core_count2 to smbios table type 4
  bios-tables-test: teach test to use smbios 3.0 tables
  tests/acpi: allow changes for core_count2 test
  bios-tables-test: add test for number of cores > 255
  tests/acpi: update tables for new core count test

 hw/smbios/smbios.c                   |  19 +++-
 hw/smbios/smbios_build.h             |   9 +-
 include/hw/firmware/smbios.h         |  12 ++
 tests/data/acpi/q35/APIC.core-count2 | Bin 0 -> 2478 bytes
 tests/data/acpi/q35/DSDT.core-count2 | Bin 0 -> 32414 bytes
 tests/data/acpi/q35/FACP.core-count2 | Bin 0 -> 244 bytes
 tests/qtest/bios-tables-test.c       | 158 ++++++++++++++++++++-------
 7 files changed, 156 insertions(+), 42 deletions(-)
 create mode 100644 tests/data/acpi/q35/APIC.core-count2
 create mode 100644 tests/data/acpi/q35/DSDT.core-count2
 create mode 100644 tests/data/acpi/q35/FACP.core-count2

-- 
2.37.3



             reply	other threads:[~2022-10-11 13:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 11:17 Julia Suvorova [this message]
2022-10-11 11:17 ` [PATCH v3 1/5] hw/smbios: add core_count2 to smbios table type 4 Julia Suvorova
2022-10-11 11:17 ` [PATCH v3 2/5] bios-tables-test: teach test to use smbios 3.0 tables Julia Suvorova
2022-10-11 11:17 ` [PATCH v3 3/5] tests/acpi: allow changes for core_count2 test Julia Suvorova
2022-10-14 14:22   ` Igor Mammedov
2022-10-11 11:17 ` [PATCH v3 4/5] bios-tables-test: add test for number of cores > 255 Julia Suvorova
2022-10-14 14:22   ` Igor Mammedov
2022-10-11 11:17 ` [PATCH v3 5/5] tests/acpi: update tables for new core count test Julia Suvorova
2022-10-27  6:11   ` Michael S. Tsirkin
2022-10-27 14:11     ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011111731.101412-1-jusual@redhat.com \
    --to=jusual@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).