qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Greg Kurz" <groug@kaod.org>, "Eric Blake" <eblake@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>, "Thomas Huth" <thuth@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paul Durrant" <paul@xen.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	xen-devel@lists.xenproject.org,
	"Stefano Brivio" <sbrivio@redhat.com>
Subject: [PATCH v11 08/17] net: stream: Don't ignore EINVAL on netdev socket connection
Date: Tue, 11 Oct 2022 22:05:30 +0200	[thread overview]
Message-ID: <20221011200539.1486809-9-lvivier@redhat.com> (raw)
In-Reply-To: <20221011200539.1486809-1-lvivier@redhat.com>

From: Stefano Brivio <sbrivio@redhat.com>

Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 net/stream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/stream.c b/net/stream.c
index 37965eb74e1a..26e485438718 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -360,8 +360,7 @@ static int net_stream_client_init(NetClientState *peer,
                 if (errno == EINTR || errno == EWOULDBLOCK) {
                     /* continue */
                 } else if (errno == EINPROGRESS ||
-                           errno == EALREADY ||
-                           errno == EINVAL) {
+                           errno == EALREADY) {
                     break;
                 } else {
                     error_setg_errno(errp, errno, "can't connect socket");
-- 
2.37.3



  parent reply	other threads:[~2022-10-11 20:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 20:05 [PATCH v11 00/17] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 01/17] net: introduce convert_host_port() Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 02/17] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 03/17] net: simplify net_client_parse() error management Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 05/17] net: introduce qemu_set_info_str() function Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 06/17] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 07/17] net: socket: Don't ignore EINVAL on netdev socket connection Laurent Vivier
2022-10-11 20:05 ` Laurent Vivier [this message]
2022-10-11 20:05 ` [PATCH v11 09/17] net: stream: add unix socket Laurent Vivier
2022-10-17 13:17   ` Markus Armbruster
2022-10-11 20:05 ` [PATCH v11 10/17] net: dgram: make dgram_dst generic Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 12/17] net: dgram: add unix socket Laurent Vivier
2022-10-17 13:18   ` Markus Armbruster
2022-10-11 20:05 ` [PATCH v11 13/17] qemu-sockets: move and rename SocketAddress_to_str() Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 15/17] net: stream: move to QIO to enable additional parameters Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 16/17] tests/qtest: netdev: test stream and dgram backends Laurent Vivier
2022-10-11 20:05 ` [PATCH v11 17/17] net: stream: add QAPI events to report connection state Laurent Vivier
2022-10-17 13:23   ` Markus Armbruster
2022-10-17 14:03     ` Laurent Vivier
2022-10-20 10:22       ` Markus Armbruster
2022-10-20 12:34         ` Laurent Vivier
2022-10-26 19:39 ` [PATCH v11 00/17] qapi: net: add unix socket type support to netdev backend Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011200539.1486809-9-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sbrivio@redhat.com \
    --cc=sstabellini@kernel.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).